[HOP-3744] NPE when you have a window without name and try to close it

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.2.0
• Labels: pull-request-available
• Assignee: Gabriel Dutra
• Reporter: Gabriel Dutra
• Created: 09/Feb/22 06:53
• Updated: 11/Feb/22 09:24
• Resolved: 09/Feb/22 07:02

Description

When you have multiple windows on the same metadata type and try to close it, it throws an NPE failing to close the tab.

Error in the Hop GUI : null
java.lang.NullPointerException
        at org.apache.hop.metadata.api.HopMetadataBase.equals(HopMetadataBase.java:51)
        at java.util.Objects.equals(Objects.java:59)
        at org.apache.hop.ui.core.metadata.MetadataEditor.equals(MetadataEditor.java:116)
        at java.util.ArrayList.remove(ArrayList.java:534)
        at org.apache.hop.ui.hopgui.perspective.metadata.MetadataPerspective.onTabClose(MetadataPerspective.java:475)
        at org.apache.hop.ui.hopgui.perspective.metadata.MetadataPerspective$1.close(MetadataPerspective.java:316)
        at org.eclipse.swt.custom.CTabFolder.onMouse(CTabFolder.java:1960)
        at org.eclipse.swt.custom.CTabFolder.lambda$0(CTabFolder.java:335)
        at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:89)
        at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4209)
        at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1043)
        at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4026)
        at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3626)
        at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:381)
        at org.apache.hop.ui.hopgui.HopGui.main(HopGui.java:301) 

Issue Links

• links to: GitHub Pull Request #1350