[HOP-2262] Native core plugins a registered twice

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 0.70
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Nicolas Adment
• Created: 04/Dec/20 19:40
• Updated: 03/Feb/21 07:38
• Resolved: 29/Jan/21 22:44

Description

The 6 native core plugins below are iniatilized twice, when HopEnvironment calls PluginRegistry.init (), all core plugins previously added plugins are initialized a second time (slow startup)

• org.apache.hop.core.row.value.ValueMetaPlugin
• org.apache.hop.core.database.DatabaseMetaPlugin
• org.apache.hop.core.extension.ExtensionPoint
• org.apache.hop.core.encryption.TwoWayPasswordEncoderPlugin
• org.apache.hop.core.vfs.plugin.VfsPlugin
• org.apache.hop.core.logging.LoggingPlugin

 

The sequence order:

1) HopClientEnvironment add core plugin type

2) HopClientEnvironment init plugin registry

3) HopEnvironment add engine plugin type

4) HopEnvironment init plugin registry (core + engine)

 

It is useful to differentiate whether the PluginType is added or registered ?

In my opinion we can solve the problem by removing the addPluginType and init methods, and keeping the registerPluginType method.