[HOP-1941] Error when opening second hop-web tab

• Type: Task
• Status: Closed
• Priority: Major
• Resolution: Done
• Fix Version/s: pre-apache
• Component/s: Hop Web
• Labels: pre-apache
• Assignee: Unassigned
• Reporter: Maximilian Michels
• Created: 04/Oct/20 12:20
• Updated: 08/Oct/20 15:15
• Resolved: 04/Oct/20 12:29

Description

Reproduction: open Web hop in a tab in a browser
Then open another tab. I get the error below.
It's an architectural concern in the sense that we need a way for plugins to find their way to the right instance. getInstance() doesn't work very well in a multi-HopGui-instance scenario.

org.eclipse.swt.SWTException: Invalid thread access
at org.eclipse.swt.SWT.error(SWT.java:3808)
at org.eclipse.swt.SWT.error(SWT.java:3731)
at org.eclipse.swt.SWT.error(SWT.java:3702)
at org.eclipse.swt.widgets.Widget.error(Widget.java:1018)
at org.eclipse.swt.widgets.Widget.dispose(Widget.java:837)
at org.apache.hop.git.HopGitPerspective.addChangedTable(HopGitPerspective.java:357)
at org.apache.hop.git.HopGitPerspective.initialize(HopGitPerspective.java:348)
at org.apache.hop.ui.hopgui.HopGui.loadPerspectives(HopGui.java:381)
at org.apache.hop.ui.hopgui.HopGui.open(HopGui.java:327)
at org.apache.hop.ui.hopgui.WebSpoonEntryPoint.createContents(WebSpoonEntryPoint.java:89)
at org.eclipse.rap.rwt.application.AbstractEntryPoint.createUI(AbstractEntryPoint.java:60)
at org.eclipse.rap.rwt.internal.lifecycle.RWTLifeCycle.createUI(RWTLifeCycle.java:177)
at org.eclipse.rap.rwt.internal.lifecycle.RWTLifeCycle$UIThreadController.run(RWTLifeCycle.java:290)
at java.lang.Thread.run(Thread.java:748)
at org.eclipse.rap.rwt.internal.lifecycle.UIThread.run(UIThread.java:107)