[HIVEMIND-4] Enhance logging of exceptions when setting a service property to a contribution

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Fix Version/s: 1.0
• Component/s: framework
• Environment: hivemind-1.0.beta-1-snapshot.jar
• Assignee: Howard Lewis Ship
• Reporter: Steve Gibson
• Created: 07/Jun/04 17:17
• Updated: 10/Jun/04 18:27
• Resolved: 10/Jun/04 18:27

Description

I am guessing the source of the exception for this, so this may be a little vague.

If an exception is thrown due to a bug in the schema definition or a contribution to a configuration point, when a service using the affected configuration point is instantiated, a message of limited usefulness is logged of the form:

ERROR: <module-id>.<service-id> - Unable to update property <property-name> of object <service-impl-class.toString()> (at <module-descriptor-url>, line <line number of set-configuration>): null

To me, that suggests I am getting a NullPointerException somewhere, as I dig through the source and find in PropertyAdaptor:
try
{
_writeMethod.invoke(target, new Object[]

{ value }

);
}
catch (Exception ex)

{ throw new ApplicationRuntimeException( UtilMessages.writeFailure(_propertyName, target, location, ex), target, HiveMind.getLocation(location), ex); }

with UtilMessages.writeFailure containing:
return HiveMind.format(
"PropertyAdaptor.write-failure",
new Object[]

{ propertyName, target, HiveMind.getLocationString(location), cause.getMessage()}

);

With a NullPointerException, the cause is null, so perhaps a better approach would be:
cause.getMessage()!=null?cause.getMessage():cause

I will attach my test code.
I will also investigate the chain of the ApplicationRuntimeException, though its trace is not being logged.