[HIVEMIND-41] No bounds checking in SchemaProcessorImpl stack

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0
• Component/s: framework
• Assignee: Howard Lewis Ship
• Reporter: Steve Gibson
• Created: 06/Aug/04 17:28
• Updated: 12/Aug/04 15:00
• Resolved: 11/Aug/04 18:49

Description

org.apache.hivemind.impl.SchemaProcessorImpl aggregates stack functionality along with its other functions. This is achieved by a java.util.List and some public methods.
Unfortunately, these methods do not perform bounds checking or a way to check the size of thist stack. Java does do this, and throws ArrayIndexOutOfBoundsException, but the resulting exception seen in client code looks like:
2004-08-06 13:22:31,959 com.cowww.test.commons.hivemind.RegistryFactoryTestCase [ERROR] org.apache.hivemind.ApplicationRuntimeException: Unable to construct configuration cowww.HibernateConfiguration: -1
java.util.Stack throws an EmptyStackException in this case, which is a lot easier to diagnose without having to check the rootCause.

My opinion is that:
1. EmptyStackException is thrown
2. A method for checking the stack depth is added.
It may be easier to just use a Stack internally and make the pertinent methods available to calling classes.