Uploaded image for project: 'Hivemall'
  1. Hivemall
  2. HIVEMALL-211

[BUGFIX] Fixed Optimizer for regularization updates

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.5.0
    • Fix Version/s: 0.5.2
    • Labels:
      None

      Description

      In https://github.com/apache/incubator-hivemall/blob/master/core/src/main/java/hivemall/optimizer/Optimizer.java#L73

      float g = _reg.regularize(oldWeight, gradient);
      float delta = computeDelta(weight, g);
      float newWeight = oldWeight - _eta.eta(_numStep) * delta;
      

      should be

      float delta = computeDelta(weight, gradient);
      float newWeight = oldWeight - _eta.eta(_numStep) * _reg.regularize(oldWeight, delta);
      

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                myui Makoto Yui
                Reporter:
                myui Makoto Yui
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Due:
                  Created:
                  Updated:
                  Resolved: