[HIVE-816] MetastoreClient not being cached

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.3.0
• Fix Version/s: 0.4.0
• Component/s: Metastore
• Hadoop Flags: Reviewed
• Release Note: HIVE-816. Cache MetastoreClient. (Dave Lerman via zshao)
• Assignee: Dave Lerman
• Reporter: Dave Lerman
• Created: 04/Sep/09 20:33
• Updated: 17/Dec/11 00:07
• Resolved: 04/Sep/09 21:22

Description

In org.apache.hadoop.hive.ql.metadata.Hive.getMSC(), we create a new MetaStoreClient on every call because the result is not getting properly cached in the threadLocal:

  private IMetaStoreClient getMSC() throws MetaException {
    IMetaStoreClient msc = threadLocalMSC.get();
    if(msc == null) {
      msc = this.createMetaStoreClient();
      // THERE SHOULD BE A threadLocalMSC.set here!
    }
    return msc;
  }