Hive
  1. Hive
  2. HIVE-7364

Trunk cannot be built on -Phadoop1 after HIVE-7144

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: Build Infrastructure
    • Labels:
      None

      Description

      Text.copyBytes() is introduced in hadoop-2

        Issue Links

          Activity

          Hide
          Damien Carol added a comment -

          Maybe we can implement copyBytes()
          It's a simple method :

          /**
             * Get a copy of the bytes that is exactly the length of the data.
             * See {@link #getBytes()} for faster access to the underlying array.
             */
            public byte[] copyBytes() {
              byte[] result = new byte[length];
              System.arraycopy(bytes, 0, result, 0, length);
              return result;
            }
          

          We can do it by adding this private method :

          private byte[] copyBytes(Text text) {
              byte[] result = new byte[text.getLength()];
              System.arraycopy(text.getBytes(), 0, result, 0, text.getLength());
              return result;
            }
          
          Show
          Damien Carol added a comment - Maybe we can implement copyBytes() It's a simple method : /** * Get a copy of the bytes that is exactly the length of the data. * See {@link #getBytes()} for faster access to the underlying array. */ public byte [] copyBytes() { byte [] result = new byte [length]; System .arraycopy(bytes, 0, result, 0, length); return result; } We can do it by adding this private method : private byte [] copyBytes(Text text) { byte [] result = new byte [text.getLength()]; System .arraycopy(text.getBytes(), 0, result, 0, text.getLength()); return result; }
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12654428/HIVE-7364.1.patch.txt

          ERROR: -1 due to 4 failed/errored test(s), 5701 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_8
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table
          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority
          org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/707/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/707/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-707/

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 4 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12654428

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12654428/HIVE-7364.1.patch.txt ERROR: -1 due to 4 failed/errored test(s), 5701 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_8 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_schemeAuthority org.apache.hive.jdbc.miniHS2.TestHiveServer2.testConnection Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/707/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/707/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-Build-707/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 4 tests failed This message is automatically generated. ATTACHMENT ID: 12654428
          Hide
          Jason Dere added a comment -

          No need to re-implement copyBytes() - as far as I can tell we actually eliminate an extra copy call by passing in Text instead of calling copyBytes().

          +1

          Show
          Jason Dere added a comment - No need to re-implement copyBytes() - as far as I can tell we actually eliminate an extra copy call by passing in Text instead of calling copyBytes(). +1
          Hide
          Navis added a comment -

          Committed to trunk. Thanks Jason, for the review.

          Show
          Navis added a comment - Committed to trunk. Thanks Jason, for the review.
          Hide
          Gopal V added a comment -

          Thanks Navis for fixing this.

          Is there some change happening to the build infra that helps me catch such issues pre-commit?

          Show
          Gopal V added a comment - Thanks Navis for fixing this. Is there some change happening to the build infra that helps me catch such issues pre-commit?
          Hide
          Szehon Ho added a comment -

          There's no way build infra can handle running test in both profiles, but I think we can probably add a pre-test step to compile with optional profiles, though complexity would be in how generic it has to be.

          Show
          Szehon Ho added a comment - There's no way build infra can handle running test in both profiles, but I think we can probably add a pre-test step to compile with optional profiles, though complexity would be in how generic it has to be.
          Hide
          Szehon Ho added a comment -
          Show
          Szehon Ho added a comment - HIVE-7375
          Hide
          Gopal V added a comment -

          Thanks, Szehon Ho. Will follow that JIRA.

          Show
          Gopal V added a comment - Thanks, Szehon Ho . Will follow that JIRA.
          Hide
          Thejas M Nair added a comment -

          This has been fixed in 0.14 release. Please open new jira if you see any issues.

          Show
          Thejas M Nair added a comment - This has been fixed in 0.14 release. Please open new jira if you see any issues.

            People

            • Assignee:
              Navis
              Reporter:
              Navis
            • Votes:
              0 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development