Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-716

Web Interface wait/notify, interface changes

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 0.5.0
    • Web UI
    • None
    • All

    • Reviewed

    Description

      In TestHWISessionItem

      Asserts are backwards

      assertEquals(  searchItem.getQueryRet(), 0);
      

      Should be

      assertEquals( zero , searchItem.getQueryRet());
      

      Wait/notify semantics can be added. This is helpful for end user, and cleaner in the test case.

      while (user1_item2.getStatus() != HWISessionItem.WebSessionItemStatus.QUERY_COMPLETE) {
        Thread.sleep(1);
      }
      
      synchronized (user1_item2.runnable) {
        while (user1_item2.getStatus() != HWISessionItem.WebSessionItemStatus.QUERY_COMPLETE) {
           user1_item2.runnable.wait();
        }
      }
      

      The text box in the web interface should accept multiple queries separated by ';' like the cli does. This will add more usability. No need for separate set processor pages.

      setQuery(String) is replaced by setQueries(List<String>)

      Attachments

        1. hive-716.diff
          15 kB
          Edward Capriolo
        2. hive-716-2.diff
          23 kB
          Edward Capriolo
        3. hive-716-3.diff
          33 kB
          Edward Capriolo
        4. hive-716-4.diff
          36 kB
          Edward Capriolo
        5. hive-716-5.diff
          40 kB
          Edward Capriolo
        6. hive-716-6.diff
          40 kB
          Edward Capriolo
        7. hwi_query_box.png
          55 kB
          Edward Capriolo

        Activity

          People

            appodictic Edward Capriolo
            appodictic Edward Capriolo
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: