Hive
  1. Hive
  2. HIVE-6983

Remove test.warehouse.scheme parameter

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: 0.14.0
    • Fix Version/s: None
    • Component/s: Tests
    • Labels:
      None

      Description

      There is a parameter "test.warehouse.scheme" that does not seem to achieve much in the tests that use it, but causes issues in some environments like the windows environment when trying to test for path equality. We also seem to explicitly null it out for hive itests because it has previously been set.

      We should remove it as something that's not useful anymore.

      1. HIVE-6983.patch
        4 kB
        Sushanth Sowmyan

        Activity

        Hide
        Sushanth Sowmyan added a comment -

        Patch attached.

        Show
        Sushanth Sowmyan added a comment - Patch attached.
        Hide
        Sushanth Sowmyan added a comment -

        Committed to 2.1-maint

        commit 57167c00ecce5f7cd150e8fa7eaf509c70ab7b53
        Author: Sushanth Sowmyan <khorgath@gmail.com>
        Date: Mon Apr 28 14:42:06 2014 -0700

        [BUG-17249]HIVE-6983 SUMMARY-[Remove test.warehouse.scheme parameter]

        Show
        Sushanth Sowmyan added a comment - Committed to 2.1-maint commit 57167c00ecce5f7cd150e8fa7eaf509c70ab7b53 Author: Sushanth Sowmyan <khorgath@gmail.com> Date: Mon Apr 28 14:42:06 2014 -0700 [BUG-17249] HIVE-6983 SUMMARY- [Remove test.warehouse.scheme parameter]
        Hide
        Sushanth Sowmyan added a comment -

        (Ugh, apologies on the above comment, that was an internal commit to my own repo, not to hive repo, and that comment was for my own tracking on a different jira)

        Show
        Sushanth Sowmyan added a comment - (Ugh, apologies on the above comment, that was an internal commit to my own repo, not to hive repo, and that comment was for my own tracking on a different jira)
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12642334/HIVE-6983.patch

        ERROR: -1 due to 29 failed/errored test(s), 5408 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_database_location
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_database_json
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_01_nonpart
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_02_part
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_03_nonpart_over_compat
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_04_all_part
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_05_some_part
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_06_one_part
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_07_all_part_over_nonoverlap
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_08_nonpart_rename
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_09_part_spec_nonoverlap
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_10_external_managed
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_17_part_managed
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_18_part_external
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_22_import_exist_authsuccess
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_23_import_part_authsuccess
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_24_import_nonexist_authsuccess
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_hidden_files
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby2_map_skew
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_query_oneskew_1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_query_oneskew_2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_query_oneskew_3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_list_bucket
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_noscan_2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_partscan_1_23
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table
        org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_dynamic_partitions_with_whitelist
        org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_stats_partialscan_autogether
        org.apache.hadoop.hive.ql.security.TestFolderPermissions.testEximPermissionInheritance
        

        Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/72/testReport
        Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/72/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 29 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12642334

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12642334/HIVE-6983.patch ERROR: -1 due to 29 failed/errored test(s), 5408 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_database_location org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_database_json org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_01_nonpart org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_02_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_03_nonpart_over_compat org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_04_all_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_05_some_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_06_one_part org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_07_all_part_over_nonoverlap org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_08_nonpart_rename org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_09_part_spec_nonoverlap org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_10_external_managed org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_17_part_managed org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_18_part_external org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_22_import_exist_authsuccess org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_23_import_part_authsuccess org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_24_import_nonexist_authsuccess org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_exim_hidden_files org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby2_map_skew org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_query_oneskew_1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_query_oneskew_2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_query_oneskew_3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_list_bucket org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_noscan_2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats_partscan_1_23 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_dynamic_partitions_with_whitelist org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_stats_partialscan_autogether org.apache.hadoop.hive.ql.security.TestFolderPermissions.testEximPermissionInheritance Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/72/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-Build/72/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 29 tests failed This message is automatically generated. ATTACHMENT ID: 12642334
        Hide
        Sushanth Sowmyan added a comment -

        Canceling patch, the failure from TestFolderPermissions is a valid failure - I'll have an update up soon.

        Show
        Sushanth Sowmyan added a comment - Canceling patch, the failure from TestFolderPermissions is a valid failure - I'll have an update up soon.
        Hide
        Sushanth Sowmyan added a comment -

        Canceling altogether as WONTFIX, looks like we do need this parameter for some tests, as of now, anyway. It then becomes something testcases need to take care of to check dirs for equality instead.

        Show
        Sushanth Sowmyan added a comment - Canceling altogether as WONTFIX, looks like we do need this parameter for some tests, as of now, anyway. It then becomes something testcases need to take care of to check dirs for equality instead.

          People

          • Assignee:
            Sushanth Sowmyan
            Reporter:
            Sushanth Sowmyan
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development