Hive
  1. Hive
  2. HIVE-6908

TestThriftBinaryCLIService.testExecuteStatementAsync has intermittent failures

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0
    • Component/s: Tests
    • Labels:
      None

      Description

      This has failed sometimes in the pre-commit tests.

      ThriftCLIServiceTest.testExecuteStatementAsync runs two statements. They are given 100 second timeout total, not sure if its by intention. As the first is a select query, it will take a majority of the time. The second statement (create table) should be quicker, but it fails sometimes because timeout is already mostly used up.

      The timeout should probably be reset after the first statement. If the operation finishes before the timeout, it wont have any effect as it'll break out.

        Issue Links

          Activity

          Hide
          Szehon Ho added a comment -

          Attaching a fix.

          Show
          Szehon Ho added a comment - Attaching a fix.
          Hide
          Ashutosh Chauhan added a comment -

          Doesn't this mean test is poorly written if it is relying on timing of operations ? May be test can be rewritten in a different way so it doesnt rely on timeouts.

          Show
          Ashutosh Chauhan added a comment - Doesn't this mean test is poorly written if it is relying on timing of operations ? May be test can be rewritten in a different way so it doesnt rely on timeouts.
          Hide
          Szehon Ho added a comment -

          We can eliminate the polling timeout, but I guess the author was thinking that timeout is better than hang for unit-test purpose, if the status is not updated successfully. Or did you have some other thoughts?

          Show
          Szehon Ho added a comment - We can eliminate the polling timeout, but I guess the author was thinking that timeout is better than hang for unit-test purpose, if the status is not updated successfully. Or did you have some other thoughts?
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12640168/HIVE-6908.patch

          ERROR: -1 due to 1 failed/errored test(s), 5401 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16
          

          Test results: http://bigtop01.cloudera.org:8080/job/precommit-hive/10/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/precommit-hive/10/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12640168

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12640168/HIVE-6908.patch ERROR: -1 due to 1 failed/errored test(s), 5401 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 Test results: http://bigtop01.cloudera.org:8080/job/precommit-hive/10/testReport Console output: http://bigtop01.cloudera.org:8080/job/precommit-hive/10/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12640168
          Hide
          Ashutosh Chauhan added a comment -

          I am not sure what original author of test had in mind for this. Perhaps Vaibhav Gumashta may know more.

          Show
          Ashutosh Chauhan added a comment - I am not sure what original author of test had in mind for this. Perhaps Vaibhav Gumashta may know more.
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Szehon!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Szehon!
          Hide
          Thejas M Nair added a comment -

          This has been fixed in 0.14 release. Please open new jira if you see any issues.

          Show
          Thejas M Nair added a comment - This has been fixed in 0.14 release. Please open new jira if you see any issues.

            People

            • Assignee:
              Szehon Ho
              Reporter:
              Szehon Ho
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development