Hive
  1. Hive
  2. HIVE-6862

add DB schema DDL and upgrade 12to13 scripts for MS SQL Server

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0, 0.13.1
    • Component/s: Metastore
    • Labels:
      None

      Description

      need to add a unifed 0.13 script and a separate script for ACID support

      NO PRECOMMIT TESTS

      1. HIVE-6862.patch
        118 kB
        Eugene Koifman
      2. HIVE-6862.2.patch
        104 kB
        Eugene Koifman
      3. HIVE-6862.3.patch
        103 kB
        Eugene Koifman

        Activity

        Eugene Koifman created issue -
        Eugene Koifman made changes -
        Field Original Value New Value
        Summary add DB schema DDL statements for MS SQL Server add DB schema DDL and upgrade 12to13 scripts for MS SQL Server
        Eugene Koifman made changes -
        Attachment HIVE-6862.patch [ 12639325 ]
        Eugene Koifman made changes -
        Description need to add a unifed 0.13 script and a separate script for ACID support need to add a unifed 0.13 script and a separate script for ACID support

        NO PRECOMMIT TESTS
        Eugene Koifman made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ashutosh Chauhan added a comment -

        Eugene Koifman All other DBs also have README providing instructions on how to effect upgrade. It will be good to have that for MS SQL as well.

        Show
        Ashutosh Chauhan added a comment - Eugene Koifman All other DBs also have README providing instructions on how to effect upgrade. It will be good to have that for MS SQL as well.
        Eugene Koifman made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Eugene Koifman added a comment -

        added readme

        Show
        Eugene Koifman added a comment - added readme
        Eugene Koifman made changes -
        Attachment HIVE-6862.2.patch [ 12640329 ]
        Eugene Koifman made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Lefty Leverenz added a comment -

        Nice README. Just one question and some nits:

        MetaStore Upgrade Steps

        • Step 3 refers to creating a schema dump in the previous step, but I don't see it. Did you mean in step 1 as part of best practices?
        • Step 4 needs a period at the end.
        • Step 5 "statement" should be plural and "you" should be "your" (and while I'm nitting, elsewhere you had only one space between sentences).

        Upgrading from 0.11.0 to 0.13.0

        • Step 2 has lots of trailing whitespace on the <property>, <name>, and <value> lines and repeats "to create" (and has two spaces between sentences again).
        Show
        Lefty Leverenz added a comment - Nice README. Just one question and some nits: MetaStore Upgrade Steps Step 3 refers to creating a schema dump in the previous step, but I don't see it. Did you mean in step 1 as part of best practices? Step 4 needs a period at the end. Step 5 "statement" should be plural and "you" should be "your" (and while I'm nitting, elsewhere you had only one space between sentences). Upgrading from 0.11.0 to 0.13.0 Step 2 has lots of trailing whitespace on the <property>, <name>, and <value> lines and repeats "to create" (and has two spaces between sentences again).
        Hide
        Eugene Koifman added a comment -

        HIVE-6862.3.patch to address Lefty Leverenz's comments

        Show
        Eugene Koifman added a comment - HIVE-6862 .3.patch to address Lefty Leverenz 's comments
        Eugene Koifman made changes -
        Attachment HIVE-6862.3.patch [ 12640513 ]
        Hide
        Lefty Leverenz added a comment -

        Sorry to be a pest, but step 2 in Updating still repeats "to create" –

        + in your hive-site.xml. This will cause DataNucleus to create to
        + create tables which are missing from your database once metastore starts.

        Show
        Lefty Leverenz added a comment - Sorry to be a pest, but step 2 in Updating still repeats "to create" – + in your hive-site.xml. This will cause DataNucleus to create to + create tables which are missing from your database once metastore starts.
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Eugene!
        Lefty I edited that line while committing.

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Eugene! Lefty I edited that line while committing.
        Ashutosh Chauhan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.14.0 [ 12326450 ]
        Resolution Fixed [ 1 ]
        Hide
        Lefty Leverenz added a comment -

        Thanks, Ashutosh. (No more complaints about broken docs.)

        Show
        Lefty Leverenz added a comment - Thanks, Ashutosh. (No more complaints about broken docs.)
        Sushanth Sowmyan made changes -
        Fix Version/s 0.13.1 [ 12326829 ]
        Hide
        Thejas M Nair added a comment -

        This jira has been fixed as part of 0.13.1 release. If you find further issues, please create a new jira and link it to this one.

        Show
        Thejas M Nair added a comment - This jira has been fixed as part of 0.13.1 release. If you find further issues, please create a new jira and link it to this one.
        Thejas M Nair made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Eugene Koifman
            Reporter:
            Eugene Koifman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development