Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-6862

add DB schema DDL and upgrade 12to13 scripts for MS SQL Server

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.14.0, 0.13.1
    • Component/s: Metastore
    • Labels:
      None

      Description

      need to add a unifed 0.13 script and a separate script for ACID support

      NO PRECOMMIT TESTS

      1. HIVE-6862.2.patch
        104 kB
        Eugene Koifman
      2. HIVE-6862.3.patch
        103 kB
        Eugene Koifman
      3. HIVE-6862.patch
        118 kB
        Eugene Koifman

        Activity

        Hide
        ashutoshc Ashutosh Chauhan added a comment -

        Eugene Koifman All other DBs also have README providing instructions on how to effect upgrade. It will be good to have that for MS SQL as well.

        Show
        ashutoshc Ashutosh Chauhan added a comment - Eugene Koifman All other DBs also have README providing instructions on how to effect upgrade. It will be good to have that for MS SQL as well.
        Hide
        ekoifman Eugene Koifman added a comment -

        added readme

        Show
        ekoifman Eugene Koifman added a comment - added readme
        Hide
        leftylev Lefty Leverenz added a comment -

        Nice README. Just one question and some nits:

        MetaStore Upgrade Steps

        • Step 3 refers to creating a schema dump in the previous step, but I don't see it. Did you mean in step 1 as part of best practices?
        • Step 4 needs a period at the end.
        • Step 5 "statement" should be plural and "you" should be "your" (and while I'm nitting, elsewhere you had only one space between sentences).

        Upgrading from 0.11.0 to 0.13.0

        • Step 2 has lots of trailing whitespace on the <property>, <name>, and <value> lines and repeats "to create" (and has two spaces between sentences again).
        Show
        leftylev Lefty Leverenz added a comment - Nice README. Just one question and some nits: MetaStore Upgrade Steps Step 3 refers to creating a schema dump in the previous step, but I don't see it. Did you mean in step 1 as part of best practices? Step 4 needs a period at the end. Step 5 "statement" should be plural and "you" should be "your" (and while I'm nitting, elsewhere you had only one space between sentences). Upgrading from 0.11.0 to 0.13.0 Step 2 has lots of trailing whitespace on the <property>, <name>, and <value> lines and repeats "to create" (and has two spaces between sentences again).
        Hide
        ekoifman Eugene Koifman added a comment -

        HIVE-6862.3.patch to address Lefty Leverenz's comments

        Show
        ekoifman Eugene Koifman added a comment - HIVE-6862 .3.patch to address Lefty Leverenz 's comments
        Hide
        leftylev Lefty Leverenz added a comment -

        Sorry to be a pest, but step 2 in Updating still repeats "to create" –

        + in your hive-site.xml. This will cause DataNucleus to create to
        + create tables which are missing from your database once metastore starts.

        Show
        leftylev Lefty Leverenz added a comment - Sorry to be a pest, but step 2 in Updating still repeats "to create" – + in your hive-site.xml. This will cause DataNucleus to create to + create tables which are missing from your database once metastore starts.
        Hide
        ashutoshc Ashutosh Chauhan added a comment -

        +1

        Show
        ashutoshc Ashutosh Chauhan added a comment - +1
        Hide
        ashutoshc Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Eugene!
        Lefty I edited that line while committing.

        Show
        ashutoshc Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Eugene! Lefty I edited that line while committing.
        Hide
        leftylev Lefty Leverenz added a comment -

        Thanks, Ashutosh. (No more complaints about broken docs.)

        Show
        leftylev Lefty Leverenz added a comment - Thanks, Ashutosh. (No more complaints about broken docs.)
        Hide
        thejas Thejas M Nair added a comment -

        This jira has been fixed as part of 0.13.1 release. If you find further issues, please create a new jira and link it to this one.

        Show
        thejas Thejas M Nair added a comment - This jira has been fixed as part of 0.13.1 release. If you find further issues, please create a new jira and link it to this one.

          People

          • Assignee:
            ekoifman Eugene Koifman
            Reporter:
            ekoifman Eugene Koifman
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development