Hive
  1. Hive
  2. HIVE-6507

OrcFile table property names are specified as strings

    Details

    • Release Note:
      (none, this is minor refactoring so as to avoid future issues where new orc properties are added and not accounted for in HCatalog/etc)

      Description

      In HIVE-5504, we had to do some special casing in HCatalog to add a particular set of orc table properties from table properties to job properties.

      In doing so, it's obvious that that is a bit cumbersome, and ideally, the list of all orc file table properties should really be an enum, rather than individual loosely tied constant strings. If we were to clean this up, we can clean up other code that references this to reference the entire enum, and avoid future errors when new table properties are introduced, but other referencing code is not updated.

      1. HIVE-6507.2.patch
        6 kB
        Sushanth Sowmyan
      2. HIVE-6507.patch
        6 kB
        Sushanth Sowmyan

        Issue Links

          Activity

          Hide
          Thejas M Nair added a comment -

          Patch committed to trunk and 0.13 branch (in list of 0.13 patches maintained by Harish).
          Thanks for the contribution Sushanth!

          Show
          Thejas M Nair added a comment - Patch committed to trunk and 0.13 branch (in list of 0.13 patches maintained by Harish). Thanks for the contribution Sushanth!
          Hide
          Sushanth Sowmyan added a comment -

          Noting that 2 of the test failures reported are due to the upgrade to 0.14, and one is disconnected from this issue. Also, the new patch does not change behaviour from the previous patch except for adding back in the string constants with deprecation notices, and thus, should not change test behaviour.

          Show
          Sushanth Sowmyan added a comment - Noting that 2 of the test failures reported are due to the upgrade to 0.14, and one is disconnected from this issue. Also, the new patch does not change behaviour from the previous patch except for adding back in the string constants with deprecation notices, and thus, should not change test behaviour.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12631113/HIVE-6507.patch

          ERROR: -1 due to 3 failed/errored test(s), 5354 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16
          org.apache.hive.beeline.TestSchemaTool.testSchemaInit
          org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1631/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1631/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 3 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12631113

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12631113/HIVE-6507.patch ERROR: -1 due to 3 failed/errored test(s), 5354 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 org.apache.hive.beeline.TestSchemaTool.testSchemaInit org.apache.hive.beeline.TestSchemaTool.testSchemaUpgrade Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1631/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1631/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed This message is automatically generated. ATTACHMENT ID: 12631113
          Hide
          Sushanth Sowmyan added a comment -

          Ah, ok, how about if we reintroduce the strings, but mark them deprecated so that new parameters are henceforth introduced in the enum instead, as in the .2.patch?

          Show
          Sushanth Sowmyan added a comment - Ah, ok, how about if we reintroduce the strings, but mark them deprecated so that new parameters are henceforth introduced in the enum instead, as in the .2.patch?
          Hide
          Owen O'Malley added a comment -

          This breaks the API compatibility. You need to leave the strings.

          Show
          Owen O'Malley added a comment - This breaks the API compatibility. You need to leave the strings.
          Hide
          Sushanth Sowmyan added a comment -

          Marking as patch-available so the precommit test queue picks it up when it's time - I figure 5504 will have been committed by the time this comes up.

          Show
          Sushanth Sowmyan added a comment - Marking as patch-available so the precommit test queue picks it up when it's time - I figure 5504 will have been committed by the time this comes up.
          Hide
          Thejas M Nair added a comment -

          +1

          Show
          Thejas M Nair added a comment - +1
          Hide
          Sushanth Sowmyan added a comment -

          Attaching patch. This applies on top of HIVE-5504, and depends on that being committed first.

          Show
          Sushanth Sowmyan added a comment - Attaching patch. This applies on top of HIVE-5504 , and depends on that being committed first.

            People

            • Assignee:
              Sushanth Sowmyan
              Reporter:
              Sushanth Sowmyan
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development