Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Build Infrastructure
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      We should add a .reviewboardrc file to trunk in order to streamline the review process.

      Used in conjunction with RBTools this file makes posting a review request as simple as executing the following command:
      % rbt post

      1. HIVE-6481.1.patch
        0.7 kB
        Carl Steinbach
      2. HIVE-6481.2.patch
        1 kB
        Carl Steinbach

        Activity

        Hide
        Carl Steinbach added a comment -

        I updated the wiki some instructions for using rbt.

        Show
        Carl Steinbach added a comment - I updated the wiki some instructions for using rbt.
        Hide
        Lefty Leverenz added a comment -

        This could be documented in the wiki here:

        (I'm a newbie on the review board, so won't volunteer.)

        Show
        Lefty Leverenz added a comment - This could be documented in the wiki here: How To Contribute: Review Process (I'm a newbie on the review board, so won't volunteer.)
        Hide
        Carl Steinbach added a comment -

        Committed to trunk.

        Show
        Carl Steinbach added a comment - Committed to trunk.
        Hide
        Xuefu Zhang added a comment -

        +1

        I think it's good to document the brief usage somewhere on Hive wiki. For instance, I wasn't aware that I had to make a local commit in order to post the diff for review. Also, after rbt post command, we still need to access the web UI to publish the review.

        Show
        Xuefu Zhang added a comment - +1 I think it's good to document the brief usage somewhere on Hive wiki. For instance, I wasn't aware that I had to make a local commit in order to post the diff for review. Also, after rbt post command, we still need to access the web UI to publish the review.
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12630736/HIVE-6481.2.patch

        ERROR: -1 due to 2 failed/errored test(s), 5180 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketmapjoin6
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1493/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1493/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 2 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12630736

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12630736/HIVE-6481.2.patch ERROR: -1 due to 2 failed/errored test(s), 5180 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketmapjoin6 Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1493/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1493/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12630736
        Hide
        Carl Steinbach added a comment -

        Attaching a new version of the patch that includes the ASF license header in the .reviewboardrc file.

        Show
        Carl Steinbach added a comment - Attaching a new version of the patch that includes the ASF license header in the .reviewboardrc file.
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12630388/HIVE-6481.1.patch

        SUCCESS: +1 5176 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1464/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1464/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12630388

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12630388/HIVE-6481.1.patch SUCCESS: +1 5176 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1464/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1464/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12630388
        Hide
        Carl Steinbach added a comment -
        Show
        Carl Steinbach added a comment - Review request: https://reviews.apache.org/r/18377/

          People

          • Assignee:
            Carl Steinbach
            Reporter:
            Carl Steinbach
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development