Hive
  1. Hive
  2. HIVE-6472

JDBC cancel will not work with current HiveServer2

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.0
    • Component/s: HiveServer2, JDBC
    • Labels:
      None

      Description

      Creating this JIRA to add missing pieces for query cancel capability to JDBC. HIVE-5232 should however fix the core issue. Typical use case is when the client calls Statement#execute in one thread to execute a long running query, and Statement#cancel in another thread to cancel the execution before it is complete.

      1. HIVE-6472.2.patch
        13 kB
        Vaibhav Gumashta
      2. HIVE-6472.1.patch
        10 kB
        Vaibhav Gumashta

        Issue Links

          Activity

          Hide
          Prasad Mujumdar added a comment -

          Patch committed to trunk and 0.13
          Thanks [~vaibhavgumashta]!

          Show
          Prasad Mujumdar added a comment - Patch committed to trunk and 0.13 Thanks [~vaibhavgumashta] !
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12635738/HIVE-6472.2.patch

          SUCCESS: +1 5440 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1902/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1902/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12635738

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12635738/HIVE-6472.2.patch SUCCESS: +1 5440 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1902/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1902/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12635738
          Hide
          Harish Butani added a comment -

          +1 for 0.13

          Show
          Harish Butani added a comment - +1 for 0.13
          Hide
          Vaibhav Gumashta added a comment -

          Thanks for the feedback Prasad Mujumdar. Do you think this can be part of 13? This is more of a bug fix since the cancel jdbc api already exists, but will not work if used in current state.

          cc Harish Butani

          Show
          Vaibhav Gumashta added a comment - Thanks for the feedback Prasad Mujumdar . Do you think this can be part of 13? This is more of a bug fix since the cancel jdbc api already exists, but will not work if used in current state. cc Harish Butani
          Hide
          Prasad Mujumdar added a comment -

          +1 pending test run.

          Show
          Prasad Mujumdar added a comment - +1 pending test run.
          Hide
          Vaibhav Gumashta added a comment -

          Prasad Mujumdar Addressed the review comments. Added a fair locking for client transport which otherwise might have caused starvation. Thanks!

          Show
          Vaibhav Gumashta added a comment - Prasad Mujumdar Addressed the review comments. Added a fair locking for client transport which otherwise might have caused starvation. Thanks!
          Hide
          Vaibhav Gumashta added a comment -

          Thanks for the feedback Prasad Mujumdar. I'll upload a new patch with the test changes.

          Show
          Vaibhav Gumashta added a comment - Thanks for the feedback Prasad Mujumdar . I'll upload a new patch with the test changes.
          Hide
          Prasad Mujumdar added a comment -

          [~vaibhavgumashta] I left some minor comments on the RB

          Show
          Prasad Mujumdar added a comment - [~vaibhavgumashta] I left some minor comments on the RB

            People

            • Assignee:
              Vaibhav Gumashta
              Reporter:
              Vaibhav Gumashta
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development