Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None
    • Release Note:
      If a user/role has admin option on a role, then user should be able to grant /revoke other users to/from the role.

      Description

      Follow up jira for HIVE-5952.
      If a user/role has admin option on a role, then user should be able to grant /revoke other users to/from the role.

      1. HIVE-6433.patch
        7 kB
        Ashutosh Chauhan
      2. HIVE-6433.1.patch
        11 kB
        Ashutosh Chauhan
      3. HIVE-6433.2.patch
        11 kB
        Ashutosh Chauhan

        Issue Links

          Activity

          Hide
          Ashutosh Chauhan added a comment -

          Patch which implements this.

          Show
          Ashutosh Chauhan added a comment - Patch which implements this.
          Show
          Ashutosh Chauhan added a comment - https://reviews.apache.org/r/18250/
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12629687/HIVE-6433.patch

          ERROR: -1 due to 1 failed/errored test(s), 5106 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_truncate_column_buckets
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1407/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1407/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12629687

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12629687/HIVE-6433.patch ERROR: -1 due to 1 failed/errored test(s), 5106 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_truncate_column_buckets Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1407/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1407/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12629687
          Hide
          Ashutosh Chauhan added a comment -

          Incorporated Thejas feedback.

          Show
          Ashutosh Chauhan added a comment - Incorporated Thejas feedback.
          Hide
          Ashutosh Chauhan added a comment -

          Incorporating more feedback.

          Show
          Ashutosh Chauhan added a comment - Incorporating more feedback.
          Hide
          Thejas M Nair added a comment -

          +1

          Show
          Thejas M Nair added a comment - +1
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12629953/HIVE-6433.2.patch

          ERROR: -1 due to 3 failed/errored test(s), 5166 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_insert_into5
          org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_insert_into6
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1427/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1427/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 3 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12629953

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12629953/HIVE-6433.2.patch ERROR: -1 due to 3 failed/errored test(s), 5166 tests executed Failed tests: org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_insert_into5 org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_insert_into6 org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20 Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1427/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1427/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 3 tests failed This message is automatically generated. ATTACHMENT ID: 12629953
          Hide
          Ashutosh Chauhan added a comment -

          testNegativeCliDriver_insert_into5 && testNegativeCliDriver_insert_into6 are not related to this patch. They are failing because these .q files didn't get updated in HIVE-5958 commit. Subsequent build like https://issues.apache.org/jira/browse/HIVE-6375?focusedCommentId=13907770&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13907770 also failed because of it.

          Show
          Ashutosh Chauhan added a comment - testNegativeCliDriver_insert_into5 && testNegativeCliDriver_insert_into6 are not related to this patch. They are failing because these .q files didn't get updated in HIVE-5958 commit. Subsequent build like https://issues.apache.org/jira/browse/HIVE-6375?focusedCommentId=13907770&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-13907770 also failed because of it.
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Filed HIVE-6479 for 2 trunk failures.

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Filed HIVE-6479 for 2 trunk failures.
          Hide
          Lefty Leverenz added a comment -

          Does this need any documentation, besides general docs for the parent HIVE-5837?

          Show
          Lefty Leverenz added a comment - Does this need any documentation, besides general docs for the parent HIVE-5837 ?
          Hide
          Thejas M Nair added a comment -

          I will comb through the issues and create a consolidated doc for parent HIVE-5837. This change is specific to HIVE-5837.

          Show
          Thejas M Nair added a comment - I will comb through the issues and create a consolidated doc for parent HIVE-5837 . This change is specific to HIVE-5837 .

            People

            • Assignee:
              Ashutosh Chauhan
              Reporter:
              Thejas M Nair
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development