Hive
  1. Hive
  2. HIVE-5837 SQL standard based secure authorization for hive
  3. HIVE-6254

sql standard auth - use admin option specified in grant/revoke role statement

    Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Authorization
    • Labels:
      None

      Description

      DDLSemanticAnalyzer ignores the admin option specified in the query, and is always setting it to true.

      1. HIVE-6254.1.patch
        10 kB
        Ashutosh Chauhan
      2. HIVE-6254.patch
        4 kB
        Ashutosh Chauhan

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk.

        Show
        Ashutosh Chauhan added a comment - Committed to trunk.
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12628263/HIVE-6254.1.patch

        ERROR: -1 due to 1 failed/errored test(s), 5086 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_revoke_table_priv
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1287/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1287/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 1 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12628263

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12628263/HIVE-6254.1.patch ERROR: -1 due to 1 failed/errored test(s), 5086 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_revoke_table_priv Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1287/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1287/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12628263
        Hide
        Ashutosh Chauhan added a comment -

        Fixed .q.out files for failing tests. No code changes.
        Test authorization_revoke_table_priv.q has failed on other builds. And it seems it needs --SORT_BEFORE_DIFF directive at top.

        Show
        Ashutosh Chauhan added a comment - Fixed .q.out files for failing tests. No code changes. Test authorization_revoke_table_priv.q has failed on other builds. And it seems it needs --SORT_BEFORE_DIFF directive at top.
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12628046/HIVE-6254.patch

        ERROR: -1 due to 13 failed/errored test(s), 5083 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_5
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_revoke_table_priv
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_view
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table
        org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_fail_7
        org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testGrantRoleGroup
        org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testGrantRoleRole
        org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testGrantRoleUser
        org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testRevokeRoleGroup
        org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testRevokeRoleRole
        org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testRevokeRoleUser
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1272/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1272/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 13 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12628046

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12628046/HIVE-6254.patch ERROR: -1 due to 13 failed/errored test(s), 5083 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_revoke_table_priv org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_view org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_auto_sortmerge_join_16 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_root_dir_external_table org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_authorization_fail_7 org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testGrantRoleGroup org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testGrantRoleRole org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testGrantRoleUser org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testRevokeRoleGroup org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testRevokeRoleRole org.apache.hadoop.hive.ql.parse.authorization.TestHiveAuthorizationTaskFactory.testRevokeRoleUser Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1272/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1272/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 13 tests failed This message is automatically generated. ATTACHMENT ID: 12628046
        Hide
        Thejas M Nair added a comment -

        +1

        Show
        Thejas M Nair added a comment - +1

          People

          • Assignee:
            Ashutosh Chauhan
            Reporter:
            Thejas M Nair
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 12h
              12h
              Remaining:
              Remaining Estimate - 12h
              12h
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development