Hive
  1. Hive
  2. HIVE-6248

HCatReader/Writer should hide Hadoop and Hive classes

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: HCatalog
    • Labels:
      None

      Description

      HCat's HCatReader and HCatWriter interfaces expose Hadoop classes Configuration and InputSplit, as well as HCatInputSplit. This exposes users to changes over Hadoop or HCatalog versions. It also makes it harder to some day move this interface to use WebHCat, which we'd like to do. The eventual goal is for this interface to not require any other jars (no Hadoop, Hive, etc.) As a first step to this the references to Hadoop and HCat classes in the interface should be hidden.

        Activity

        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12624200/HIVE-6248.patch

        SUCCESS: +1 4943 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/978/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/978/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12624200

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12624200/HIVE-6248.patch SUCCESS: +1 4943 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/978/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/978/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12624200
        Hide
        Ashutosh Chauhan added a comment -

        +1
        I think we should also create a wiki doc for it to document usage of this api. In case an overall page for this already exists somewhere, we need to update it with changes.

        Show
        Ashutosh Chauhan added a comment - +1 I think we should also create a wiki doc for it to document usage of this api. In case an overall page for this already exists somewhere, we need to update it with changes.
        Hide
        Alan Gates added a comment -

        Patch committed.

        Thanks Ashutosh for the review. I agree we need to update the docs. Filed HIVE-6304 to track those changes.

        Show
        Alan Gates added a comment - Patch committed. Thanks Ashutosh for the review. I agree we need to update the docs. Filed HIVE-6304 to track those changes.

          People

          • Assignee:
            Alan Gates
            Reporter:
            Alan Gates
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development