Hive
  1. Hive
  2. HIVE-6241

Remove direct reference of Hadoop23Shims inQTestUtil

    Details

    • Type: Wish Wish
    • Status: Closed
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.14.0
    • Component/s: Tests
    • Labels:
      None

      Description

      if (clusterType == MiniClusterType.tez) {
        if (!(shims instanceof Hadoop23Shims)) {
          throw new Exception("Cannot run tez on hadoop-1, Version: "+this.hadoopVer);
        }
        mr = ((Hadoop23Shims)shims).getMiniTezCluster(conf, 4, getHdfsUriString(fs.getUri().toString()), 1);
      } else {
        mr = shims.getMiniMrCluster(conf, 4, getHdfsUriString(fs.getUri().toString()), 1);
      }
      

      Not important but a little annoying when the shims is not in classpath. And I think hadoop24shims or later might support tez.

      1. HIVE-6241.1.patch.txt
        5 kB
        Navis
      2. HIVE-6241.2.patch.txt
        4 kB
        Navis

        Activity

        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12624047/HIVE-6241.1.patch.txt

        SUCCESS: +1 4943 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/970/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/970/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12624047

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12624047/HIVE-6241.1.patch.txt SUCCESS: +1 4943 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/970/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/970/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12624047
        Hide
        Navis added a comment -

        Rebased to trunk

        Show
        Navis added a comment - Rebased to trunk
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Navis!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Navis!
        Hide
        Thejas M Nair added a comment -

        This has been fixed in 0.14 release. Please open new jira if you see any issues.

        Show
        Thejas M Nair added a comment - This has been fixed in 0.14 release. Please open new jira if you see any issues.

          People

          • Assignee:
            Navis
            Reporter:
            Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development