Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There is a bug in the Converter - we are converting all objects to Primitive Java objects instead of Writable.
      This has caused some queries to fail:

      SELECT IF(false, 1, cast(2 as smallint)) + 3 FROM any_table;
      
      1. HIVE-624.1.patch
        77 kB
        Zheng Shao
      2. HIVE-624.2.patch
        77 kB
        Zheng Shao

        Activity

        Hide
        Carl Steinbach added a comment -

        Committed as HIVE-616.

        Show
        Carl Steinbach added a comment - Committed as HIVE-616 .
        Hide
        Namit Jain added a comment -

        Committed. Thanks Zheng.

        Show
        Namit Jain added a comment - Committed. Thanks Zheng.
        Hide
        Zheng Shao added a comment -

        Fixed a compilation problem that didn't surface till "ant clean".

        Show
        Zheng Shao added a comment - Fixed a compilation problem that didn't surface till "ant clean".
        Hide
        Zheng Shao added a comment -

        This patch fixes the problem by rewriting all the converters.

        The converters are expanded to a class hierarchy so it can reuse the returned conversion result (a Writable object) more easily.

        I also added the Settable*ObjectInspector which provides a delegated way of setting the value of an object and creating new objects.

        It also adds one new test case for the converters, and one more client positive test case.

        Show
        Zheng Shao added a comment - This patch fixes the problem by rewriting all the converters. The converters are expanded to a class hierarchy so it can reuse the returned conversion result (a Writable object) more easily. I also added the Settable*ObjectInspector which provides a delegated way of setting the value of an object and creating new objects. It also adds one new test case for the converters, and one more client positive test case.

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development