Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.4.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      There is a bug in the Converter - we are converting all objects to Primitive Java objects instead of Writable.
      This has caused some queries to fail:

      SELECT IF(false, 1, cast(2 as smallint)) + 3 FROM any_table;
      
      1. HIVE-624.1.patch
        77 kB
        Zheng Shao
      2. HIVE-624.2.patch
        77 kB
        Zheng Shao

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        51m 43s 1 Zheng Shao 10/Jul/09 08:58
        Patch Available Patch Available Resolved Resolved
        17h 52m 1 Namit Jain 11/Jul/09 02:51
        Resolved Resolved Closed Closed
        888d 22h 16m 1 Carl Steinbach 17/Dec/11 00:07
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Carl Steinbach made changes -
        Fix Version/s 0.4.0 [ 12313714 ]
        Hide
        Carl Steinbach added a comment -

        Committed as HIVE-616.

        Show
        Carl Steinbach added a comment - Committed as HIVE-616 .
        Namit Jain made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Namit Jain added a comment -

        Committed. Thanks Zheng.

        Show
        Namit Jain added a comment - Committed. Thanks Zheng.
        Zheng Shao made changes -
        Attachment HIVE-624.2.patch [ 12413167 ]
        Hide
        Zheng Shao added a comment -

        Fixed a compilation problem that didn't surface till "ant clean".

        Show
        Zheng Shao added a comment - Fixed a compilation problem that didn't surface till "ant clean".
        Zheng Shao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Zheng Shao made changes -
        Field Original Value New Value
        Attachment HIVE-624.1.patch [ 12413087 ]
        Hide
        Zheng Shao added a comment -

        This patch fixes the problem by rewriting all the converters.

        The converters are expanded to a class hierarchy so it can reuse the returned conversion result (a Writable object) more easily.

        I also added the Settable*ObjectInspector which provides a delegated way of setting the value of an object and creating new objects.

        It also adds one new test case for the converters, and one more client positive test case.

        Show
        Zheng Shao added a comment - This patch fixes the problem by rewriting all the converters. The converters are expanded to a class hierarchy so it can reuse the returned conversion result (a Writable object) more easily. I also added the Settable*ObjectInspector which provides a delegated way of setting the value of an object and creating new objects. It also adds one new test case for the converters, and one more client positive test case.
        Zheng Shao created issue -

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development