Hive
  1. Hive
  2. HIVE-6184

Bug in SessionManager.stop() in HiveServer2

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: HiveServer2
    • Labels:
      None

      Description

      The conf setting hive.server2.async.exec.shutdown.timeout is set to a long value (10L) in HiveConf.java, but it is read using getIntVar in SessionManager.stop.

      Instead it should be read as -

            long timeout = hiveConf.getLongVar(ConfVars.HIVE_SERVER2_ASYNC_EXEC_SHUTDOWN_TIMEOUT);
      

      Current code will either cause an assertion error if assertions are enabled, or it would return the timeout as -1 if the property is not set in hive-site.xml

      Workaround is to explicitly set the property in hive-site.xml

        Activity

        Jaideep Dhok created issue -
        Hide
        Navis added a comment -

        integer type seemed enough for seconds.

        Show
        Navis added a comment - integer type seemed enough for seconds.
        Navis made changes -
        Field Original Value New Value
        Attachment HIVE-6184.1.patch.txt [ 12622760 ]
        Navis made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12622760/HIVE-6184.1.patch.txt

        SUCCESS: +1 4924 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/900/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/900/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12622760

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12622760/HIVE-6184.1.patch.txt SUCCESS: +1 4924 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/900/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/900/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12622760
        Hide
        Thejas M Nair added a comment -

        +1

        Show
        Thejas M Nair added a comment - +1
        Thejas M Nair made changes -
        Assignee Navis [ navis ]
        Hide
        Thejas M Nair added a comment -

        Patch committed to trunk. Thanks for the contribution Navis!

        Show
        Thejas M Nair added a comment - Patch committed to trunk. Thanks for the contribution Navis!
        Thejas M Nair made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.13.0 [ 12324986 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Navis
            Reporter:
            Jaideep Dhok
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development