Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Query Processor
    • Labels:
      None

      Description

      Next one in patch series to fix Hive to use paths consistently.

      1. HIVE-6121.patch
        84 kB
        Ashutosh Chauhan
      2. HIVE-6121.2.patch
        172 kB
        Ashutosh Chauhan
      3. HIVE-6121.3.patch
        158 kB
        Ashutosh Chauhan

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Xuefu for review!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Xuefu for review!
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12620949/HIVE-6121.3.patch

        SUCCESS: +1 4818 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/776/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/776/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12620949

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12620949/HIVE-6121.3.patch SUCCESS: +1 4818 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/776/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/776/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12620949
        Hide
        Xuefu Zhang added a comment -

        +1

        Show
        Xuefu Zhang added a comment - +1
        Hide
        Ashutosh Chauhan added a comment -
        • Rebased after HIVE-6116 went in trunk.
        • Whitespace changes for indentation.
        • Updated .q.out for failed tests.
        • No other code changes.
        Show
        Ashutosh Chauhan added a comment - Rebased after HIVE-6116 went in trunk. Whitespace changes for indentation. Updated .q.out for failed tests. No other code changes.
        Hide
        Xuefu Zhang added a comment -

        Sorry for the delayed +1 for HIVE-6116, as I was travelling today.

        The patch for this JIRA looks good. This is great work that's important to keep Hive code clean. I do have a few minor comments/questions on the review board.

        Show
        Xuefu Zhang added a comment - Sorry for the delayed +1 for HIVE-6116 , as I was travelling today. The patch for this JIRA looks good. This is great work that's important to keep Hive code clean. I do have a few minor comments/questions on the review board.
        Hide
        Ashutosh Chauhan added a comment -

        Xuefu Zhang This one is ready for review as well. Above failure is minor .q.out file update. RB request : https://reviews.apache.org/r/16526/ Currently it includes HIVE-6116 patch since thats one not committed on trunk. (waiting for +1 on latest patch (which only has whitespace changes)) But that shouldn't be a problem for this review.

        Show
        Ashutosh Chauhan added a comment - Xuefu Zhang This one is ready for review as well. Above failure is minor .q.out file update. RB request : https://reviews.apache.org/r/16526/ Currently it includes HIVE-6116 patch since thats one not committed on trunk. (waiting for +1 on latest patch (which only has whitespace changes)) But that shouldn't be a problem for this review.
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12620879/HIVE-6121.2.patch

        ERROR: -1 due to 1 failed/errored test(s), 4818 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union22
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/773/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/773/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 1 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12620879

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12620879/HIVE-6121.2.patch ERROR: -1 due to 1 failed/errored test(s), 4818 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union22 Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/773/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/773/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12620879
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12620776/HIVE-6121.patch

        ERROR: -1 due to 81 failed/errored test(s), 4818 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_11
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_4
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_7
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_8
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_binary_output_format
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_4
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_7
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_8
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketizedhiveinputformat_auto
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin11
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin12
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin13
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin4
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin5
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin8
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin_negative
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin_negative2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_4
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_6
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_7
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_8
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_escape2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_map_ppr
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_map_ppr_multi_distinct
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_ppr
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_ppr_multi_distinct
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_6
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_skew_1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input_part1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input_part2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join17
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join26
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join32
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join32_lessSize
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join33
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join34
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join35
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join9
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_map_ppr
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_load_dyn_part8
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_merge3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_pcr
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rand_partitionpruner2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rcfile_createas1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rcfile_merge3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample1
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample2
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample4
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample5
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample6
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample7
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_smb_mapjoin9
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_smb_mapjoin_11
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_smb_mapjoin_12
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sort_merge_join_desc_5
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sort_merge_join_desc_6
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats0
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats11
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats3
        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union22
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket4
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket5
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketmapjoin7
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_disable_merge_for_bucketing
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_list_bucket_dml_10
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_reduce_deduplicate
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/765/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/765/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 81 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12620776

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12620776/HIVE-6121.patch ERROR: -1 due to 81 failed/errored test(s), 4818 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_merge_2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_11 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_7 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_auto_sortmerge_join_8 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_binary_output_format org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucket3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_7 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketcontext_8 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketizedhiveinputformat_auto org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin11 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin12 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin13 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin8 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin_negative org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketmapjoin_negative2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_6 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_7 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_bucketsortoptimize_insert_8 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_escape2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_map_ppr org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_map_ppr_multi_distinct org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_ppr org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_ppr_multi_distinct org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_6 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_groupby_sort_skew_1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input_part1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input_part2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join17 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join26 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join32 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join32_lessSize org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join33 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join34 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join35 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join9 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_join_map_ppr org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_load_dyn_part8 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_merge3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_pcr org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rand_partitionpruner2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rcfile_createas1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rcfile_merge3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample6 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sample7 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_smb_mapjoin9 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_smb_mapjoin_11 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_smb_mapjoin_12 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sort_merge_join_desc_5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_sort_merge_join_desc_6 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats0 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats11 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_stats3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_union22 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket4 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket5 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucketmapjoin7 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_disable_merge_for_bucketing org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_list_bucket_dml_10 org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_reduce_deduplicate Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/765/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/765/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 81 tests failed This message is automatically generated. ATTACHMENT ID: 12620776

          People

          • Assignee:
            Ashutosh Chauhan
            Reporter:
            Ashutosh Chauhan
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development