Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-6091

Empty pipeout files are created for connection create/close

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.2.0, 1.2.1
    • Fix Version/s: 2.0.0
    • Component/s: HiveServer2
    • Labels:
      None

      Description

      Pipeout files are created when a connection is established and removed only when data was produced. Instead we should create them only when data has to be fetched or remove them whether data is fetched or not.

      1. HIVE-6091.1.patch
        0.6 kB
        Bing Li
      2. HIVE-6091.2.patch
        0.6 kB
        Bing Li
      3. HIVE-6091.patch
        1 kB
        Thiruvel Thirumoolan

        Issue Links

          Activity

          Hide
          thiruvel Thiruvel Thirumoolan added a comment -

          Starting off with a simple approach, to delete the file on connection close.

          Show
          thiruvel Thiruvel Thirumoolan added a comment - Starting off with a simple approach, to delete the file on connection close.
          Hide
          libing Bing Li added a comment -

          Seems that the patch has been merged into Hive from 0.13.0 via https://issues.apache.org/jira/browse/HIVE-4395

          Show
          libing Bing Li added a comment - Seems that the patch has been merged into Hive from 0.13.0 via https://issues.apache.org/jira/browse/HIVE-4395
          Hide
          libing Bing Li added a comment -

          With this patch, the pipeout file could be deleted after the session closed.
          I have tested it based on Hive 1.2.1

          Show
          libing Bing Li added a comment - With this patch, the pipeout file could be deleted after the session closed. I have tested it based on Hive 1.2.1
          Hide
          libing Bing Li added a comment -

          The patch is created based on the latest code

          Show
          libing Bing Li added a comment - The patch is created based on the latest code
          Hide
          hiveqa Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12745185/HIVE-6091.1.patch

          ERROR: -1 due to 1 failed/errored test(s), 9190 tests executed
          Failed tests:

          org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbort
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4605/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4605/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4605/

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12745185 - PreCommit-HIVE-TRUNK-Build

          Show
          hiveqa Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12745185/HIVE-6091.1.patch ERROR: -1 due to 1 failed/errored test(s), 9190 tests executed Failed tests: org.apache.hive.hcatalog.streaming.TestStreaming.testTransactionBatchAbort Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4605/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/4605/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-4605/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12745185 - PreCommit-HIVE-TRUNK-Build
          Hide
          libing Bing Li added a comment -

          Re-generated the patch based on the latest code in master branch

          Show
          libing Bing Li added a comment - Re-generated the patch based on the latest code in master branch
          Hide
          libing Bing Li added a comment -

          Re-created the patch file based on the latest code in master branch

          Show
          libing Bing Li added a comment - Re-created the patch file based on the latest code in master branch
          Hide
          hiveqa Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12755104/HIVE-6091.2.patch

          ERROR: -1 due to 1 failed/errored test(s), 9424 tests executed
          Failed tests:

          org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
          

          Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5236/testReport
          Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5236/console
          Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5236/

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12755104 - PreCommit-HIVE-TRUNK-Build

          Show
          hiveqa Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12755104/HIVE-6091.2.patch ERROR: -1 due to 1 failed/errored test(s), 9424 tests executed Failed tests: org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5236/testReport Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5236/console Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5236/ Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12755104 - PreCommit-HIVE-TRUNK-Build
          Hide
          ashutoshc Ashutosh Chauhan added a comment -

          +1

          Show
          ashutoshc Ashutosh Chauhan added a comment - +1
          Hide
          ashutoshc Ashutosh Chauhan added a comment -

          Pushed to master. Thanks, Thiruvel Thirumoolan & Bing Li

          Show
          ashutoshc Ashutosh Chauhan added a comment - Pushed to master. Thanks, Thiruvel Thirumoolan & Bing Li

            People

            • Assignee:
              thiruvel Thiruvel Thirumoolan
              Reporter:
              thiruvel Thiruvel Thirumoolan
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development