Hive
  1. Hive
  2. HIVE-6027

non-vectorized log10 has rounding issue

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      In HIVE-6010, I found that vectorized and non-vectorized log10 may produce different results in the last digit of the mantissa (e.g. 7 vs 8). It turns out that vectorized one uses Math.log10, but non-vectorized uses log/log(10). Both should use Math.log10.

      1. HIVE-6027.patch
        0.9 kB
        Sergey Shelukhin

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Sergey!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Sergey!
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12618494/HIVE-6027.patch

        SUCCESS: +1 4779 tests passed

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/625/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/625/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        ATTACHMENT ID: 12618494

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12618494/HIVE-6027.patch SUCCESS: +1 4779 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/625/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/625/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12618494
        Hide
        Sergey Shelukhin added a comment -

        trivial patch

        Show
        Sergey Shelukhin added a comment - trivial patch

          People

          • Assignee:
            Sergey Shelukhin
            Reporter:
            Sergey Shelukhin
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development