Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Authorization
    • Labels:
      None
    • Release Note:
      In sql standard authorization mode all users by default belong to PUBLIC role

      Description

      All users should belong to the public role. Users don't have to be (/can't be) added to this role .
      Metastore api/checks should return this role.
      set role should allow setting to this role.
      GRANT/REVOKE on this should be disabled.

      1. HIVE-5960.1.patch
        27 kB
        Ashutosh Chauhan
      2. HIVE-5960.patch
        16 kB
        Ashutosh Chauhan

        Activity

        Thejas M Nair created issue -
        Thejas M Nair made changes -
        Field Original Value New Value
        Component/s Authorization [ 12317300 ]
        Hide
        Ashutosh Chauhan added a comment -

        Added PUBLIC role.

        Show
        Ashutosh Chauhan added a comment - Added PUBLIC role.
        Ashutosh Chauhan made changes -
        Attachment HIVE-5960.patch [ 12626929 ]
        Ashutosh Chauhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Assignee Ashutosh Chauhan [ ashutoshc ]
        Hide
        Ashutosh Chauhan added a comment -
        Show
        Ashutosh Chauhan added a comment - RB request : https://reviews.apache.org/r/17718/
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12626929/HIVE-5960.patch

        ERROR: -1 due to 2 failed/errored test(s), 5014 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_role_grant1
        org.apache.hadoop.hive.jdbc.TestJdbcDriver.testShowRoleGrant
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1187/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1187/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 2 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12626929

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12626929/HIVE-5960.patch ERROR: -1 due to 2 failed/errored test(s), 5014 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_authorization_role_grant1 org.apache.hadoop.hive.jdbc.TestJdbcDriver.testShowRoleGrant Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1187/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1187/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12626929
        Ashutosh Chauhan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Hide
        Ashutosh Chauhan added a comment -

        Incorporated Brock & Thejas feedback. Fixed test fails.

        Show
        Ashutosh Chauhan added a comment - Incorporated Brock & Thejas feedback. Fixed test fails.
        Ashutosh Chauhan made changes -
        Attachment HIVE-5960.1.patch [ 12627032 ]
        Ashutosh Chauhan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Thejas M Nair added a comment -

        +1

        Show
        Thejas M Nair added a comment - +1
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12627032/HIVE-5960.1.patch

        ERROR: -1 due to 2 failed/errored test(s), 5014 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_dyn_part
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_parallel_orderby
        

        Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1199/testReport
        Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1199/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests exited with: TestsFailedException: 2 tests failed
        

        This message is automatically generated.

        ATTACHMENT ID: 12627032

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12627032/HIVE-5960.1.patch ERROR: -1 due to 2 failed/errored test(s), 5014 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_dyn_part org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_parallel_orderby Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1199/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1199/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 2 tests failed This message is automatically generated. ATTACHMENT ID: 12627032
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk.

        Show
        Ashutosh Chauhan added a comment - Committed to trunk.
        Ashutosh Chauhan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.13.0 [ 12324986 ]
        Resolution Fixed [ 1 ]
        Hide
        Lefty Leverenz added a comment -

        Should this be documented now, or wait for HIVE-6355 / HIVE-5837?

        Show
        Lefty Leverenz added a comment - Should this be documented now, or wait for HIVE-6355 / HIVE-5837 ? Language Manual: Authorization
        Hide
        Ashutosh Chauhan added a comment - - edited

        Lefty Leverenz I added release notes. Same text can be added in cwiki also.

        Show
        Ashutosh Chauhan added a comment - - edited Lefty Leverenz I added release notes. Same text can be added in cwiki also.
        Ashutosh Chauhan made changes -
        Release Note In sql standard authorization mode all users by default belong to PUBLIC role
        Thejas M Nair logged work - 10/Feb/14 06:46
        • Time Spent:
          24h
           
          <No comment>
        Thejas M Nair made changes -
        Remaining Estimate 24h [ 86400 ] 0h [ 0 ]
        Time Spent 24h [ 86400 ]
        Worklog Id 15935 [ 15935 ]

          People

          • Assignee:
            Ashutosh Chauhan
            Reporter:
            Thejas M Nair
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 24h
              24h
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 24h
              24h

                Development