Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: Authorization
    • Labels:
      None

      Description

      Only superuser should be allowed to perform show all roles, create role, drop role .

      1. HIVE-5944.3.patch
        27 kB
        Ashutosh Chauhan
      2. HIVE-5944.2.patch
        29 kB
        Ashutosh Chauhan
      3. HIVE-5944.1.patch
        22 kB
        Ashutosh Chauhan
      4. HIVE-5944.patch
        7 kB
        Ashutosh Chauhan

        Issue Links

          Activity

          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.13.0 [ 12324986 ]
          Resolution Fixed [ 1 ]
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk.

          Show
          Ashutosh Chauhan added a comment - Committed to trunk.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12628296/HIVE-5944.3.patch

          ERROR: -1 due to 1 failed/errored test(s), 5089 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_merge
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1284/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1284/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12628296

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12628296/HIVE-5944.3.patch ERROR: -1 due to 1 failed/errored test(s), 5089 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_merge Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1284/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/1284/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12628296
          Hide
          Thejas M Nair added a comment -

          +1

          Show
          Thejas M Nair added a comment - +1
          Ashutosh Chauhan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Ashutosh Chauhan made changes -
          Attachment HIVE-5944.3.patch [ 12628296 ]
          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Ashutosh Chauhan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Ashutosh Chauhan made changes -
          Attachment HIVE-5944.2.patch [ 12628280 ]
          Hide
          Ashutosh Chauhan added a comment -

          Incorporated Mohammad & Thejas feedback.

          Show
          Ashutosh Chauhan added a comment - Incorporated Mohammad & Thejas feedback.
          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Open [ 1 ]
          Ashutosh Chauhan made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Ashutosh Chauhan added a comment -
          Show
          Ashutosh Chauhan added a comment - RB request : https://reviews.apache.org/r/17939/
          Ashutosh Chauhan made changes -
          Attachment HIVE-5944.1.patch [ 12628156 ]
          Ashutosh Chauhan made changes -
          Link This issue is blocked by HIVE-5959 [ HIVE-5959 ]
          Ashutosh Chauhan made changes -
          Remote Link This issue links to "RB request (Web Link)" [ 14006 ]
          Ashutosh Chauhan made changes -
          Assignee Ashutosh Chauhan [ ashutoshc ]
          Ashutosh Chauhan made changes -
          Attachment HIVE-5944.patch [ 12625954 ]
          Hide
          Ashutosh Chauhan added a comment -

          Patch which adds this functionality. This correctly results in failure of : authorization_1_sql_std.q & authorization_role_grant1.q since those tests currently create / drop / show roles without admin privs. To get those to pass, HIVE-5959 is required.

          Show
          Ashutosh Chauhan added a comment - Patch which adds this functionality. This correctly results in failure of : authorization_1_sql_std.q & authorization_role_grant1.q since those tests currently create / drop / show roles without admin privs. To get those to pass, HIVE-5959 is required.
          Thejas M Nair made changes -
          Field Original Value New Value
          Component/s Authorization [ 12317300 ]
          Thejas M Nair created issue -

            People

            • Assignee:
              Ashutosh Chauhan
              Reporter:
              Thejas M Nair
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development