Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
      We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

      1. HIVE-593.2.patch
        58 kB
        Zheng Shao
      2. HIVE-593.1.patch
        58 kB
        Zheng Shao

        Activity

        Zheng Shao created issue -
        Zheng Shao made changes -
        Field Original Value New Value
        Assignee Zheng Shao [ zshao ]
        Hide
        Zheng Shao added a comment -

        This patch replaces exprNodeIndexDesc and exprNodeIndexEvaluator with GenericUDF "index".

        The removal of exprNodeFieldDesc will require some additional work (mainly that we need to serialize the field name together with the GenericUDF, but currently, GenericUDF is not serializable). I think we should move that to a separate JIRA, in which we will make GenericUDF optional implement Serializable, so that we can store compile-time information for use at the runtime.

        Show
        Zheng Shao added a comment - This patch replaces exprNodeIndexDesc and exprNodeIndexEvaluator with GenericUDF "index". The removal of exprNodeFieldDesc will require some additional work (mainly that we need to serialize the field name together with the GenericUDF, but currently, GenericUDF is not serializable). I think we should move that to a separate JIRA, in which we will make GenericUDF optional implement Serializable, so that we can store compile-time information for use at the runtime.
        Zheng Shao made changes -
        Attachment HIVE-593.1.patch [ 12412316 ]
        Zheng Shao made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        He Yongqiang added a comment -

        there is one error in line 97 of GenericUDFIndex, isWritable is not defined.

        Show
        He Yongqiang added a comment - there is one error in line 97 of GenericUDFIndex, isWritable is not defined.
        Hide
        Zheng Shao added a comment -

        Updated with trunk and fixed the problem.

        Show
        Zheng Shao added a comment - Updated with trunk and fixed the problem.
        Zheng Shao made changes -
        Attachment HIVE-593.2.patch [ 12412410 ]
        Hide
        Prasad Chakka added a comment -

        looks good. submit once tests are passed.

        Show
        Prasad Chakka added a comment - looks good. submit once tests are passed.
        Hide
        Prasad Chakka added a comment -

        Thanks Zheng.

        Show
        Prasad Chakka added a comment - Thanks Zheng.
        Prasad Chakka made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.4.0 [ 12313714 ]
        Resolution Fixed [ 1 ]
        Carl Steinbach made changes -
        Affects Version/s 0.3.1 [ 12313845 ]
        Carl Steinbach made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        1d 19h 42m 1 Zheng Shao 01/Jul/09 22:07
        Patch Available Patch Available Resolved Resolved
        1d 2h 40m 1 Prasad Chakka 03/Jul/09 00:47
        Resolved Resolved Closed Closed
        897d 19m 1 Carl Steinbach 17/Dec/11 00:07

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development