Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.3.0
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None

      Description

      We should deprecate ExprNodeIndexEvaluator and ExprNodeFieldEvaluator and use GenericUDF.
      We should also clean up ExprNodeFuncEvaluator - there are a lot of hacks to be removed (hacks to get map, list and struct to work)

      1. HIVE-593.1.patch
        58 kB
        Zheng Shao
      2. HIVE-593.2.patch
        58 kB
        Zheng Shao

        Activity

        Hide
        Zheng Shao added a comment -

        This patch replaces exprNodeIndexDesc and exprNodeIndexEvaluator with GenericUDF "index".

        The removal of exprNodeFieldDesc will require some additional work (mainly that we need to serialize the field name together with the GenericUDF, but currently, GenericUDF is not serializable). I think we should move that to a separate JIRA, in which we will make GenericUDF optional implement Serializable, so that we can store compile-time information for use at the runtime.

        Show
        Zheng Shao added a comment - This patch replaces exprNodeIndexDesc and exprNodeIndexEvaluator with GenericUDF "index". The removal of exprNodeFieldDesc will require some additional work (mainly that we need to serialize the field name together with the GenericUDF, but currently, GenericUDF is not serializable). I think we should move that to a separate JIRA, in which we will make GenericUDF optional implement Serializable, so that we can store compile-time information for use at the runtime.
        Hide
        He Yongqiang added a comment -

        there is one error in line 97 of GenericUDFIndex, isWritable is not defined.

        Show
        He Yongqiang added a comment - there is one error in line 97 of GenericUDFIndex, isWritable is not defined.
        Hide
        Zheng Shao added a comment -

        Updated with trunk and fixed the problem.

        Show
        Zheng Shao added a comment - Updated with trunk and fixed the problem.
        Hide
        Prasad Chakka added a comment -

        looks good. submit once tests are passed.

        Show
        Prasad Chakka added a comment - looks good. submit once tests are passed.
        Hide
        Prasad Chakka added a comment -

        Thanks Zheng.

        Show
        Prasad Chakka added a comment - Thanks Zheng.

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development