Hive
  1. Hive
  2. HIVE-5812

HiveServer2 SSL connection transport binds to loopback address by default

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.0
    • Component/s: HiveServer2
    • Labels:
      None

      Description

      The secure socket transport implemented as part of HIVE-5351, binds to loopback address by default. If the bind interface gets used only if its explicitly defined in the hive-site or via environment.
      This behavior should be same as non-SSL transport.

      1. HIVE-5812.2.patch
        2 kB
        Prasad Mujumdar
      2. HIVE-5812.1.patch
        2 kB
        Prasad Mujumdar

        Issue Links

          Activity

          Hide
          Prasad Mujumdar added a comment -

          Patch attached

          Show
          Prasad Mujumdar added a comment - Patch attached
          Hide
          Brock Noland added a comment -

          This looks like a good change, not sure why precommit tests didn't kick off. I tried a second time.

          Say, if the delegation token is not null, do we want to call HiveAuthFactory.getSocketTransport(host, port, loginTimeout) to get the transport?

          Show
          Brock Noland added a comment - This looks like a good change, not sure why precommit tests didn't kick off. I tried a second time. Say, if the delegation token is not null, do we want to call HiveAuthFactory.getSocketTransport(host, port, loginTimeout) to get the transport?
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12613544/HIVE-5812.1.patch

          ERROR: -1 due to 1 failed/errored test(s), 4412 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers
          

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/485/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/485/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests exited with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          ATTACHMENT ID: 12613544

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12613544/HIVE-5812.1.patch ERROR: -1 due to 1 failed/errored test(s), 4412 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/485/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/485/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests exited with: TestsFailedException: 1 tests failed This message is automatically generated. ATTACHMENT ID: 12613544
          Hide
          Prasad Mujumdar added a comment -

          Brock Noland The delegation token case is part of HIVE-5155 patch.

          The failed test bucket_num_reducers doesn't seem to be related to the patch.

          Show
          Prasad Mujumdar added a comment - Brock Noland The delegation token case is part of HIVE-5155 patch. The failed test bucket_num_reducers doesn't seem to be related to the patch.
          Hide
          Prasad Mujumdar added a comment -

          Rebased patch

          Brock Noland would you like to take another look ?

          Show
          Prasad Mujumdar added a comment - Rebased patch Brock Noland would you like to take another look ?
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12618972/HIVE-5812.2.patch

          SUCCESS: +1 4789 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/655/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/655/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12618972

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12618972/HIVE-5812.2.patch SUCCESS: +1 4789 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/655/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/655/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12618972
          Hide
          Brock Noland added a comment -

          +1

          Show
          Brock Noland added a comment - +1
          Hide
          Brock Noland added a comment -

          Thank you for the contribution Prasad! I have committed this to trunk.

          Show
          Brock Noland added a comment - Thank you for the contribution Prasad! I have committed this to trunk.

            People

            • Assignee:
              Prasad Mujumdar
              Reporter:
              Prasad Mujumdar
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development