[HIVE-5763] ExprNodeGenericFuncDesc.toString() generating unbalanced parenthesises

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.13.0
• Component/s: Query Processor
• Assignee: Xuefu Zhang Assign to me
• Reporter: Xuefu Zhang
• Created: 06/Nov/13 23:19
• Updated: 24/Nov/13 02:15
• Resolved: 24/Nov/13 02:15

Description

This makes the generated expression tree unreadable.

  public String toString() {
    StringBuilder sb = new StringBuilder();
    sb.append(genericUDF.getClass().toString());
    sb.append("(");
    for (int i = 0; i < chidren.size(); i++) {
      if (i > 0) {
        sb.append(", ");
      }
      sb.append(chidren.get(i).toString());
    }
    sb.append("("); -- This needs to be removed.
    sb.append(")");
    return sb.toString();
  }