Hive
  1. Hive
  2. HIVE-5763

ExprNodeGenericFuncDesc.toString() generating unbalanced parenthesises

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.13.0
    • Component/s: Query Processor
    • Labels:
      None

      Description

      This makes the generated expression tree unreadable.

        public String toString() {
          StringBuilder sb = new StringBuilder();
          sb.append(genericUDF.getClass().toString());
          sb.append("(");
          for (int i = 0; i < chidren.size(); i++) {
            if (i > 0) {
              sb.append(", ");
            }
            sb.append(chidren.get(i).toString());
          }
          sb.append("("); -- This needs to be removed.
          sb.append(")");
          return sb.toString();
        }
      
      1. HIVE-5763.patch
        0.5 kB
        Xuefu Zhang
      2. HIVE-5763.2.patch
        21 kB
        Xuefu Zhang
      3. HIVE-5763.1.patch
        21 kB
        Xuefu Zhang

        Activity

        Xuefu Zhang created issue -
        Xuefu Zhang made changes -
        Field Original Value New Value
        Description This makes the generated expression tree unreadable. This makes the generated expression tree unreadable.
        {code}
          public String toString() {
            StringBuilder sb = new StringBuilder();
            sb.append(genericUDF.getClass().toString());
            sb.append("(");
            for (int i = 0; i < chidren.size(); i++) {
              if (i > 0) {
                sb.append(", ");
              }
              sb.append(chidren.get(i).toString());
            }
            sb.append("("); -- This needs to be removed.
            sb.append(")");
            return sb.toString();
          }
        {code}
        Xuefu Zhang made changes -
        Assignee Xuefu Zhang [ xuefuz ]
        Xuefu Zhang made changes -
        Attachment HIVE-5763.patch [ 12612443 ]
        Xuefu Zhang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Xuefu Zhang made changes -
        Attachment HIVE-5763.1.patch [ 12612622 ]
        Ashutosh Chauhan made changes -
        Status Patch Available [ 10002 ] Open [ 1 ]
        Xuefu Zhang made changes -
        Attachment HIVE-5763.2.patch [ 12615470 ]
        Xuefu Zhang made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Affects Version/s 0.12.0 [ 12324312 ]
        Xuefu Zhang made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.13.0 [ 12324986 ]
        Resolution Fixed [ 1 ]

          People

          • Assignee:
            Xuefu Zhang
            Reporter:
            Xuefu Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development