Hive
  1. Hive
  2. HIVE-5668

path normalization in MapOperator is expensive

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      The conversion of paths in MapWork.getPathToAliases is happening multiple times in MapOperator.cleanUpInputFileChangedOp. Caching the results of conversion can improve the performance of hive map tasks.

      1. HIVE-5668.1.patch
        1 kB
        Thejas M Nair

        Activity

        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12610523/HIVE-5668.1.patch

        SUCCESS: +1 4502 tests passed

        Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1269/testReport
        Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1269/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12610523/HIVE-5668.1.patch SUCCESS: +1 4502 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1269/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1269/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
        Hide
        Gunther Hagleitner added a comment -

        This makes a noticeable difference. And it's pretty straightforward. Looks good: +1

        Show
        Gunther Hagleitner added a comment - This makes a noticeable difference. And it's pretty straightforward. Looks good: +1
        Hide
        Thejas M Nair added a comment -

        Patch committed to trunk.
        Thanks for the review Gunther!

        Show
        Thejas M Nair added a comment - Patch committed to trunk. Thanks for the review Gunther!
        Hide
        Gunther Hagleitner added a comment -

        Thejas M Nair. I think you're supposed to say: Committed to trunk. Thanks Thejas! :-P

        Show
        Gunther Hagleitner added a comment - Thejas M Nair . I think you're supposed to say: Committed to trunk. Thanks Thejas! :-P

          People

          • Assignee:
            Thejas M Nair
            Reporter:
            Thejas M Nair
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development