Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.0
    • Component/s: Query Processor
    • Labels:
      None

      Description

      Implement optimized support for filters of the form

      column BETWEEN scalar1 AND scalar2

      in vectorized mode.

      1. HIVE-5582.7.patch
        42 kB
        Eric Hanson
      2. hive-5582.3.patch.txt
        28 kB
        Eric Hanson
      3. hive-5582.1.patch.txt
        16 kB
        Eric Hanson

        Activity

        Hide
        Eric Hanson added a comment -

        Parking a partially finished patch here for now. Not ready to apply yet.

        Show
        Eric Hanson added a comment - Parking a partially finished patch here for now. Not ready to apply yet.
        Hide
        Eric Hanson added a comment -

        Here's a second more or less finished patch for [NOT] BETWEEN. Needs some more testing.

        Show
        Eric Hanson added a comment - Here's a second more or less finished patch for [NOT] BETWEEN. Needs some more testing.
        Hide
        Eric Hanson added a comment -

        This works for integer and float families, timestamp, and string. It uses direct implementations based on new templates. NOT [BETWEEN] is evaluated with a single pass over the input vector.

        Show
        Eric Hanson added a comment - This works for integer and float families, timestamp, and string. It uses direct implementations based on new templates. NOT [BETWEEN] is evaluated with a single pass over the input vector.
        Hide
        Eric Hanson added a comment -

        Added support for [NOT] BETWEEN in vectorized mode. Added unit tests for vector expressions, and translation from a normal expression to a VectorExpression. Did ad hoc end-to-end tests.

        Show
        Eric Hanson added a comment - Added support for [NOT] BETWEEN in vectorized mode. Added unit tests for vector expressions, and translation from a normal expression to a VectorExpression. Did ad hoc end-to-end tests.
        Hide
        Eric Hanson added a comment -
        Show
        Eric Hanson added a comment - Code review link https://reviews.apache.org/r/14920/
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12610210/HIVE-5582.7.patch

        SUCCESS: +1 4490 tests passed

        Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1246/testReport
        Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1246/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12610210/HIVE-5582.7.patch SUCCESS: +1 4490 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1246/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1246/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
        Hide
        Ashutosh Chauhan added a comment -

        +1 Seems like timestamp type is also supported (by using their long representation), but I don't see any test for it. Can you add tests for timestamps in a follow-up jira.

        Show
        Ashutosh Chauhan added a comment - +1 Seems like timestamp type is also supported (by using their long representation), but I don't see any test for it. Can you add tests for timestamps in a follow-up jira.
        Hide
        Eric Hanson added a comment -

        ok
        Thanks!

        Show
        Eric Hanson added a comment - ok Thanks!
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Eric!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Eric!

          People

          • Assignee:
            Eric Hanson
            Reporter:
            Eric Hanson
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development