Hive
  1. Hive
  2. HIVE-5576

Blank lines missing from .q.out files created on Windows for testcase=TestCliDriver

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.13.0
    • Fix Version/s: 0.13.0
    • Component/s: Testing Infrastructure
    • Labels:
      None
    • Environment:

      Windows 8 using Hive Monarch build environment

      Description

      If you create a .q.out file on Windows using a command like this:

      ant test "-Dhadoop.security.version=1.1.0-SNAPSHOT" "-Dhadoop.root=c:\hw\project\hadoop-monarch" "-Dresolvers=internal" "-Dhadoop-0.20S.version=1.1.0-SNAPSHOT" "-Dhadoop.mr.rev=20S" "-Dhive.support.concurrency=false" "-Dshims.include=0.20S" "-Dtest.continue.on.failure=true" "-Dtest.halt.on.failure=no" "-Dtest.print.classpath=true" "-Dtestcase=TestCliDriver" "-Dqfile=vectorized_math_funcs.q,vectorized_string_funcs.q,vectorized_casts.q" "-Doverwrite=true" "-Dtest.silent=false"

      Then the .q.out files generated in the hive directory under
      ql\src\test\results\clientpositive
      having missing blank lines.

      So, the .q tests will pass on your Windows machine. But when you upload them in a patch, they fail on the automated build server. See HIVE-5517 for an example. HIVE-5517.3.patch has .q.out files with missing blank lines. Hive-5517.4.patch has .q.out files created on a Linux or Mac system. Those have blank lines.

      1. vectorized_math_funcs.q.out.windows
        17 kB
        Eric Hanson
      2. vectorized_math_funcs.q.out.unix
        17 kB
        Eric Hanson
      3. vectorized_math_funcs.q
        2 kB
        Eric Hanson
      4. HIVE-5576.1.patch
        0.7 kB
        Remus Rusanu

        Issue Links

          Activity

          Eric Hanson created issue -
          Hide
          Eric Hanson added a comment -

          Example .q file

          Show
          Eric Hanson added a comment - Example .q file
          Eric Hanson made changes -
          Field Original Value New Value
          Attachment vectorized_math_funcs.q [ 12608968 ]
          Hide
          Eric Hanson added a comment -

          Incorrect .q.out file from Windows, with missing blank lines

          Show
          Eric Hanson added a comment - Incorrect .q.out file from Windows, with missing blank lines
          Eric Hanson made changes -
          Attachment vectorized_math_funcs.q.out.windows [ 12608970 ]
          Hide
          Eric Hanson added a comment -

          .q.out file generated on Unix (Mac or Linux) that allows the test to pass on the automated build system.

          Show
          Eric Hanson added a comment - .q.out file generated on Unix (Mac or Linux) that allows the test to pass on the automated build system.
          Eric Hanson made changes -
          Attachment vectorized_math_funcs.q.out.unix [ 12608971 ]
          Remus Rusanu made changes -
          Assignee Remus Rusanu [ rusanu ]
          Remus Rusanu made changes -
          Link This issue is related to HIVE-5178 [ HIVE-5178 ]
          Hide
          Remus Rusanu added a comment -

          Fix, removes the logic from maskResult that was skipping empty lines on Windows

          Show
          Remus Rusanu added a comment - Fix, removes the logic from maskResult that was skipping empty lines on Windows
          Remus Rusanu made changes -
          Attachment HIVE-5576.1.patch [ 12610344 ]
          Remus Rusanu made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12610344/HIVE-5576.1.patch

          SUCCESS: +1 4483 tests passed

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1247/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1247/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12610344/HIVE-5576.1.patch SUCCESS: +1 4483 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/1247/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/1247/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Remus!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Remus!
          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.13.0 [ 12324986 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          ABORTED: Integrated in Hive-trunk-hadoop2 #526 (See https://builds.apache.org/job/Hive-trunk-hadoop2/526/)
          HIVE-5576 : Blank lines missing from .q.out files created on Windows for testcase=TestCliDriver (Remus Rusanu via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536426)

          • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
          Show
          Hudson added a comment - ABORTED: Integrated in Hive-trunk-hadoop2 #526 (See https://builds.apache.org/job/Hive-trunk-hadoop2/526/ ) HIVE-5576 : Blank lines missing from .q.out files created on Windows for testcase=TestCliDriver (Remus Rusanu via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536426 ) /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
          Hide
          Hudson added a comment -

          SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #217 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/217/)
          HIVE-5576 : Blank lines missing from .q.out files created on Windows for testcase=TestCliDriver (Remus Rusanu via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536426)

          • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
          Show
          Hudson added a comment - SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #217 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/217/ ) HIVE-5576 : Blank lines missing from .q.out files created on Windows for testcase=TestCliDriver (Remus Rusanu via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536426 ) /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
          Hide
          Hudson added a comment -

          ABORTED: Integrated in Hive-trunk-h0.21 #2427 (See https://builds.apache.org/job/Hive-trunk-h0.21/2427/)
          HIVE-5576 : Blank lines missing from .q.out files created on Windows for testcase=TestCliDriver (Remus Rusanu via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536426)

          • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
          Show
          Hudson added a comment - ABORTED: Integrated in Hive-trunk-h0.21 #2427 (See https://builds.apache.org/job/Hive-trunk-h0.21/2427/ ) HIVE-5576 : Blank lines missing from .q.out files created on Windows for testcase=TestCliDriver (Remus Rusanu via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1536426 ) /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java

            People

            • Assignee:
              Remus Rusanu
              Reporter:
              Eric Hanson
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development