Hive
  1. Hive
  2. HIVE-5266

HCatalog checkstyle failure due to HIVE-5225

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.13.0
    • Component/s: None
    • Labels:
      None
    1. HIVE-5266.patch
      2 kB
      Brock Noland

      Issue Links

        Activity

        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12602510/HIVE-5266.patch

        ERROR: -1 due to 23 failed/errored test(s), 3091 tests executed
        Failed tests:

        org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSchema
        org.apache.hive.hcatalog.fileformats.TestOrcDynamicPartitioned.testHCatDynamicPartitionedTableMultipleTask
        org.apache.hive.hcatalog.api.TestHCatClient.testObjectNotFoundException
        org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure
        org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testSequenceTableWriteRead
        org.apache.hive.hcatalog.api.TestHCatClient.testDropTableException
        org.apache.hive.hcatalog.api.TestHCatClient.testDropPartitionsWithPartialSpec
        org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testTextTableWriteRead
        org.apache.hive.hcatalog.api.TestHCatClient.testCreateTableLike
        org.apache.hive.hcatalog.api.TestHCatClient.testRenameTable
        org.apache.hive.hcatalog.api.TestHCatClient.testOtherFailure
        org.apache.hive.hcatalog.api.TestHCatClient.testBasicDDLCommands
        org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testSequenceTableWriteReadMR
        org.apache.hive.hcatalog.pig.TestHCatStorer.testPartColsInData
        org.apache.hcatalog.api.TestHCatClient.testBasicDDLCommands
        org.apache.hive.hcatalog.api.TestHCatClient.testGetPartitionsWithPartialSpec
        org.apache.hive.hcatalog.api.TestHCatClient.testUpdateTableSchema
        org.apache.hive.hcatalog.api.TestHCatClient.testDatabaseLocation
        org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testTextTableWriteReadMR
        org.apache.hive.hcatalog.api.TestHCatClient.testPartitionsHCatClientImpl
        org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_reducers_power_two
        org.apache.hcatalog.api.TestHCatClient.testCreateTableLike
        org.apache.hive.hcatalog.api.TestHCatClient.testGetMessageBusTopicName
        

        Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/694/testReport
        Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/694/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests failed with: TestsFailedException: 23 tests failed
        

        This message is automatically generated.

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12602510/HIVE-5266.patch ERROR: -1 due to 23 failed/errored test(s), 3091 tests executed Failed tests: org.apache.hive.hcatalog.api.TestHCatClient.testPartitionSchema org.apache.hive.hcatalog.fileformats.TestOrcDynamicPartitioned.testHCatDynamicPartitionedTableMultipleTask org.apache.hive.hcatalog.api.TestHCatClient.testObjectNotFoundException org.apache.hive.hcatalog.api.TestHCatClient.testTransportFailure org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testSequenceTableWriteRead org.apache.hive.hcatalog.api.TestHCatClient.testDropTableException org.apache.hive.hcatalog.api.TestHCatClient.testDropPartitionsWithPartialSpec org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testTextTableWriteRead org.apache.hive.hcatalog.api.TestHCatClient.testCreateTableLike org.apache.hive.hcatalog.api.TestHCatClient.testRenameTable org.apache.hive.hcatalog.api.TestHCatClient.testOtherFailure org.apache.hive.hcatalog.api.TestHCatClient.testBasicDDLCommands org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testSequenceTableWriteReadMR org.apache.hive.hcatalog.pig.TestHCatStorer.testPartColsInData org.apache.hcatalog.api.TestHCatClient.testBasicDDLCommands org.apache.hive.hcatalog.api.TestHCatClient.testGetPartitionsWithPartialSpec org.apache.hive.hcatalog.api.TestHCatClient.testUpdateTableSchema org.apache.hive.hcatalog.api.TestHCatClient.testDatabaseLocation org.apache.hive.hcatalog.mapreduce.TestSequenceFileReadWrite.testTextTableWriteReadMR org.apache.hive.hcatalog.api.TestHCatClient.testPartitionsHCatClientImpl org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_infer_bucket_sort_reducers_power_two org.apache.hcatalog.api.TestHCatClient.testCreateTableLike org.apache.hive.hcatalog.api.TestHCatClient.testGetMessageBusTopicName Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/694/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/694/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 23 tests failed This message is automatically generated.
        Hide
        Brock Noland added a comment -

        I think those are flaky tests and I have isolated them for future runs. In any case, in patch allows us to actually execute tests whereas at present we cannot due to the checkstyle violation.

        Show
        Brock Noland added a comment - I think those are flaky tests and I have isolated them for future runs. In any case, in patch allows us to actually execute tests whereas at present we cannot due to the checkstyle violation.
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Brock!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Brock!
        Hide
        Brock Noland added a comment -

        Thank you Ashutosh Chauhan!

        Show
        Brock Noland added a comment - Thank you Ashutosh Chauhan !
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2-ptest #95 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/95/)
        HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #95 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/95/ ) HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2 #422 (See https://builds.apache.org/job/Hive-trunk-hadoop2/422/)
        HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2 #422 (See https://builds.apache.org/job/Hive-trunk-hadoop2/422/ ) HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Hide
        Navis added a comment -

        Ashutosh ChauhanBrock Noland Sorry for this. I never imagined that not-used include could make build fail.

        Show
        Navis added a comment - Ashutosh Chauhan Brock Noland Sorry for this. I never imagined that not-used include could make build fail.
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #162 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/162/)
        HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hive-trunk-hadoop1-ptest #162 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/162/ ) HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Hide
        Ashutosh Chauhan added a comment -

        No worries Navis happens with everyone : )

        Show
        Ashutosh Chauhan added a comment - No worries Navis happens with everyone : )
        Hide
        Hudson added a comment -

        SUCCESS: Integrated in Hive-trunk-h0.21 #2325 (See https://builds.apache.org/job/Hive-trunk-h0.21/2325/)
        HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890)

        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java
        • /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Show
        Hudson added a comment - SUCCESS: Integrated in Hive-trunk-h0.21 #2325 (See https://builds.apache.org/job/Hive-trunk-h0.21/2325/ ) HIVE-5266 : HCatalog checkstyle failure due to HIVE5225 (Brock Noland via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1521890 ) /hive/trunk/hcatalog/core/src/main/java/org/apache/hcatalog/common/HiveClientCache.java /hive/trunk/hcatalog/core/src/main/java/org/apache/hive/hcatalog/common/HiveClientCache.java
        Hide
        Brock Noland added a comment -

        Navis No worries! I think I would have done the same thing... Once we move to maven I'd like to have this check as part of the pre-commit tests but not fail the normal builds because of it.

        Show
        Brock Noland added a comment - Navis No worries! I think I would have done the same thing... Once we move to maven I'd like to have this check as part of the pre-commit tests but not fail the normal builds because of it.

          People

          • Assignee:
            Brock Noland
            Reporter:
            Brock Noland
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development