Hive
  1. Hive
  2. HIVE-5122

Add partition for multiple partition ignores locations for non-first partitions

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: Query Processor
    • Labels:
      None

      Description

      http://www.mail-archive.com/user@hive.apache.org/msg09151.html
      When multiple partitions are being added in single alter table statement, the location for first partition is being used as the location of all partitions.

      1. HIVE-5122.D12411.1.patch
        9 kB
        Phabricator
      2. HIVE-5122.D12411.2.patch
        10 kB
        Phabricator
      3. D12411.3.patch
        11 kB
        Phabricator
      4. D12411.4.patch
        19 kB
        Phabricator
      5. HIVE-5122.4.patch
        19 kB
        Thejas M Nair

        Activity

        Hide
        Phabricator added a comment -

        navis requested code review of "HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions".

        Reviewers: JIRA

        HIVE-5122 Add partition for multiple partition ignores locations for non-first partitions

        http://www.mail-archive.com/user@hive.apache.org/msg09151.html

        TEST PLAN
        EMPTY

        REVISION DETAIL
        https://reviews.facebook.net/D12411

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        ql/src/test/queries/clientpositive/add_part_exist.q
        ql/src/test/results/clientpositive/add_part_exist.q.out

        MANAGE HERALD RULES
        https://reviews.facebook.net/herald/view/differential/

        WHY DID I GET THIS EMAIL?
        https://reviews.facebook.net/herald/transcript/29649/

        To: JIRA, navis

        Show
        Phabricator added a comment - navis requested code review of " HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions". Reviewers: JIRA HIVE-5122 Add partition for multiple partition ignores locations for non-first partitions http://www.mail-archive.com/user@hive.apache.org/msg09151.html TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D12411 AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ql/src/test/queries/clientpositive/add_part_exist.q ql/src/test/results/clientpositive/add_part_exist.q.out MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/29649/ To: JIRA, navis
        Hide
        Hive QA added a comment -

        Overall: -1 at least one tests failed

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12598904/HIVE-5122.D12411.1.patch

        ERROR: -1 due to 1 failed/errored test(s), 2885 tests executed
        Failed tests:

        org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_view_partitioned
        

        Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/487/testReport
        Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/487/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        Tests failed with: TestsFailedException: 1 tests failed
        

        This message is automatically generated.

        Show
        Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12598904/HIVE-5122.D12411.1.patch ERROR: -1 due to 1 failed/errored test(s), 2885 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_create_view_partitioned Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/487/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/487/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 1 tests failed This message is automatically generated.
        Hide
        Phabricator added a comment -

        navis updated the revision "HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions".

        Fixed test fail

        Reviewers: JIRA

        REVISION DETAIL
        https://reviews.facebook.net/D12411

        CHANGE SINCE LAST DIFF
        https://reviews.facebook.net/D12411?vs=38433&id=38499#toc

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        ql/src/test/queries/clientpositive/add_part_exist.q
        ql/src/test/results/clientpositive/add_part_exist.q.out
        ql/src/test/results/clientpositive/create_view_partitioned.q.out

        To: JIRA, navis

        Show
        Phabricator added a comment - navis updated the revision " HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions". Fixed test fail Reviewers: JIRA REVISION DETAIL https://reviews.facebook.net/D12411 CHANGE SINCE LAST DIFF https://reviews.facebook.net/D12411?vs=38433&id=38499#toc AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ql/src/test/queries/clientpositive/add_part_exist.q ql/src/test/results/clientpositive/add_part_exist.q.out ql/src/test/results/clientpositive/create_view_partitioned.q.out To: JIRA, navis
        Hide
        Thejas M Nair added a comment -

        Navis Your changes in this patch make the logic in both anltr grammar and DDLSemanticAnalyzer code much cleaner, it looks good. But I didn't understand what was causing this bug (and how the change fixes it). Was it some anltr weird behavior with old grammar that caused the issue?

        Show
        Thejas M Nair added a comment - Navis Your changes in this patch make the logic in both anltr grammar and DDLSemanticAnalyzer code much cleaner, it looks good. But I didn't understand what was causing this bug (and how the change fixes it). Was it some anltr weird behavior with old grammar that caused the issue?
        Hide
        Thejas M Nair added a comment -

        Just for the record, the AST for the plan without this fix clearly shows the problem (the location 'A' of first partition is associated with different partitions) -

        hive> explain ALTER TABLE add_part_test ADD IF NOT EXISTS           
            > PARTITION (ds='2010-01-01') location 'A'
            > PARTITION (ds='2010-02-01') location 'B'
            > PARTITION (ds='2010-03-01')
            > PARTITION (ds='2010-04-01') location 'C';
        OK
        ABSTRACT SYNTAX TREE:
          (TOK_ALTERTABLE_ADDPARTS add_part_test TOK_IFNOTEXISTS (TOK_PARTSPEC (TOK_PARTVAL ds '2010-01-01')) (TOK_PARTITIONLOCATION 'A') (TOK_PARTSPEC (TOK_PARTVAL ds '2010-02-01')) (TOK_PARTITIONLOCATION 'A') (TOK_PARTSPEC (TOK_PARTVAL ds '2010-03-01')) (TOK_PARTITIONLOCATION 'A') (TOK_PARTSPEC (TOK_PARTVAL ds '2010-04-01')) (TOK_PARTITIONLOCATION 'A'))
        
        STAGE DEPENDENCIES:
          Stage-0 is a root stage
          Stage-1 is a root stage
          Stage-2 is a root stage
          Stage-3 is a root stage
        
        STAGE PLANS:
          Stage: Stage-0
        
          Stage: Stage-1
        
          Stage: Stage-2
        
          Stage: Stage-3
        
        
        
        Show
        Thejas M Nair added a comment - Just for the record, the AST for the plan without this fix clearly shows the problem (the location 'A' of first partition is associated with different partitions) - hive> explain ALTER TABLE add_part_test ADD IF NOT EXISTS > PARTITION (ds='2010-01-01') location 'A' > PARTITION (ds='2010-02-01') location 'B' > PARTITION (ds='2010-03-01') > PARTITION (ds='2010-04-01') location 'C'; OK ABSTRACT SYNTAX TREE: (TOK_ALTERTABLE_ADDPARTS add_part_test TOK_IFNOTEXISTS (TOK_PARTSPEC (TOK_PARTVAL ds '2010-01-01')) (TOK_PARTITIONLOCATION 'A') (TOK_PARTSPEC (TOK_PARTVAL ds '2010-02-01')) (TOK_PARTITIONLOCATION 'A') (TOK_PARTSPEC (TOK_PARTVAL ds '2010-03-01')) (TOK_PARTITIONLOCATION 'A') (TOK_PARTSPEC (TOK_PARTVAL ds '2010-04-01')) (TOK_PARTITIONLOCATION 'A')) STAGE DEPENDENCIES: Stage-0 is a root stage Stage-1 is a root stage Stage-2 is a root stage Stage-3 is a root stage STAGE PLANS: Stage: Stage-0 Stage: Stage-1 Stage: Stage-2 Stage: Stage-3
        Hide
        Thejas M Nair added a comment -

        This looks like something we should get in for hive 0.12.

        Show
        Thejas M Nair added a comment - This looks like something we should get in for hive 0.12.
        Hide
        Thejas M Nair added a comment -

        +1
        Thanks for inputs from Harish on why the old grammar would have caused problems.

        Show
        Thejas M Nair added a comment - +1 Thanks for inputs from Harish on why the old grammar would have caused problems.
        Hide
        Navis added a comment -

        Thanks for the good explanation Thejas M Nair. Should the annotation in 'AddPartitionDesc' (the 'Path') be removed or replaced with 'Location' not be shown in test result?

        Show
        Navis added a comment - Thanks for the good explanation Thejas M Nair . Should the annotation in 'AddPartitionDesc' (the 'Path') be removed or replaced with 'Location' not be shown in test result?
        Hide
        Thejas M Nair added a comment -

        Yes, I agree, using Location and letting it get masked would be good in general. But if the partition location is masked the existing test case will not test if the issue of this jira has been fixed, the test case would need some changes.

        Show
        Thejas M Nair added a comment - Yes, I agree, using Location and letting it get masked would be good in general. But if the partition location is masked the existing test case will not test if the issue of this jira has been fixed, the test case would need some changes.
        Hide
        Phabricator added a comment -

        navis updated the revision "HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions".

        Rebased to trunk & addressed comment (Path to Location, which is filtered by QTestUtil)

        Reviewers: JIRA

        REVISION DETAIL
        https://reviews.facebook.net/D12411

        CHANGE SINCE LAST DIFF
        https://reviews.facebook.net/D12411?vs=38499&id=40029#toc

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        ql/src/test/queries/clientpositive/add_part_exist.q
        ql/src/test/results/clientpositive/add_part_exist.q.out
        ql/src/test/results/clientpositive/create_view_partitioned.q.out

        To: JIRA, navis

        Show
        Phabricator added a comment - navis updated the revision " HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions". Rebased to trunk & addressed comment (Path to Location, which is filtered by QTestUtil) Reviewers: JIRA REVISION DETAIL https://reviews.facebook.net/D12411 CHANGE SINCE LAST DIFF https://reviews.facebook.net/D12411?vs=38499&id=40029#toc AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ql/src/test/queries/clientpositive/add_part_exist.q ql/src/test/results/clientpositive/add_part_exist.q.out ql/src/test/results/clientpositive/create_view_partitioned.q.out To: JIRA, navis
        Hide
        Thejas M Nair added a comment -

        Navis, as I mention in my previous comment, with masking the test no longer checks if the locations are being picked up correctly. Ie, we won't know if someone introduces a bug that causes same problem again, and causes the first location to be associated with each of the partitions. The test case needs to be changed. Maybe, add partitions with data and use a select query selecting data from the partitions, to verify that correct locations are associated with the partitions?

        Show
        Thejas M Nair added a comment - Navis, as I mention in my previous comment, with masking the test no longer checks if the locations are being picked up correctly. Ie, we won't know if someone introduces a bug that causes same problem again, and causes the first location to be associated with each of the partitions. The test case needs to be changed. Maybe, add partitions with data and use a select query selecting data from the partitions, to verify that correct locations are associated with the partitions?
        Hide
        Navis added a comment -

        Good idea! I'll update the patch.

        Show
        Navis added a comment - Good idea! I'll update the patch.
        Hide
        Phabricator added a comment -

        navis updated the revision "HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions".

        Addressed comments

        Reviewers: JIRA

        REVISION DETAIL
        https://reviews.facebook.net/D12411

        CHANGE SINCE LAST DIFF
        https://reviews.facebook.net/D12411?vs=40029&id=40059#toc

        AFFECTED FILES
        ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
        ql/src/test/queries/clientpositive/add_part_multiple.q
        ql/src/test/results/clientpositive/add_part_multiple.q.out
        ql/src/test/results/clientpositive/create_view_partitioned.q.out

        To: JIRA, navis

        Show
        Phabricator added a comment - navis updated the revision " HIVE-5122 [jira] Add partition for multiple partition ignores locations for non-first partitions". Addressed comments Reviewers: JIRA REVISION DETAIL https://reviews.facebook.net/D12411 CHANGE SINCE LAST DIFF https://reviews.facebook.net/D12411?vs=40029&id=40059#toc AFFECTED FILES ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java ql/src/test/queries/clientpositive/add_part_multiple.q ql/src/test/results/clientpositive/add_part_multiple.q.out ql/src/test/results/clientpositive/create_view_partitioned.q.out To: JIRA, navis
        Hide
        Thejas M Nair added a comment -

        Looks good. +1

        Show
        Thejas M Nair added a comment - Looks good. +1
        Hide
        Thejas M Nair added a comment -

        Resubmitting patch for kicking off precommit tests on updated patch.

        Show
        Thejas M Nair added a comment - Resubmitting patch for kicking off precommit tests on updated patch.
        Hide
        Thejas M Nair added a comment -

        Copy of HIVE-5122.D12411.2.patch to get pre-commit tests running

        Show
        Thejas M Nair added a comment - Copy of HIVE-5122 .D12411.2.patch to get pre-commit tests running
        Hide
        Thejas M Nair added a comment -

        I previously copied wrong file. This time uploading D12411.4.patch as HIVE-5122.4.patch (conforms to format expected by https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing)

        Show
        Thejas M Nair added a comment - I previously copied wrong file. This time uploading D12411.4.patch as HIVE-5122 .4.patch (conforms to format expected by https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing )
        Hide
        Hive QA added a comment -

        Overall: +1 all checks pass

        Here are the results of testing the latest attachment:
        https://issues.apache.org/jira/secure/attachment/12604159/HIVE-5122.4.patch

        SUCCESS: +1 3128 tests passed

        Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/832/testReport
        Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/832/console

        Messages:

        Executing org.apache.hive.ptest.execution.PrepPhase
        Executing org.apache.hive.ptest.execution.ExecutionPhase
        Executing org.apache.hive.ptest.execution.ReportingPhase
        

        This message is automatically generated.

        Show
        Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12604159/HIVE-5122.4.patch SUCCESS: +1 3128 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/832/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/832/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
        Hide
        Thejas M Nair added a comment -

        Patch committed to trunk and 0.12 branch.
        Thanks for the contribution Navis!

        Show
        Thejas M Nair added a comment - Patch committed to trunk and 0.12 branch. Thanks for the contribution Navis!
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2-ptest #107 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/107/)
        HIVE-5122: Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930)

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
        • /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q
        • /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #107 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/107/ ) HIVE-5122 : Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930 ) /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop1-ptest #174 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/174/)
        HIVE-5122: Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930)

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
        • /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q
        • /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop1-ptest #174 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/174/ ) HIVE-5122 : Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930 ) /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-h0.21 #2345 (See https://builds.apache.org/job/Hive-trunk-h0.21/2345/)
        HIVE-5122: Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930)

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
        • /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q
        • /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-h0.21 #2345 (See https://builds.apache.org/job/Hive-trunk-h0.21/2345/ ) HIVE-5122 : Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930 ) /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Hide
        Hudson added a comment -

        FAILURE: Integrated in Hive-trunk-hadoop2 #444 (See https://builds.apache.org/job/Hive-trunk-hadoop2/444/)
        HIVE-5122: Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930)

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java
        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java
        • /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q
        • /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out
        • /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Show
        Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2 #444 (See https://builds.apache.org/job/Hive-trunk-hadoop2/444/ ) HIVE-5122 : Add partition for multiple partition ignores locations for non-first partitions (Navis via Thejas Nair) (thejas: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1524930 ) /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/AddPartitionDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/DDLWork.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java /hive/trunk/ql/src/test/queries/clientpositive/add_part_multiple.q /hive/trunk/ql/src/test/results/clientpositive/add_part_multiple.q.out /hive/trunk/ql/src/test/results/clientpositive/create_view_partitioned.q.out
        Hide
        Ashutosh Chauhan added a comment -

        This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

        Show
        Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          People

          • Assignee:
            Navis
            Reporter:
            Navis
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development