Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.4.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    1. HIVE-509.1.patch
      17 kB
      Zheng Shao
    2. HIVE-509.2.patch
      27 kB
      Zheng Shao
    3. HIVE-509.3.patch
      27 kB
      Zheng Shao

      Issue Links

        Activity

        Hide
        Namit Jain added a comment -

        +1

        looks good - will commit if the tests pass

        Show
        Namit Jain added a comment - +1 looks good - will commit if the tests pass
        Hide
        Namit Jain added a comment -

        lot of tests failed - can you refresh and regenerate the patch

        Show
        Namit Jain added a comment - lot of tests failed - can you refresh and regenerate the patch
        Hide
        Prasad Chakka added a comment -

        EXTERNAL should default to that of the like table instead of internal when EXTERNAL key word is not mentioned. Like means, all properties should be like the other table unless otherwise specified.

        Show
        Prasad Chakka added a comment - EXTERNAL should default to that of the like table instead of internal when EXTERNAL key word is not mentioned. Like means, all properties should be like the other table unless otherwise specified.
        Hide
        Zheng Shao added a comment -

        I still think EXTERNAL should be specified when we create the new table.

        "External" is just like the location where we store the table - we create a new table "like" the old table in every aspect except where the data is stored. Both "location" and "external" are descriptions of where the data is stored, so I don't think they should be inherited.

        Also, there is no "internal" keyword, which means there is no way to create an internal table like an external table, if the proposed way is implemented. (I don't think there is a way to alter a table to internal or external as well)

        Show
        Zheng Shao added a comment - I still think EXTERNAL should be specified when we create the new table. "External" is just like the location where we store the table - we create a new table "like" the old table in every aspect except where the data is stored. Both "location" and "external" are descriptions of where the data is stored, so I don't think they should be inherited. Also, there is no "internal" keyword, which means there is no way to create an internal table like an external table, if the proposed way is implemented. (I don't think there is a way to alter a table to internal or external as well)
        Hide
        Zheng Shao added a comment -

        Fixed another test error.

        Show
        Zheng Shao added a comment - Fixed another test error.
        Hide
        Namit Jain added a comment -

        +1
        looks good

        will commit if the tests pass

        Show
        Namit Jain added a comment - +1 looks good will commit if the tests pass
        Hide
        Namit Jain added a comment -

        committed. Thanks Zheng

        Show
        Namit Jain added a comment - committed. Thanks Zheng

          People

          • Assignee:
            Zheng Shao
            Reporter:
            Zheng Shao
          • Votes:
            1 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development