Uploaded image for project: 'Hive'
  1. Hive
  2. HIVE-4960

lastAlias in CommonJoinOperator is not used

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      In CommonJoinOperator, there is object called lastAlias. The initial value of this object is 'null'. After tracing the usage of this object, I found that there is no place to change the value of this object. Also, it is only used in processOp in JoinOperator and MapJoinOperator as

      if ((lastAlias == null) || (!lastAlias.equals(alias))) {
        nextSz = joinEmitInterval;
      }
      

      Since lastAlias will always be null, we will assign joinEmitInterval to nextSz every time we get a row. Later in processOp, we have

      nextSz = getNextSize(nextSz);
      

      Because we reset the value of nextSz to joinEmitInterval every time we get a row, seems that getNextSize will not be used as expected.

        Attachments

        1. HIVE-4960.D11895.1.patch
          2 kB
          Phabricator

          Activity

            People

            • Assignee:
              yhuai Yin Huai
              Reporter:
              yhuai Yin Huai
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: