Hive
  1. Hive
  2. HIVE-485

join assumes all columns are strings

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.4.0
    • Component/s: Query Processor
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      HIVE-485. Fix join not to assume all columns are strings. (Namit Jain via zshao)

      Description

      join assumes all columns are string - pass the objectinspector from execreducer and use that

      1. hive.485.1.patch
        17 kB
        Namit Jain
      2. hive.485.2.patch
        20 kB
        Namit Jain
      3. hive.485.3.patch
        20 kB
        Namit Jain

        Issue Links

          Activity

          Hide
          Zheng Shao added a comment -

          hive.485.2.patch:
          1. The patch adds ObjectInspector[] to Operator.initialize, but that parameter is only set for JoinOperator. I guess the intention is to leave the rest of the work to HIVE-405?
          2. Utility.hashCode() is not very efficient. I think we should do a "switch" based on the Category and PrimitiveCategory of the object.

          Show
          Zheng Shao added a comment - hive.485.2.patch: 1. The patch adds ObjectInspector[] to Operator.initialize, but that parameter is only set for JoinOperator. I guess the intention is to leave the rest of the work to HIVE-405 ? 2. Utility.hashCode() is not very efficient. I think we should do a "switch" based on the Category and PrimitiveCategory of the object.
          Hide
          Zheng Shao added a comment -

          +1
          Will commit if test passes.

          Show
          Zheng Shao added a comment - +1 Will commit if test passes.
          Hide
          Zheng Shao added a comment -

          Committed revision 776140.

          Show
          Zheng Shao added a comment - Committed revision 776140.

            People

            • Assignee:
              Namit Jain
              Reporter:
              Namit Jain
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development