Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.12.0
    • Component/s: Types
    • Labels:
      None

      Description

      Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc.
      Char type will be added as another task.

      1. HIVE-4844.1.patch.hack
        178 kB
        Jason Dere
      2. HIVE-4844.2.patch
        405 kB
        Jason Dere
      3. HIVE-4844.3.patch
        491 kB
        Jason Dere
      4. screenshot.png
        37 kB
        Xuefu Zhang
      5. HIVE-4844.4.patch
        350 kB
        Jason Dere
      6. HIVE-4844.5.patch
        541 kB
        Jason Dere
      7. HIVE-4844.6.patch
        541 kB
        Jason Dere
      8. HIVE-4844.7.patch
        565 kB
        Jason Dere
      9. HIVE-4844.8.patch
        663 kB
        Jason Dere
      10. HIVE-4844.9.patch
        667 kB
        Jason Dere
      11. HIVE-4844.10.patch
        665 kB
        Jason Dere
      12. HIVE-4844.11.patch
        662 kB
        Jason Dere
      13. HIVE-4844.D12699.1.patch
        329 kB
        Phabricator
      14. HIVE-4844.12.patch
        338 kB
        Jason Dere
      15. HIVE-4844.13.patch
        355 kB
        Jason Dere
      16. HIVE-4844.14.patch
        333 kB
        Jason Dere
      17. HIVE-4844.15.patch
        336 kB
        Jason Dere
      18. HIVE-4844.16.patch
        335 kB
        Jason Dere
      19. HIVE-4844.D12891.1.patch
        325 kB
        Phabricator
      20. HIVE-4844.17.patch
        337 kB
        Jason Dere
      21. HIVE-4844.18.patch
        337 kB
        Jason Dere
      22. HIVE-4844.19.patch
        337 kB
        Jason Dere
      23. HIVE-4844.v12.1.patch
        337 kB
        Jason Dere

        Issue Links

          Activity

          Hide
          Jason Dere added a comment -

          Initial patch of progress, as other folks may be interested in type parameters for HIVE-3976.

          Show
          Jason Dere added a comment - Initial patch of progress, as other folks may be interested in type parameters for HIVE-3976 .
          Hide
          Xuefu Zhang added a comment -

          Jason Dere Thanks for sharing your work. I went thru your patch and had some initial questions. I understand that your patch is still in progress, but I'm wondering what's your thought on how you plan to store the type params. Obviously, type params are metadata of a column, which needs to be stored. I assume that hive schema needs to change to accommodate this.

          Secondly, SQL VAR or VARCHAR seems to be special hive string with additional restriction. Your patch seems treating them independently. Do you think if type inheritance works here?

          Lastly, introducing param types seems non-trivial. Do you think if a design doc or wiki page makes sense?

          Show
          Xuefu Zhang added a comment - Jason Dere Thanks for sharing your work. I went thru your patch and had some initial questions. I understand that your patch is still in progress, but I'm wondering what's your thought on how you plan to store the type params. Obviously, type params are metadata of a column, which needs to be stored. I assume that hive schema needs to change to accommodate this. Secondly, SQL VAR or VARCHAR seems to be special hive string with additional restriction. Your patch seems treating them independently. Do you think if type inheritance works here? Lastly, introducing param types seems non-trivial. Do you think if a design doc or wiki page makes sense?
          Hide
          Jason Dere added a comment -

          Hi Xuefu,

          • The patch currently just keeps the params as part of the type string, which means no metastore changes, but could be brittle in other situations. An alternative could be additional columns in the COLUMNS metastore table to hold type qualifiers, similar to what other DB catalogs have, or a separate table of column_id/param_name/param_value. Do you have any suggestions here?
          • For inheritance, do you mean for the primitive/writable types? String is a final class, so I don't think it's doable for the primitive. I suppose the writable could derive from Text.
          • Sure, a wiki page makes sense. I'll put one up once I get wiki access.
          Show
          Jason Dere added a comment - Hi Xuefu, The patch currently just keeps the params as part of the type string, which means no metastore changes, but could be brittle in other situations. An alternative could be additional columns in the COLUMNS metastore table to hold type qualifiers, similar to what other DB catalogs have, or a separate table of column_id/param_name/param_value. Do you have any suggestions here? For inheritance, do you mean for the primitive/writable types? String is a final class, so I don't think it's doable for the primitive. I suppose the writable could derive from Text. Sure, a wiki page makes sense. I'll put one up once I get wiki access.
          Hide
          Xuefu Zhang added a comment -

          Jason Dere:

          1. I'm not sure which way is the better, but I feel that adding additional columns seems cleaner in my opinion.

          2. I could be off the topic on inheritance. I guess what I tried to say was some types, for instance, string, CHAR, and VARCHAR are very similar and may share a lot of implementations. This would also apply to DECIMAL and DECIMAL(p,s) also. However, I haven't figured out the implications yet. Please share your insights.

          Show
          Xuefu Zhang added a comment - Jason Dere : 1. I'm not sure which way is the better, but I feel that adding additional columns seems cleaner in my opinion. 2. I could be off the topic on inheritance. I guess what I tried to say was some types, for instance, string, CHAR, and VARCHAR are very similar and may share a lot of implementations. This would also apply to DECIMAL and DECIMAL(p,s) also. However, I haven't figured out the implications yet. Please share your insights.
          Hide
          Edward Capriolo added a comment -

          Ideally it would be best if by default the field has no parameters to not have to store any additional data in the metastore.

          Show
          Edward Capriolo added a comment - Ideally it would be best if by default the field has no parameters to not have to store any additional data in the metastore.
          Hide
          Jason Dere added a comment -

          Added a doc to the wiki at https://cwiki.apache.org/confluence/display/Hive/Type+Qualifiers+in+Hive.

          Ed, for the metastore changes, would additional columns in the COLUMNS_V2 metastore table be fine, if they are set to NULLs if there are no type qualifiers?

          Xuefu, yeah for char/varchar I was thinking they could probably share some inheritance, especially since they need to do some length checking, though I hadn't really thought about if they should share with existing String/Text. Well, they can't inherit String as I mentioned before. For decimal/decimal(p,s), I think the existing HiveDecimal might be fine, since I think the actual enforcement of precision/scale might happen at the ObjectInspectors/Converters/cast/deserialization.

          Show
          Jason Dere added a comment - Added a doc to the wiki at https://cwiki.apache.org/confluence/display/Hive/Type+Qualifiers+in+Hive . Ed, for the metastore changes, would additional columns in the COLUMNS_V2 metastore table be fine, if they are set to NULLs if there are no type qualifiers? Xuefu, yeah for char/varchar I was thinking they could probably share some inheritance, especially since they need to do some length checking, though I hadn't really thought about if they should share with existing String/Text. Well, they can't inherit String as I mentioned before. For decimal/decimal(p,s), I think the existing HiveDecimal might be fine, since I think the actual enforcement of precision/scale might happen at the ObjectInspectors/Converters/cast/deserialization.
          Hide
          Jason Dere added a comment -
          Show
          Jason Dere added a comment - Progress patch at https://reviews.facebook.net/D12255
          Hide
          Xuefu Zhang added a comment -

          Jason Dere It seems that the patch here and what you posted on fb rb are out of sync. Would you mind updating your patch here? Also, fb rb seems showing diff incorrectly, which is a little bothersome. Thanks.

          Show
          Xuefu Zhang added a comment - Jason Dere It seems that the patch here and what you posted on fb rb are out of sync. Would you mind updating your patch here? Also, fb rb seems showing diff incorrectly, which is a little bothersome. Thanks.
          Hide
          Jason Dere added a comment -

          I'd expect those two patches to be very different as there were a number of changes made between the first patch here and the one on phabricator. What is the issue you see with the diff on phabricator? It was too large to upload using the arc command so I had to use the --less-context option.

          Show
          Jason Dere added a comment - I'd expect those two patches to be very different as there were a number of changes made between the first patch here and the one on phabricator. What is the issue you see with the diff on phabricator? It was too large to upload using the arc command so I had to use the --less-context option.
          Hide
          Jason Dere added a comment -

          Also note that this has not been re-based in a while - last commit I have in my branch is 9fa33a6d0e7c18d6b94a29e8b6ef928126c9f274 from 2013-07-28.

          Show
          Jason Dere added a comment - Also note that this has not been re-based in a while - last commit I have in my branch is 9fa33a6d0e7c18d6b94a29e8b6ef928126c9f274 from 2013-07-28.
          Hide
          Jason Dere added a comment -

          Patch with changes from https://reviews.facebook.net/D12255. I actually have made a number of changes since then and will upload a new one shortly.

          Show
          Jason Dere added a comment - Patch with changes from https://reviews.facebook.net/D12255 . I actually have made a number of changes since then and will upload a new one shortly.
          Hide
          Jason Dere added a comment -

          Bit more progress since last phabricator patch.

          Show
          Jason Dere added a comment - Bit more progress since last phabricator patch.
          Hide
          Jason Dere added a comment -

          Been going over some of these changes with Gunther Hagleitner, and his input was that the metastore changes are not necessary for the varchar/decimal type qualifiers. The type name string is able to hold the whole type description, and in fact the nested types (struct/map/list) are simply represented as strings in the metastore. I'll look into reverting the metastore changes in the patch, and possibly some TypeQualifier-related changes if it makes sense.

          Show
          Jason Dere added a comment - Been going over some of these changes with Gunther Hagleitner, and his input was that the metastore changes are not necessary for the varchar/decimal type qualifiers. The type name string is able to hold the whole type description, and in fact the nested types (struct/map/list) are simply represented as strings in the metastore. I'll look into reverting the metastore changes in the patch, and possibly some TypeQualifier-related changes if it makes sense.
          Hide
          Xuefu Zhang added a comment -

          What is the issue you see with the diff on phabricator?

          I don't if this is normal, I attached a screenshot to describe what I saw.

          Show
          Xuefu Zhang added a comment - What is the issue you see with the diff on phabricator? I don't if this is normal, I attached a screenshot to describe what I saw.
          Hide
          Jason Dere added a comment -

          Sorry, still not really sure what the issues is that you're having with the Phabricator diff? But if you are trying to see more of the file through the web page, Phabricator is unable to do so because the diff upload was too large for Phabricator, and so I had to use the --less-context option when I uploaded

          Show
          Jason Dere added a comment - Sorry, still not really sure what the issues is that you're having with the Phabricator diff? But if you are trying to see more of the file through the web page, Phabricator is unable to do so because the diff upload was too large for Phabricator, and so I had to use the --less-context option when I uploaded
          Hide
          Xuefu Zhang added a comment -

          I'm sorry that I wasn't clear. Looking at the diff, I assumed that the lines in green are new additions. However,

          <field name="characterMaximumLength" >

          is new but is not green, while

          </embedded>

          is not new yet is green. It seems to me that the diff is one line off. Or my understanding is off?

          Show
          Xuefu Zhang added a comment - I'm sorry that I wasn't clear. Looking at the diff, I assumed that the lines in green are new additions. However, <field name= "characterMaximumLength" > is new but is not green, while </embedded> is not new yet is green. It seems to me that the diff is one line off. Or my understanding is off?
          Hide
          Xuefu Zhang added a comment -

          Re: type name vs additional columns

          By instinct I think latter suggests a cleaner approach while the former seems a little "hacky" as we put semantics in the type name, similar to putting a person's name and age in the same column. Having said that, I'm open to that approach. I just wasn't clear about all the benefits of it besides trying to save a schema upgrade.

          Show
          Xuefu Zhang added a comment - Re: type name vs additional columns By instinct I think latter suggests a cleaner approach while the former seems a little "hacky" as we put semantics in the type name, similar to putting a person's name and age in the same column. Having said that, I'm open to that approach. I just wasn't clear about all the benefits of it besides trying to save a schema upgrade.
          Hide
          Jason Dere added a comment -

          Yeah, the diff does appear to be a bit off, doesn't look like it's very useful does it? Might be better off just looking at the diff or applying it to 9fa33a6d0e7c18d6b94a29e8b6ef928126c9f274. I hope arcanist generated the diff properly.

          Removing the metastore changes does make some things a bit more consistent, since there were times where we were just trying to use the base type name for varchar, but in other instances where it was being used in a nested type we would use the full name.

          Show
          Jason Dere added a comment - Yeah, the diff does appear to be a bit off, doesn't look like it's very useful does it? Might be better off just looking at the diff or applying it to 9fa33a6d0e7c18d6b94a29e8b6ef928126c9f274. I hope arcanist generated the diff properly. Removing the metastore changes does make some things a bit more consistent, since there were times where we were just trying to use the base type name for varchar, but in other instances where it was being used in a nested type we would use the full name.
          Hide
          Jason Dere added a comment -

          reverted metastore changes

          Show
          Jason Dere added a comment - reverted metastore changes
          Hide
          Jason Dere added a comment -

          Attaching HIVE-4844.5.patch:

          • JDBC changes
          • FunctionRegistry.getMethodInternal() should prefer UDF signatures with greater affinity to the argument types passed in (varchar should prefer string, etc)
          Show
          Jason Dere added a comment - Attaching HIVE-4844 .5.patch: JDBC changes FunctionRegistry.getMethodInternal() should prefer UDF signatures with greater affinity to the argument types passed in (varchar should prefer string, etc)
          Hide
          Jason Dere added a comment -

          Attaching HIVE-4844.6.patch - rebased with trunk

          Show
          Jason Dere added a comment - Attaching HIVE-4844 .6.patch - rebased with trunk
          Hide
          Jason Dere added a comment -

          Apparently the patches I've been attaching (which I downloaded from Phabricator) are not applying correctly. Attaching char_progress.patch.7.txt which should be the same progress as char_progress.patch.6.txt, but with the patch generated from my git repository.

          Show
          Jason Dere added a comment - Apparently the patches I've been attaching (which I downloaded from Phabricator) are not applying correctly. Attaching char_progress.patch.7.txt which should be the same progress as char_progress.patch.6.txt, but with the patch generated from my git repository.
          Hide
          Jason Dere added a comment -

          attached wrong patch .. replacing char_progress.7.patch with HIVE-4844.7.patch.

          Show
          Jason Dere added a comment - attached wrong patch .. replacing char_progress.7.patch with HIVE-4844 .7.patch.
          Hide
          Xuefu Zhang added a comment -

          Jason Dere Since this patch is fairly big and progressing over time, I'm wondering if it makes sense to create a few sub tasks and attach smaller patch for each. Especially, you have changes for precision/scale that overlaps with HIVE-3976, and having a stable patch for the common changes makes it easy to create patches on the top of it. What do you think?

          Show
          Xuefu Zhang added a comment - Jason Dere Since this patch is fairly big and progressing over time, I'm wondering if it makes sense to create a few sub tasks and attach smaller patch for each. Especially, you have changes for precision/scale that overlaps with HIVE-3976 , and having a stable patch for the common changes makes it easy to create patches on the top of it. What do you think?
          Hide
          Jason Dere added a comment -

          Hi Xuefu, yes this patch has gotten pretty large. I think it's at a point where we can stop the work on this Jira (after I check in some additional tests I have been working on), and additional work can be added as sub tasks, such as support for additional SerDe's. I don't think the current progress can be easily split into smaller patches - perhaps the JDBC changes might be able to pulled out, but everything else needs to go in at the same time to work coherently.

          Show
          Jason Dere added a comment - Hi Xuefu, yes this patch has gotten pretty large. I think it's at a point where we can stop the work on this Jira (after I check in some additional tests I have been working on), and additional work can be added as sub tasks, such as support for additional SerDe's. I don't think the current progress can be easily split into smaller patches - perhaps the JDBC changes might be able to pulled out, but everything else needs to go in at the same time to work coherently.
          Hide
          Jason Dere added a comment -

          Attaching HIVE-4844.8.patch. This adds more unit tests, and a few fixes to get the unit tests to pass. Hopefully any further changes to this patch should be changes based on review comments.

          Show
          Jason Dere added a comment - Attaching HIVE-4844 .8.patch. This adds more unit tests, and a few fixes to get the unit tests to pass. Hopefully any further changes to this patch should be changes based on review comments.
          Hide
          Jason Dere added a comment -

          attaching HIVE-4844.9.patch, changes per review from hbutani:

          • descriptive comment about numericTypes map
          • TypeInfoParser fix and tests for invalid TypeInfo parameter syntax
          • raise error if Hive tries to instantiate varchar TypeInfo without type params.
          • fixed typo in constant value in Thrift file
          Show
          Jason Dere added a comment - attaching HIVE-4844 .9.patch, changes per review from hbutani: descriptive comment about numericTypes map TypeInfoParser fix and tests for invalid TypeInfo parameter syntax raise error if Hive tries to instantiate varchar TypeInfo without type params. fixed typo in constant value in Thrift file
          Hide
          Xuefu Zhang added a comment -

          Hi Jason,

          Thanks for your response. I understand it's hard to separate your patch into small patches. On the other hand, I'm wondering if the changes you made dealing with precision/scale is required for char/varchar support. If not, could you spare them from you patch?

          The problem I have is the difficulty to rebase my changes on your patch because of the progressive nature. This might makes easier for both of us to proceed. In the meantime, please feel free to include whatever changes that are needed for both feature.

          Please let me know. Thanks.

          Show
          Xuefu Zhang added a comment - Hi Jason, Thanks for your response. I understand it's hard to separate your patch into small patches. On the other hand, I'm wondering if the changes you made dealing with precision/scale is required for char/varchar support. If not, could you spare them from you patch? The problem I have is the difficulty to rebase my changes on your patch because of the progressive nature. This might makes easier for both of us to proceed. In the meantime, please feel free to include whatever changes that are needed for both feature. Please let me know. Thanks.
          Hide
          Jason Dere added a comment -

          Hi Xuefu, sorry about. I did add precision/scale in a few places, let's take a look:

          1. JDBC: The precision/scale is also used for returning varchar length, so these changes are necessary.
          2. BaseTypeParams/TypeQualifiers/TTypeQualifiers: These are objects used to hold type qualifier information, and I did add precision/scale fields/setters to these objects. If you'd like them removed I can remove any mention of precision/scale in these objects.
          3. TCLIService.thrift: Add constant string values to represent precision/scale fields. I can also remove those constant definitions if you like.

          Let me know if you want me to remove mention of precision/scale from (2) and (3).

          Show
          Jason Dere added a comment - Hi Xuefu, sorry about. I did add precision/scale in a few places, let's take a look: 1. JDBC: The precision/scale is also used for returning varchar length, so these changes are necessary. 2. BaseTypeParams/TypeQualifiers/TTypeQualifiers: These are objects used to hold type qualifier information, and I did add precision/scale fields/setters to these objects. If you'd like them removed I can remove any mention of precision/scale in these objects. 3. TCLIService.thrift: Add constant string values to represent precision/scale fields. I can also remove those constant definitions if you like. Let me know if you want me to remove mention of precision/scale from (2) and (3).
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12600466/HIVE-4844.9.patch

          ERROR: -1 due to 1 failed/errored test(s), 2918 tests executed
          Failed tests:

          org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers
          

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/553/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/553/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests failed with: TestsFailedException: 1 tests failed
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12600466/HIVE-4844.9.patch ERROR: -1 due to 1 failed/errored test(s), 2918 tests executed Failed tests: org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_bucket_num_reducers Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/553/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/553/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 1 tests failed This message is automatically generated.
          Hide
          Xuefu Zhang added a comment -

          Jason Dere for 2 and 3, could you please exclude them? They will not get wasted. (I will eventually include the patch for HIVE-3976.) This will help rebase and review. Thanks a lot.

          Show
          Xuefu Zhang added a comment - Jason Dere for 2 and 3, could you please exclude them? They will not get wasted. (I will eventually include the patch for HIVE-3976 .) This will help rebase and review. Thanks a lot.
          Hide
          Jason Dere added a comment -

          attaching HIVE-4844.10.patch - remove instances of precision/scale where appropriate per Xuefu's request

          Show
          Jason Dere added a comment - attaching HIVE-4844 .10.patch - remove instances of precision/scale where appropriate per Xuefu's request
          Hide
          Jason Dere added a comment -

          Xuefu, you're going to hate me for this one, but upon review of the code with hbutani, I am planning to remove the ParameterizedPrimitiveTypeInfo/ParameterizedPrimitiveObjectInspector interfaces and just add those methods to the PrimitiveTypeInfo/PrimitiveObjectInspector interfaces. I hope this doesn't cause too many rebase issues with your decimal work.

          Show
          Jason Dere added a comment - Xuefu, you're going to hate me for this one, but upon review of the code with hbutani, I am planning to remove the ParameterizedPrimitiveTypeInfo/ParameterizedPrimitiveObjectInspector interfaces and just add those methods to the PrimitiveTypeInfo/PrimitiveObjectInspector interfaces. I hope this doesn't cause too many rebase issues with your decimal work.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12600624/HIVE-4844.10.patch

          SUCCESS: +1 2918 tests passed

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/561/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/561/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12600624/HIVE-4844.10.patch SUCCESS: +1 2918 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/561/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/561/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Jason Dere added a comment -

          Attaching HIVE-4844.11.patch, with more changes from hbutani's review - fold ParameterizedPrimitiveTypeInfo into PrimitiveTypeInfo and ParameterizedOI into PrimitiveOI.

          Show
          Jason Dere added a comment - Attaching HIVE-4844 .11.patch, with more changes from hbutani's review - fold ParameterizedPrimitiveTypeInfo into PrimitiveTypeInfo and ParameterizedOI into PrimitiveOI.
          Hide
          Hive QA added a comment -

          Overall: -1 at least one tests failed

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12600709/HIVE-4844.11.patch

          ERROR: -1 due to 3 failed/errored test(s), 2918 tests executed
          Failed tests:

          org.apache.hcatalog.pig.TestHCatStorerMulti.testStoreBasicTable
          org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20
          org.apache.hcatalog.pig.TestHCatLoaderComplexSchema.testSyntheticComplexSchema
          

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/569/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/569/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          Tests failed with: TestsFailedException: 3 tests failed
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12600709/HIVE-4844.11.patch ERROR: -1 due to 3 failed/errored test(s), 2918 tests executed Failed tests: org.apache.hcatalog.pig.TestHCatStorerMulti.testStoreBasicTable org.apache.hadoop.hive.cli.TestNegativeMinimrCliDriver.testNegativeCliDriver_mapreduce_stack_trace_hadoop20 org.apache.hcatalog.pig.TestHCatLoaderComplexSchema.testSyntheticComplexSchema Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/569/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/569/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 3 tests failed This message is automatically generated.
          Hide
          Jason Dere added a comment -

          All three failures mentioned above (TestHCatStorerMulti, TestNegativeMinimrCliDriver, TestHCatLoaderComplexSchema) appear to pass when I run these tests myself.

          Show
          Jason Dere added a comment - All three failures mentioned above (TestHCatStorerMulti, TestNegativeMinimrCliDriver, TestHCatLoaderComplexSchema) appear to pass when I run these tests myself.
          Hide
          Jason Dere added a comment -

          ashutoshc, like Xuefu, has suggested that this patch be split into different subtasks where appropriate, to make review/tracking easier. I'll take a look at what I can do here. At first glance, looks like this can be done as the following set of changes:
          1. getMethodInternal() should prefer evaluate() signatures with more "similar" arguments
          2. Change getCommonClass/implicitConvertible to use PrimitiveCategory rather than TypeInfo
          3. Cast operators need to be set with type-specific data prior to initialization
          4. varchar work (will be done in this Jira)
          5. Thrift/JDBC changes for varchar

          Show
          Jason Dere added a comment - ashutoshc, like Xuefu, has suggested that this patch be split into different subtasks where appropriate, to make review/tracking easier. I'll take a look at what I can do here. At first glance, looks like this can be done as the following set of changes: 1. getMethodInternal() should prefer evaluate() signatures with more "similar" arguments 2. Change getCommonClass/implicitConvertible to use PrimitiveCategory rather than TypeInfo 3. Cast operators need to be set with type-specific data prior to initialization 4. varchar work (will be done in this Jira) 5. Thrift/JDBC changes for varchar
          Hide
          Phabricator added a comment -

          jdere requested code review of "HIVE-4844 [jira] Add varchar data type".

          Reviewers: JIRA

          Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc.
          Char type will be added as another task.

          TEST PLAN
          EMPTY

          REVISION DETAIL
          https://reviews.facebook.net/D12699

          AFFECTED FILES
          common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java
          common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java
          common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java
          data/files/datatypes.txt
          data/files/vc1.txt
          metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
          ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
          ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
          ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
          ql/src/test/queries/clientpositive/alter_varchar1.q
          ql/src/test/queries/clientpositive/ctas_varchar.q
          ql/src/test/queries/clientpositive/partition_varchar1.q
          ql/src/test/queries/clientpositive/varchar_1.q
          ql/src/test/queries/clientpositive/varchar_2.q
          ql/src/test/queries/clientpositive/varchar_cast.q
          ql/src/test/queries/clientpositive/varchar_comparison.q
          ql/src/test/queries/clientpositive/varchar_join1.q
          ql/src/test/queries/clientpositive/varchar_nested_types.q
          ql/src/test/queries/clientpositive/varchar_udf1.q
          ql/src/test/queries/clientpositive/varchar_union1.q
          ql/src/test/results/clientpositive/alter_varchar1.q.out
          ql/src/test/results/clientpositive/ctas_varchar.q.out
          ql/src/test/results/clientpositive/partition_varchar1.q.out
          ql/src/test/results/clientpositive/varchar_1.q.out
          ql/src/test/results/clientpositive/varchar_2.q.out
          ql/src/test/results/clientpositive/varchar_cast.q.out
          ql/src/test/results/clientpositive/varchar_comparison.q.out
          ql/src/test/results/clientpositive/varchar_join1.q.out
          ql/src/test/results/clientpositive/varchar_nested_types.q.out
          ql/src/test/results/clientpositive/varchar_udf1.q.out
          ql/src/test/results/clientpositive/varchar_union1.q.out
          ql/src/test/results/compiler/plan/groupby2.q.xml
          ql/src/test/results/compiler/plan/udf6.q.xml
          serde/if/serde.thrift
          serde/src/gen/thrift/gen-cpp/serde_constants.cpp
          serde/src/gen/thrift/gen-cpp/serde_constants.h
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
          serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
          serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
          serde/src/gen/thrift/gen-rb/serde_constants.rb
          serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java
          serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
          serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java
          serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java
          serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java

          MANAGE HERALD RULES
          https://reviews.facebook.net/herald/view/differential/

          WHY DID I GET THIS EMAIL?
          https://reviews.facebook.net/herald/transcript/30465/

          To: JIRA, jdere

          Show
          Phabricator added a comment - jdere requested code review of " HIVE-4844 [jira] Add varchar data type". Reviewers: JIRA Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D12699 AFFECTED FILES common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java data/files/datatypes.txt data/files/vc1.txt metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java ql/src/test/queries/clientpositive/alter_varchar1.q ql/src/test/queries/clientpositive/ctas_varchar.q ql/src/test/queries/clientpositive/partition_varchar1.q ql/src/test/queries/clientpositive/varchar_1.q ql/src/test/queries/clientpositive/varchar_2.q ql/src/test/queries/clientpositive/varchar_cast.q ql/src/test/queries/clientpositive/varchar_comparison.q ql/src/test/queries/clientpositive/varchar_join1.q ql/src/test/queries/clientpositive/varchar_nested_types.q ql/src/test/queries/clientpositive/varchar_udf1.q ql/src/test/queries/clientpositive/varchar_union1.q ql/src/test/results/clientpositive/alter_varchar1.q.out ql/src/test/results/clientpositive/ctas_varchar.q.out ql/src/test/results/clientpositive/partition_varchar1.q.out ql/src/test/results/clientpositive/varchar_1.q.out ql/src/test/results/clientpositive/varchar_2.q.out ql/src/test/results/clientpositive/varchar_cast.q.out ql/src/test/results/clientpositive/varchar_comparison.q.out ql/src/test/results/clientpositive/varchar_join1.q.out ql/src/test/results/clientpositive/varchar_nested_types.q.out ql/src/test/results/clientpositive/varchar_udf1.q.out ql/src/test/results/clientpositive/varchar_union1.q.out ql/src/test/results/compiler/plan/groupby2.q.xml ql/src/test/results/compiler/plan/udf6.q.xml serde/if/serde.thrift serde/src/gen/thrift/gen-cpp/serde_constants.cpp serde/src/gen/thrift/gen-cpp/serde_constants.h serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py serde/src/gen/thrift/gen-rb/serde_constants.rb serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/30465/ To: JIRA, jdere
          Hide
          Jason Dere added a comment -

          Attaching HIVE-4844.12.patch, which should now be a smaller patch since patch 11 has been broken up into several different subtasks.

          Show
          Jason Dere added a comment - Attaching HIVE-4844 .12.patch, which should now be a smaller patch since patch 11 has been broken up into several different subtasks.
          Hide
          Xuefu Zhang added a comment -

          Jason Dere Looking at your latest patch, I'm wondering if you have given thought on the max on varchar length. Right now you put Integer.MAX_VALUE as the max, but majority of DBs has a smaller limit than that. (Mysql chose 65,535, for instance.) Having a smaller max might leave room for optimization. I understand that there is no standard regarding this, but I'm curious if we made a conscious decision on that.

          Show
          Xuefu Zhang added a comment - Jason Dere Looking at your latest patch, I'm wondering if you have given thought on the max on varchar length. Right now you put Integer.MAX_VALUE as the max, but majority of DBs has a smaller limit than that. (Mysql chose 65,535, for instance.) Having a smaller max might leave room for optimization. I understand that there is no standard regarding this, but I'm curious if we made a conscious decision on that.
          Hide
          Jason Dere added a comment -

          The max varchar length setting was pretty arbitrary, sure we can have it set to a lower value. Any ideas on what value to initially set? 32,767 (small enough to fit within a short), or maybe something even smaller like 1024, just to make the point that we don't want enormous varchar columns that require checking the string length?

          Show
          Jason Dere added a comment - The max varchar length setting was pretty arbitrary, sure we can have it set to a lower value. Any ideas on what value to initially set? 32,767 (small enough to fit within a short), or maybe something even smaller like 1024, just to make the point that we don't want enormous varchar columns that require checking the string length?
          Hide
          Xuefu Zhang added a comment -

          I think people use varchar in Hive probably because of legacy data from DBs. Thus, a number at a scale of major DBs would be good. Yes, it's arbitrary. 64K would be good, but 64M or 64G might not be as good.

          Show
          Xuefu Zhang added a comment - I think people use varchar in Hive probably because of legacy data from DBs. Thus, a number at a scale of major DBs would be good. Yes, it's arbitrary. 64K would be good, but 64M or 64G might not be as good.
          Hide
          Jason Dere added a comment -

          Ok, 64K sounds good then. As it turns out there was nothing checking if varchar was defined with too large of a length, so that needed to be added in. Will post new patch shortly

          Show
          Jason Dere added a comment - Ok, 64K sounds good then. As it turns out there was nothing checking if varchar was defined with too large of a length, so that needed to be added in. Will post new patch shortly
          Hide
          Jason Dere added a comment -

          HIVE-4844.13.patch:

          • Rebase against trunk
          • Set max varchar length to 64K
          • Fix varchar length when casting constant string values to varchar
          Show
          Jason Dere added a comment - HIVE-4844 .13.patch: Rebase against trunk Set max varchar length to 64K Fix varchar length when casting constant string values to varchar
          Hide
          Xuefu Zhang added a comment -

          Yeah. 64K is good. Just minor thought. Instead of 64K (65556), MYSQL chooses 65535, 1 less than 64K. I don't know if there is any pitfall there. I also saw instead of 256, 255 used for length in other DBs. Anyone has any idea?

          Show
          Xuefu Zhang added a comment - Yeah. 64K is good. Just minor thought. Instead of 64K (65556), MYSQL chooses 65535, 1 less than 64K. I don't know if there is any pitfall there. I also saw instead of 256, 255 used for length in other DBs. Anyone has any idea?
          Hide
          Jason Dere added a comment -

          Sure, I'll bump the max down to 65535, though it won't matter much for Hive since a Java short only goes up to 32K, so we need an int to hold the value either way. I need to rebase this patch yet again due to review changes from HIVE-5206, so I'll add this change when I roll a new patch.

          Show
          Jason Dere added a comment - Sure, I'll bump the max down to 65535, though it won't matter much for Hive since a Java short only goes up to 32K, so we need an int to hold the value either way. I need to rebase this patch yet again due to review changes from HIVE-5206 , so I'll add this change when I roll a new patch.
          Hide
          Jason Dere added a comment -

          new patch HIVE-4844.14.patch:

          • rebase against updated patch of HIVE-5206
          • set max varchar length to 65535
          • remove re-implemented concat/lower/upper GenericUDFs, will added in HIVE-5278
          Show
          Jason Dere added a comment - new patch HIVE-4844 .14.patch: rebase against updated patch of HIVE-5206 set max varchar length to 65535 remove re-implemented concat/lower/upper GenericUDFs, will added in HIVE-5278
          Hide
          Ashutosh Chauhan added a comment -

          Jason Dere Left some comments on phabricator.

          Show
          Ashutosh Chauhan added a comment - Jason Dere Left some comments on phabricator.
          Hide
          Ashutosh Chauhan added a comment -

          And few more : )

          Show
          Ashutosh Chauhan added a comment - And few more : )
          Hide
          Jason Dere added a comment -

          upload patch 15, with changes from review comments from ashutosh.
          Also new review link with this patch at https://reviews.facebook.net/D12891

          Show
          Jason Dere added a comment - upload patch 15, with changes from review comments from ashutosh. Also new review link with this patch at https://reviews.facebook.net/D12891
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Phabricator added a comment -

          ashutoshc has commented on the revision "HIVE-4844 [jira] Add varchar data type".

          Mostly looks good. Some comments.
          I don't see any changes in ColumnarSerde, LazyBinaryColumnarSede. If they are not supported thats alright. But, if they are can you add tests for RCFile data with these two serdes. Simlarily HBaseSerde and AvroSerde. If you intend to support it will be good to add testcases for those, else support for them can be added later as well.

          INLINE COMMENTS
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:629 This method belongs in TypeInfoUtils class.
          ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:160 Move this method to TypeInfoUtils
          ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:169 This to ParseUtils
          ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:48 Shall we also update this error message saying, first arg must be either string or varchar ?
          ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:56 Error message
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:39-40 You need to mark all these fields as transient.
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:36 You can add @Description annotation for this which will be useful for end users.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:401 This for CHAR right, for varchar we need not to do this.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:474 Can you check the standard here? We may get bitten by backward-compat issues because of this latter.

          REVISION DETAIL
          https://reviews.facebook.net/D12699

          To: JIRA, jdere
          Cc: ashutoshc

          Show
          Phabricator added a comment - ashutoshc has commented on the revision " HIVE-4844 [jira] Add varchar data type". Mostly looks good. Some comments. I don't see any changes in ColumnarSerde, LazyBinaryColumnarSede. If they are not supported thats alright. But, if they are can you add tests for RCFile data with these two serdes. Simlarily HBaseSerde and AvroSerde. If you intend to support it will be good to add testcases for those, else support for them can be added later as well. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:629 This method belongs in TypeInfoUtils class. ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:160 Move this method to TypeInfoUtils ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:169 This to ParseUtils ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:48 Shall we also update this error message saying, first arg must be either string or varchar ? ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:56 Error message ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:39-40 You need to mark all these fields as transient. ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:36 You can add @Description annotation for this which will be useful for end users. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:401 This for CHAR right, for varchar we need not to do this. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:474 Can you check the standard here? We may get bitten by backward-compat issues because of this latter. REVISION DETAIL https://reviews.facebook.net/D12699 To: JIRA, jdere Cc: ashutoshc
          Hide
          Phabricator added a comment -

          ashutoshc has commented on the revision "HIVE-4844 [jira] Add varchar data type".

          Sorry.. missed while previewing earlier.

          INLINE COMMENTS
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java:34 You need to add no-arg constructor for Kryo to correctly serialize this.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java:32 Need to add no-arg constructor for Kryo to work correctly.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java:33 no-arg constructor.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java:35 no-arg ctor.

          REVISION DETAIL
          https://reviews.facebook.net/D12699

          To: JIRA, jdere
          Cc: ashutoshc

          Show
          Phabricator added a comment - ashutoshc has commented on the revision " HIVE-4844 [jira] Add varchar data type". Sorry.. missed while previewing earlier. INLINE COMMENTS serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java:34 You need to add no-arg constructor for Kryo to correctly serialize this. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java:32 Need to add no-arg constructor for Kryo to work correctly. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java:33 no-arg constructor. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java:35 no-arg ctor. REVISION DETAIL https://reviews.facebook.net/D12699 To: JIRA, jdere Cc: ashutoshc
          Hide
          Jason Dere added a comment -

          Apparently hadn't completely removed java files for GenericUDFConcat/Upper/Lower - they were still in the patch as empty files. Adding patch v16 which removes those empty files.

          Show
          Jason Dere added a comment - Apparently hadn't completely removed java files for GenericUDFConcat/Upper/Lower - they were still in the patch as empty files. Adding patch v16 which removes those empty files.
          Hide
          Phabricator added a comment -

          jdere has commented on the revision "HIVE-4844 [jira] Add varchar data type".

          Most of the SerDe support has been broken out into HIVE-5161. The SerDe's I'm testing there are RegexSerDe, LazyBinarySerDe, LazySimpleSerDe, ColumnarSerDe, LazyBinaryColumnarSerDe, OrcSerDe. I'll need to take a look again, but if HBase/Avro SerDe's use reflection-based methods to get their Types/ObjectInspectors, then they won't be able to support varchars properly.

          INLINE COMMENTS
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:629 will change in the next patch
          ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:160 will change in next patch
          ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:169 will change in next patch
          ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:48 sure, will change
          ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:56 will change this message too
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:36 whoops forgot to add that .. will do
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:39-40 Actually, my latest patch did mark these fields as transient .. I'll need to update this review with the updated patch.
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java:34 Do we need to serialize object inspectors? my impression is that should always have been transient, at least when they're used in UDFs since they can be set during initialize().
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:401 Yeah, this comment is gone in the updated patch.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:474 2011 SQL Standard (6.13 cast specification) does say that the value should be "TRUE"/"FALSE". This also matches what we're doing with the string type.
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java:33 ok, will change
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java:35 will change

          REVISION DETAIL
          https://reviews.facebook.net/D12699

          To: JIRA, jdere
          Cc: ashutoshc

          Show
          Phabricator added a comment - jdere has commented on the revision " HIVE-4844 [jira] Add varchar data type". Most of the SerDe support has been broken out into HIVE-5161 . The SerDe's I'm testing there are RegexSerDe, LazyBinarySerDe, LazySimpleSerDe, ColumnarSerDe, LazyBinaryColumnarSerDe, OrcSerDe. I'll need to take a look again, but if HBase/Avro SerDe's use reflection-based methods to get their Types/ObjectInspectors, then they won't be able to support varchars properly. INLINE COMMENTS ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java:629 will change in the next patch ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:160 will change in next patch ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java:169 will change in next patch ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:48 sure, will change ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java:56 will change this message too ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:36 whoops forgot to add that .. will do ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java:39-40 Actually, my latest patch did mark these fields as transient .. I'll need to update this review with the updated patch. serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java:34 Do we need to serialize object inspectors? my impression is that should always have been transient, at least when they're used in UDFs since they can be set during initialize(). serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:401 Yeah, this comment is gone in the updated patch. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java:474 2011 SQL Standard (6.13 cast specification) does say that the value should be "TRUE"/"FALSE". This also matches what we're doing with the string type. serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java:33 ok, will change serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java:35 will change REVISION DETAIL https://reviews.facebook.net/D12699 To: JIRA, jdere Cc: ashutoshc
          Hide
          Phabricator added a comment -

          jdere requested code review of "HIVE-4844 [jira] Add varchar data type".

          Reviewers: JIRA

          Changes to HIVE-4844 per review from ashutosh

          Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc.
          Char type will be added as another task.

          TEST PLAN
          EMPTY

          REVISION DETAIL
          https://reviews.facebook.net/D12891

          AFFECTED FILES
          common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java
          common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java
          common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java
          data/files/datatypes.txt
          data/files/vc1.txt
          ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
          ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
          ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
          ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java
          ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
          ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
          ql/src/test/queries/clientnegative/invalid_varchar_length_1.q
          ql/src/test/queries/clientnegative/invalid_varchar_length_2.q
          ql/src/test/queries/clientnegative/invalid_varchar_length_3.q
          ql/src/test/queries/clientpositive/alter_varchar1.q
          ql/src/test/queries/clientpositive/ctas_varchar.q
          ql/src/test/queries/clientpositive/partition_varchar1.q
          ql/src/test/queries/clientpositive/varchar_1.q
          ql/src/test/queries/clientpositive/varchar_2.q
          ql/src/test/queries/clientpositive/varchar_cast.q
          ql/src/test/queries/clientpositive/varchar_comparison.q
          ql/src/test/queries/clientpositive/varchar_join1.q
          ql/src/test/queries/clientpositive/varchar_nested_types.q
          ql/src/test/queries/clientpositive/varchar_udf1.q
          ql/src/test/queries/clientpositive/varchar_union1.q
          ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out
          ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out
          ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out
          ql/src/test/results/clientpositive/alter_varchar1.q.out
          ql/src/test/results/clientpositive/ctas_varchar.q.out
          ql/src/test/results/clientpositive/partition_varchar1.q.out
          ql/src/test/results/clientpositive/varchar_1.q.out
          ql/src/test/results/clientpositive/varchar_2.q.out
          ql/src/test/results/clientpositive/varchar_cast.q.out
          ql/src/test/results/clientpositive/varchar_comparison.q.out
          ql/src/test/results/clientpositive/varchar_join1.q.out
          ql/src/test/results/clientpositive/varchar_nested_types.q.out
          ql/src/test/results/clientpositive/varchar_udf1.q.out
          ql/src/test/results/clientpositive/varchar_union1.q.out
          serde/if/serde.thrift
          serde/src/gen/thrift/gen-cpp/serde_constants.cpp
          serde/src/gen/thrift/gen-cpp/serde_constants.h
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
          serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
          serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
          serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
          serde/src/gen/thrift/gen-rb/serde_constants.rb
          serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java
          serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
          serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java
          serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
          serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java
          serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java

          MANAGE HERALD RULES
          https://reviews.facebook.net/herald/view/differential/

          WHY DID I GET THIS EMAIL?
          https://reviews.facebook.net/herald/transcript/30861/

          To: JIRA, jdere

          Show
          Phabricator added a comment - jdere requested code review of " HIVE-4844 [jira] Add varchar data type". Reviewers: JIRA Changes to HIVE-4844 per review from ashutosh Add new varchar data types which have support for more SQL-compliant behavior, such as SQL string comparison semantics, max length, etc. Char type will be added as another task. TEST PLAN EMPTY REVISION DETAIL https://reviews.facebook.net/D12891 AFFECTED FILES common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java data/files/datatypes.txt data/files/vc1.txt ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcat.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFLower.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUpper.java ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java ql/src/test/queries/clientnegative/invalid_varchar_length_1.q ql/src/test/queries/clientnegative/invalid_varchar_length_2.q ql/src/test/queries/clientnegative/invalid_varchar_length_3.q ql/src/test/queries/clientpositive/alter_varchar1.q ql/src/test/queries/clientpositive/ctas_varchar.q ql/src/test/queries/clientpositive/partition_varchar1.q ql/src/test/queries/clientpositive/varchar_1.q ql/src/test/queries/clientpositive/varchar_2.q ql/src/test/queries/clientpositive/varchar_cast.q ql/src/test/queries/clientpositive/varchar_comparison.q ql/src/test/queries/clientpositive/varchar_join1.q ql/src/test/queries/clientpositive/varchar_nested_types.q ql/src/test/queries/clientpositive/varchar_udf1.q ql/src/test/queries/clientpositive/varchar_union1.q ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out ql/src/test/results/clientpositive/alter_varchar1.q.out ql/src/test/results/clientpositive/ctas_varchar.q.out ql/src/test/results/clientpositive/partition_varchar1.q.out ql/src/test/results/clientpositive/varchar_1.q.out ql/src/test/results/clientpositive/varchar_2.q.out ql/src/test/results/clientpositive/varchar_cast.q.out ql/src/test/results/clientpositive/varchar_comparison.q.out ql/src/test/results/clientpositive/varchar_join1.q.out ql/src/test/results/clientpositive/varchar_nested_types.q.out ql/src/test/results/clientpositive/varchar_udf1.q.out ql/src/test/results/clientpositive/varchar_union1.q.out serde/if/serde.thrift serde/src/gen/thrift/gen-cpp/serde_constants.cpp serde/src/gen/thrift/gen-cpp/serde_constants.h serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py serde/src/gen/thrift/gen-rb/serde_constants.rb serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java MANAGE HERALD RULES https://reviews.facebook.net/herald/view/differential/ WHY DID I GET THIS EMAIL? https://reviews.facebook.net/herald/transcript/30861/ To: JIRA, jdere
          Hide
          Phabricator added a comment -

          ashutoshc has accepted the revision "HIVE-4844 [jira] Add varchar data type".

          +1 Thanks, Jason for making changes.

          REVISION DETAIL
          https://reviews.facebook.net/D12891

          BRANCH
          HIVE-4844.2

          ARCANIST PROJECT
          hive

          To: JIRA, ashutoshc, jdere

          Show
          Phabricator added a comment - ashutoshc has accepted the revision " HIVE-4844 [jira] Add varchar data type". +1 Thanks, Jason for making changes. REVISION DETAIL https://reviews.facebook.net/D12891 BRANCH HIVE-4844 .2 ARCANIST PROJECT hive To: JIRA, ashutoshc, jdere
          Hide
          Jason Dere added a comment -

          Ran unit test and got a couple failures:

          • varchar_union1.q: looks like this test is not deterministic, need to make sure the query results are sorted
          • udf_reflect2.q: looks like I had a bug in PrimitiveObjectInspectorUtils.getTypeEntryFromTypeSpecs()
            Will update the patch shortly
          Show
          Jason Dere added a comment - Ran unit test and got a couple failures: varchar_union1.q: looks like this test is not deterministic, need to make sure the query results are sorted udf_reflect2.q: looks like I had a bug in PrimitiveObjectInspectorUtils.getTypeEntryFromTypeSpecs() Will update the patch shortly
          Hide
          Jason Dere added a comment -

          patch v17 - fix unit test failures

          Show
          Jason Dere added a comment - patch v17 - fix unit test failures
          Hide
          Xuefu Zhang added a comment -

          Thanks for making so much progress in such a short time. I have some comments while reading the patch.

          1. TypeInfoUtils.addParamsToTypeName() seems having duplicated code with VarcharTypeParam.toString().I also saw this in FunctionRegistry, which also has some duplicated logic here. It's nice if we can consolidate and have single point of reference for this.

          +        String typeName =
          +            PrimitiveObjectInspectorUtils.getTypeEntryFromPrimitiveCategory(typeCategory).typeName
          +            + varcharParams.toString();
          

          2. DDLSemanticAnalyzer.getTypeName() tries to get a list of Strings from the ASTNode by using ParseUtils.getCharParams(), in which only a subset of checks are performed. (For instance, it doesn't validate the MAX allowed length.) Instead, I think it's probably better to get VarcharTypeParams instance from the ASTNode and let the instance perform all the checks.

          I haven't gone thru the patch yet, but I'd like to share my thoughts.

          Show
          Xuefu Zhang added a comment - Thanks for making so much progress in such a short time. I have some comments while reading the patch. 1. TypeInfoUtils.addParamsToTypeName() seems having duplicated code with VarcharTypeParam.toString().I also saw this in FunctionRegistry, which also has some duplicated logic here. It's nice if we can consolidate and have single point of reference for this. + String typeName = + PrimitiveObjectInspectorUtils.getTypeEntryFromPrimitiveCategory(typeCategory).typeName + + varcharParams.toString(); 2. DDLSemanticAnalyzer.getTypeName() tries to get a list of Strings from the ASTNode by using ParseUtils.getCharParams(), in which only a subset of checks are performed. (For instance, it doesn't validate the MAX allowed length.) Instead, I think it's probably better to get VarcharTypeParams instance from the ASTNode and let the instance perform all the checks. I haven't gone thru the patch yet, but I'd like to share my thoughts.
          Hide
          Xuefu Zhang added a comment -

          Also in ParseUtils.getCharParams(), checking NumberFormatException and child count is probably not needed. This attributes to the grammar rule.

          +    | KW_VARCHAR LPAREN length=Number RPAREN      ->    ^(TOK_VARCHAR $length)
          

          This is a minor thing that probably makes the code cleaner.

          Show
          Xuefu Zhang added a comment - Also in ParseUtils.getCharParams(), checking NumberFormatException and child count is probably not needed. This attributes to the grammar rule. + | KW_VARCHAR LPAREN length= Number RPAREN -> ^(TOK_VARCHAR $length) This is a minor thing that probably makes the code cleaner.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12603075/HIVE-4844.17.patch

          SUCCESS: +1 3124 tests passed

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/727/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/727/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12603075/HIVE-4844.17.patch SUCCESS: +1 3124 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/727/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/727/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Jason Dere added a comment -

          Adding patch v18, which incorporates Xuefu's comments about consolidating type name generation. No longer catching NumberFormatException, but there still is a try/catch there since the type params validation throws a SerDeException, and I figured it made more sense to return a SemanticException in that context.

          Show
          Jason Dere added a comment - Adding patch v18, which incorporates Xuefu's comments about consolidating type name generation. No longer catching NumberFormatException, but there still is a try/catch there since the type params validation throws a SerDeException, and I figured it made more sense to return a SemanticException in that context.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12603075/HIVE-4844.17.patch

          SUCCESS: +1 3124 tests passed

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/744/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/744/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12603075/HIVE-4844.17.patch SUCCESS: +1 3124 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/744/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/744/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Jason Dere added a comment -

          Just got the unit test results from v18 and one of the negative tests failed, will need to roll another patch to update the test output.

          Show
          Jason Dere added a comment - Just got the unit test results from v18 and one of the negative tests failed, will need to roll another patch to update the test output.
          Hide
          Jason Dere added a comment -

          patch v19 - fixed unit test failure, updated error message

          Show
          Jason Dere added a comment - patch v19 - fixed unit test failure, updated error message
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12603206/HIVE-4844.19.patch

          SUCCESS: +1 3124 tests passed

          Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/751/testReport
          Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/751/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12603206/HIVE-4844.19.patch SUCCESS: +1 3124 tests passed Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/751/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/751/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated.
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Jason for this useful addition in Hive!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Jason for this useful addition in Hive!
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-h0.21 #2334 (See https://builds.apache.org/job/Hive-trunk-h0.21/2334/)
          HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463)

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java
          • /hive/trunk/data/files/datatypes.txt
          • /hive/trunk/data/files/vc1.txt
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
          • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q
          • /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q
          • /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out
          • /hive/trunk/serde/if/serde.thrift
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
          • /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
          • /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
          • /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-h0.21 #2334 (See https://builds.apache.org/job/Hive-trunk-h0.21/2334/ ) HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463 ) /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java /hive/trunk/data/files/datatypes.txt /hive/trunk/data/files/vc1.txt /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out /hive/trunk/serde/if/serde.thrift /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop2 #431 (See https://builds.apache.org/job/Hive-trunk-hadoop2/431/)
          HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463)

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java
          • /hive/trunk/data/files/datatypes.txt
          • /hive/trunk/data/files/vc1.txt
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
          • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q
          • /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q
          • /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out
          • /hive/trunk/serde/if/serde.thrift
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
          • /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
          • /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
          • /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2 #431 (See https://builds.apache.org/job/Hive-trunk-hadoop2/431/ ) HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463 ) /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java /hive/trunk/data/files/datatypes.txt /hive/trunk/data/files/vc1.txt /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out /hive/trunk/serde/if/serde.thrift /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop2-ptest #98 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/98/)
          HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463)

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java
          • /hive/trunk/data/files/datatypes.txt
          • /hive/trunk/data/files/vc1.txt
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
          • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q
          • /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q
          • /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out
          • /hive/trunk/serde/if/serde.thrift
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
          • /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
          • /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
          • /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #98 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/98/ ) HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463 ) /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java /hive/trunk/data/files/datatypes.txt /hive/trunk/data/files/vc1.txt /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out /hive/trunk/serde/if/serde.thrift /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Hide
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop1-ptest #165 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/165/)
          HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463)

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java
          • /hive/trunk/data/files/datatypes.txt
          • /hive/trunk/data/files/vc1.txt
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java
          • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java
          • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q
          • /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q
          • /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q
          • /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q
          • /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out
          • /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out
          • /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out
          • /hive/trunk/serde/if/serde.thrift
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp
          • /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java
          • /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java
          • /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php
          • /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py
          • /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java
          • /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo
          • /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop1-ptest #165 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/165/ ) HIVE-4844 : Add varchar data type (Jason Dere via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1523463 ) /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveBaseChar.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/type/HiveVarchar.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type /hive/trunk/common/src/test/org/apache/hadoop/hive/common/type/TestHiveVarchar.java /hive/trunk/data/files/datatypes.txt /hive/trunk/data/files/vc1.txt /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveLexer.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/CreateTableDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/ExprNodeConstantDesc.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/GenericUDFEncode.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFToString.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDAFComputeStats.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFBaseCompare.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFConcatWS.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFReflect2.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFStringToMap.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToDate.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFToVarchar.java /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFUtils.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_1.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_2.q /hive/trunk/ql/src/test/queries/clientnegative/invalid_varchar_length_3.q /hive/trunk/ql/src/test/queries/clientpositive/alter_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/ctas_varchar.q /hive/trunk/ql/src/test/queries/clientpositive/partition_varchar1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_2.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_cast.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_comparison.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_join1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_nested_types.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_udf1.q /hive/trunk/ql/src/test/queries/clientpositive/varchar_union1.q /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_1.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_2.q.out /hive/trunk/ql/src/test/results/clientnegative/invalid_varchar_length_3.q.out /hive/trunk/ql/src/test/results/clientpositive/alter_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/ctas_varchar.q.out /hive/trunk/ql/src/test/results/clientpositive/partition_varchar1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_2.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_cast.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_comparison.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_join1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_nested_types.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_udf1.q.out /hive/trunk/ql/src/test/results/clientpositive/varchar_union1.q.out /hive/trunk/serde/if/serde.thrift /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.cpp /hive/trunk/serde/src/gen/thrift/gen-cpp/serde_constants.h /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/serdeConstants.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde/test/ThriftTestObj.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/Complex.java /hive/trunk/serde/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/serde2/thrift/test/MegaStruct.java /hive/trunk/serde/src/gen/thrift/gen-php/org/apache/hadoop/hive/serde/Types.php /hive/trunk/serde/src/gen/thrift/gen-py/org_apache_hadoop_hive_serde/constants.py /hive/trunk/serde/src/gen/thrift/gen-rb/serde_constants.rb /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/SerDeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroObjectInspectorGenerator.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/binarysortable/BinarySortableSerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/DoubleWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/io/HiveVarcharWritable.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazy/objectinspector/primitive/LazyPrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryHiveVarchar.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinarySerDe.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/lazybinary/LazyBinaryUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorConverters.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/ObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/PrimitiveObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/HiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/JavaHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorConverter.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/PrimitiveObjectInspectorUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/SettableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableConstantHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/objectinspector/primitive/WritableHiveVarcharObjectInspector.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/ParameterizedPrimitiveTypeUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfo.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoFactory.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java /hive/trunk/serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/VarcharTypeParams.java /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo /hive/trunk/serde/src/test/org/apache/hadoop/hive/serde2/typeinfo/TestTypeInfoUtils.java
          Hide
          Jason Dere added a comment -

          attaching HIVE-4844.v12.1.patch, for use in 0.12 branch

          Show
          Jason Dere added a comment - attaching HIVE-4844 .v12.1.patch, for use in 0.12 branch
          Hide
          Thejas M Nair added a comment -

          Patch committed to 0.12 branch.

          Show
          Thejas M Nair added a comment - Patch committed to 0.12 branch.
          Hide
          Ashutosh Chauhan added a comment -

          This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          Show
          Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

            People

            • Assignee:
              Jason Dere
              Reporter:
              Jason Dere
            • Votes:
              0 Vote for this issue
              Watchers:
              13 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development