Hive
  1. Hive
  2. HIVE-4796

Increase coverage of package org.apache.hadoop.hive.common.metrics

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None
    1. HIVE-4796-trunk--N1.patch
      17 kB
      Ivan A. Veselovsky

      Activity

      Ashutosh Chauhan made changes -
      Status Resolved [ 5 ] Closed [ 6 ]
      Hide
      Ashutosh Chauhan added a comment -

      This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

      Show
      Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
      Hide
      Hudson added a comment -

      FAILURE: Integrated in Hive-trunk-hadoop2-ptest #14 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/14/)
      HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052)

      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Show
      Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #14 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/14/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 ) /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-hadoop2 #280 (See https://builds.apache.org/job/Hive-trunk-hadoop2/280/)
      HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052)

      Result = ABORTED
      hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052
      Files :

      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Show
      Hudson added a comment - Integrated in Hive-trunk-hadoop2 #280 (See https://builds.apache.org/job/Hive-trunk-hadoop2/280/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-h0.21 #2188 (See https://builds.apache.org/job/Hive-trunk-h0.21/2188/)
      HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052)

      Result = ABORTED
      hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052
      Files :

      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Show
      Hudson added a comment - Integrated in Hive-trunk-h0.21 #2188 (See https://builds.apache.org/job/Hive-trunk-h0.21/2188/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Hide
      Hudson added a comment -

      Integrated in Hive-trunk-hadoop1-ptest #49 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/49/)
      HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky) (Revision 1501052)

      Result = FAILURE
      hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052
      Files :

      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
      • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
      • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Show
      Hudson added a comment - Integrated in Hive-trunk-hadoop1-ptest #49 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/49/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky) (Revision 1501052) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
      Ashutosh Chauhan made changes -
      Status Patch Available [ 10002 ] Resolved [ 5 ]
      Fix Version/s 0.12.0 [ 12324312 ]
      Resolution Fixed [ 1 ]
      Hide
      Ashutosh Chauhan added a comment -

      Committed to trunk. Thanks, Ivan!

      Show
      Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Ivan!
      Hide
      Ashutosh Chauhan added a comment -

      +1

      Show
      Ashutosh Chauhan added a comment - +1
      Ivan A. Veselovsky made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Affects Version/s 0.12.0 [ 12324312 ]
      Affects Version/s 0.9.0 [ 12317742 ]
      Affects Version/s 0.10.0 [ 12320745 ]
      Affects Version/s 0.11.0 [ 12323587 ]
      Hide
      Ivan A. Veselovsky added a comment -

      Revisions other than trunk are removed since coverage fixes are accepted only for trunk.

      Show
      Ivan A. Veselovsky added a comment - Revisions other than trunk are removed since coverage fixes are accepted only for trunk.
      Hide
      Ivan A. Veselovsky added a comment -

      Ashutosh, thanks for the review. I answered you comments on the RB.

      Show
      Ivan A. Veselovsky added a comment - Ashutosh, thanks for the review. I answered you comments on the RB.
      Ashutosh Chauhan made changes -
      Status Patch Available [ 10002 ] Open [ 1 ]
      Affects Version/s 0.11.0 [ 12323587 ]
      Affects Version/s 0.10.0 [ 12320745 ]
      Affects Version/s 0.9.0 [ 12317742 ]
      Affects Version/s 0.12.0 [ 12324312 ]
      Hide
      Ashutosh Chauhan added a comment -

      Left some comments on RB.

      Show
      Ashutosh Chauhan added a comment - Left some comments on RB.
      Ivan A. Veselovsky made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Hide
      Ivan A. Veselovsky added a comment -
      Show
      Ivan A. Veselovsky added a comment - Hi, Ashutosh, sure: https://reviews.apache.org/r/12204/ .
      Ashutosh Chauhan made changes -
      Status Patch Available [ 10002 ] Open [ 1 ]
      Hide
      Ashutosh Chauhan added a comment -

      Can you create either ReviewBoard or phabricator entry for this?

      Show
      Ashutosh Chauhan added a comment - Can you create either ReviewBoard or phabricator entry for this?
      Ivan A. Veselovsky made changes -
      Status Open [ 1 ] Patch Available [ 10002 ]
      Affects Version/s 0.12.0 [ 12324312 ]
      Ivan A. Veselovsky made changes -
      Field Original Value New Value
      Attachment HIVE-4796-trunk--N1.patch [ 12590051 ]
      Hide
      Ivan A. Veselovsky added a comment -

      suggested patch elevates coverage of package o.a.h.hive.common.metrics from 61.1% to 82.1%.

      Show
      Ivan A. Veselovsky added a comment - suggested patch elevates coverage of package o.a.h.hive.common.metrics from 61.1% to 82.1%.
      Ivan A. Veselovsky created issue -

        People

        • Assignee:
          Ivan A. Veselovsky
          Reporter:
          Ivan A. Veselovsky
        • Votes:
          0 Vote for this issue
          Watchers:
          4 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development