Hive
  1. Hive
  2. HIVE-4796

Increase coverage of package org.apache.hadoop.hive.common.metrics

        Details

        • Type: Test Test
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 0.12.0
        • Fix Version/s: 0.12.0
        • Component/s: None
        • Labels:
          None
        1. Text File
          HIVE-4796-trunk--N1.patch
          17 kB
          Ivan A. Veselovsky

          Activity

          Ascending order - Click to sort in descending order
          Hide
          Permalink
          Ivan A. Veselovsky added a comment -

          suggested patch elevates coverage of package o.a.h.hive.common.metrics from 61.1% to 82.1%.

          Show
          Ivan A. Veselovsky added a comment - suggested patch elevates coverage of package o.a.h.hive.common.metrics from 61.1% to 82.1%.
          Hide
          Permalink
          Ashutosh Chauhan added a comment -

          Can you create either ReviewBoard or phabricator entry for this?

          Show
          Ashutosh Chauhan added a comment - Can you create either ReviewBoard or phabricator entry for this?
          Hide
          Permalink
          Ivan A. Veselovsky added a comment -

          Hi, Ashutosh,
          sure: https://reviews.apache.org/r/12204/ .

          Show
          Ivan A. Veselovsky added a comment - Hi, Ashutosh, sure: https://reviews.apache.org/r/12204/ .
          Hide
          Permalink
          Ashutosh Chauhan added a comment -

          Left some comments on RB.

          Show
          Ashutosh Chauhan added a comment - Left some comments on RB.
          Hide
          Permalink
          Ivan A. Veselovsky added a comment -

          Ashutosh, thanks for the review. I answered you comments on the RB.

          Show
          Ivan A. Veselovsky added a comment - Ashutosh, thanks for the review. I answered you comments on the RB.
          Hide
          Permalink
          Ivan A. Veselovsky added a comment -

          Revisions other than trunk are removed since coverage fixes are accepted only for trunk.

          Show
          Ivan A. Veselovsky added a comment - Revisions other than trunk are removed since coverage fixes are accepted only for trunk.
          Hide
          Permalink
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Permalink
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Ivan!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Ivan!
          Hide
          Permalink
          Hudson added a comment -

          Integrated in Hive-trunk-hadoop1-ptest #49 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/49/)
          HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky) (Revision 1501052)

          Result = FAILURE
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052
          Files :

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Show
          Hudson added a comment - Integrated in Hive-trunk-hadoop1-ptest #49 (See https://builds.apache.org/job/Hive-trunk-hadoop1-ptest/49/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky) (Revision 1501052) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Hide
          Permalink
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #2188 (See https://builds.apache.org/job/Hive-trunk-h0.21/2188/)
          HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052)

          Result = ABORTED
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052
          Files :

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #2188 (See https://builds.apache.org/job/Hive-trunk-h0.21/2188/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Hide
          Permalink
          Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #280 (See https://builds.apache.org/job/Hive-trunk-hadoop2/280/)
          HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052)

          Result = ABORTED
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052
          Files :

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Show
          Hudson added a comment - Integrated in Hive-trunk-hadoop2 #280 (See https://builds.apache.org/job/Hive-trunk-hadoop2/280/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1501052) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 Files : /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Hide
          Permalink
          Hudson added a comment -

          FAILURE: Integrated in Hive-trunk-hadoop2-ptest #14 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/14/)
          HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052)

          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java
          • /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics
          • /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Show
          Hudson added a comment - FAILURE: Integrated in Hive-trunk-hadoop2-ptest #14 (See https://builds.apache.org/job/Hive-trunk-hadoop2-ptest/14/ ) HIVE-4796 : Increase coverage of package org.apache.hadoop.hive.common.metrics (Ivan Veselovsky via Ashutosh Chauhan) (hashutosh: http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1501052 ) /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/Metrics.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBean.java /hive/trunk/common/src/java/org/apache/hadoop/hive/common/metrics/MetricsMBeanImpl.java /hive/trunk/common/src/test/org/apache/hadoop/hive/common /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics /hive/trunk/common/src/test/org/apache/hadoop/hive/common/metrics/TestMetrics.java
          Hide
          Permalink
          Ashutosh Chauhan added a comment -

          This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          Show
          Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

            People

            • Assignee:
              Ivan A. Veselovsky
              Reporter:
              Ivan A. Veselovsky
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development