Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: vectorization-branch
    • Fix Version/s: vectorization-branch, 0.13.0
    • Component/s: None
    • Labels:
      None
    1. HIVE-4794.1.patch
      1.15 MB
      Tony Murphy
    2. HIVE-4794.2.patch
      1.15 MB
      Tony Murphy
    3. HIVE-4794.3.patch
      1.15 MB
      Tony Murphy
    4. HIVE-4794.3-vectorization.patch
      1.15 MB
      Tony Murphy
    5. HIVE-4794.4-vectorization.patch
      1.16 MB
      Tony Murphy
    6. HIVE-4794.5-vectorization.patch
      1.16 MB
      Tony Murphy
    7. hive-4794.patch
      36 kB
      Tony Murphy

      Activity

      Hide
      Tony Murphy added a comment -

      does not contain output, as some queries are blocked by bugs.

      Show
      Tony Murphy added a comment - does not contain output, as some queries are blocked by bugs.
      Hide
      Tony Murphy added a comment -

      the patch depend on:
      HIVE-4525
      HIVE-4922
      HIVE-4931

      Show
      Tony Murphy added a comment - the patch depend on: HIVE-4525 HIVE-4922 HIVE-4931
      Show
      Tony Murphy added a comment - https://issues.apache.org/jira/browse/HIVE-4794
      Hide
      Edward Capriolo added a comment -

      Your not following http://uima.apache.org/codeConventions.html code conventions. Setup your IDE so it formats code properly and run ant check-style to see that your not adding checkstyle violations.

      Show
      Edward Capriolo added a comment - Your not following http://uima.apache.org/codeConventions.html code conventions. Setup your IDE so it formats code properly and run ant check-style to see that your not adding checkstyle violations.
      Hide
      Tony Murphy added a comment -

      updated for style fixes

      Show
      Tony Murphy added a comment - updated for style fixes
      Hide
      Tony Murphy added a comment -

      Thanks for the pointer and feedback Edward. I've updated the patch.

      Show
      Tony Murphy added a comment - Thanks for the pointer and feedback Edward. I've updated the patch.
      Show
      Tony Murphy added a comment - https://reviews.apache.org/r/13021/
      Hide
      Tony Murphy added a comment -

      Updated comments.

      Show
      Tony Murphy added a comment - Updated comments.
      Hide
      Tony Murphy added a comment -

      ran tests now that all dependent patches are in and merge with trunk complete. tests pass 100%.

      Show
      Tony Murphy added a comment - ran tests now that all dependent patches are in and merge with trunk complete. tests pass 100%.
      Hide
      Edward Capriolo added a comment -

      If you re-upload your patch according to the conventions

      https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing

      It should be auto-tested.

      Show
      Edward Capriolo added a comment - If you re-upload your patch according to the conventions https://cwiki.apache.org/confluence/display/Hive/Hive+PreCommit+Patch+Testing It should be auto-tested.
      Hide
      Tony Murphy added a comment -

      I ran the tests in the vectorization branch which just pulled from trunk. as far as i know we don't have precommit testing for branches yet.

      Show
      Tony Murphy added a comment - I ran the tests in the vectorization branch which just pulled from trunk. as far as i know we don't have precommit testing for branches yet.
      Hide
      Tony Murphy added a comment -

      fix patch format to get precommit patching

      Show
      Tony Murphy added a comment - fix patch format to get precommit patching
      Hide
      Hive QA added a comment -

      Overall: -1 at least one tests failed

      Here are the results of testing the latest attachment:
      https://issues.apache.org/jira/secure/attachment/12595252/HIVE-4794.3-vectorization.patch

      ERROR: -1 due to 16 failed/errored test(s), 3490 tests executed
      Failed tests:

      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input2
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter4
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_show_tables
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_add_part_exist
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter5
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input3
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_table_json
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter1
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_creation
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter3
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rename_column
      org.apache.hadoop.hive.cli.TestHBaseMinimrCliDriver.testCliDriver_hbase_bulk
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter2
      org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_index
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition
      

      Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/266/testReport
      Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/266/console

      Messages:

      Executing org.apache.hive.ptest.execution.PrepPhase
      Executing org.apache.hive.ptest.execution.ExecutionPhase
      Executing org.apache.hive.ptest.execution.ReportingPhase
      Tests failed with: TestsFailedException: 16 tests failed
      

      This message is automatically generated.

      Show
      Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12595252/HIVE-4794.3-vectorization.patch ERROR: -1 due to 16 failed/errored test(s), 3490 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_show_tables org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_add_part_exist org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_table_json org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_creation org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rename_column org.apache.hadoop.hive.cli.TestHBaseMinimrCliDriver.testCliDriver_hbase_bulk org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter2 org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_index org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/266/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/266/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 16 tests failed This message is automatically generated.
      Hide
      Hive QA added a comment -

      Overall: -1 at least one tests failed

      Here are the results of testing the latest attachment:
      https://issues.apache.org/jira/secure/attachment/12595252/HIVE-4794.3-vectorization.patch

      ERROR: -1 due to 16 failed/errored test(s), 3490 tests executed
      Failed tests:

      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input2
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter4
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_show_tables
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_add_part_exist
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter5
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input3
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_table_json
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter1
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_creation
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter3
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rename_column
      org.apache.hadoop.hive.cli.TestHBaseMinimrCliDriver.testCliDriver_hbase_bulk
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter2
      org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_index
      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition
      

      Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/267/testReport
      Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/267/console

      Messages:

      Executing org.apache.hive.ptest.execution.PrepPhase
      Executing org.apache.hive.ptest.execution.ExecutionPhase
      Executing org.apache.hive.ptest.execution.ReportingPhase
      Tests failed with: TestsFailedException: 16 tests failed
      

      This message is automatically generated.

      Show
      Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12595252/HIVE-4794.3-vectorization.patch ERROR: -1 due to 16 failed/errored test(s), 3490 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input2 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter4 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_show_tables org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_add_part_exist org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter5 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_input3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_describe_table_json org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter1 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_creation org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter3 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rename_column org.apache.hadoop.hive.cli.TestHBaseMinimrCliDriver.testCliDriver_hbase_bulk org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter2 org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_index org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_alter_rename_partition Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/267/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/267/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 16 tests failed This message is automatically generated.
      Hide
      Tony Murphy added a comment -

      Handled side effects in other tests (show table) of adding hive table.

      fix bug to always create the alltypesorc file in the local filesystem.

      Show
      Tony Murphy added a comment - Handled side effects in other tests (show table) of adding hive table. fix bug to always create the alltypesorc file in the local filesystem.
      Hide
      Hive QA added a comment -

      Overall: -1 at least one tests failed

      Here are the results of testing the latest attachment:
      https://issues.apache.org/jira/secure/attachment/12595463/HIVE-4794.4-vectorization.patch

      ERROR: -1 due to 3 failed/errored test(s), 3512 tests executed
      Failed tests:

      org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rename_column
      org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong
      org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_smb_mapjoin_8
      

      Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/277/testReport
      Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/277/console

      Messages:

      Executing org.apache.hive.ptest.execution.PrepPhase
      Executing org.apache.hive.ptest.execution.ExecutionPhase
      Executing org.apache.hive.ptest.execution.ReportingPhase
      Tests failed with: TestsFailedException: 3 tests failed
      

      This message is automatically generated.

      Show
      Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12595463/HIVE-4794.4-vectorization.patch ERROR: -1 due to 3 failed/errored test(s), 3512 tests executed Failed tests: org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_rename_column org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong org.apache.hadoop.hive.cli.TestMinimrCliDriver.testCliDriver_smb_mapjoin_8 Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/277/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/277/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 3 tests failed This message is automatically generated.
      Hide
      Tony Murphy added a comment -

      For some reason testCliDriver_rename_column didn't show up in the jenkins results. I've filed HIVE-4981 for it.

      I'm trying to get a repro for testCliDriver_smb_mapjoin_8. It didn't repro when run in isolation, so i've kicked off the entire suite to see if there's a dependency with another test that introduced this failure.

      Show
      Tony Murphy added a comment - For some reason testCliDriver_rename_column didn't show up in the jenkins results. I've filed HIVE-4981 for it. I'm trying to get a repro for testCliDriver_smb_mapjoin_8. It didn't repro when run in isolation, so i've kicked off the entire suite to see if there's a dependency with another test that introduced this failure.
      Hide
      Tony Murphy added a comment -

      Updated to add rename_column.

      I cannot get testCliDriver_smb_mapjoin_8 to repro, so i'm hoping the failure was transient. Otherwise, i'll need to try and get access to the hive log for the test run.

      testVectorUDFUnixTimeStampLong is unrelated to this change, and is being investigated independently.

      Show
      Tony Murphy added a comment - Updated to add rename_column. I cannot get testCliDriver_smb_mapjoin_8 to repro, so i'm hoping the failure was transient. Otherwise, i'll need to try and get access to the hive log for the test run. testVectorUDFUnixTimeStampLong is unrelated to this change, and is being investigated independently.
      Hide
      Hive QA added a comment -

      Overall: -1 at least one tests failed

      Here are the results of testing the latest attachment:
      https://issues.apache.org/jira/secure/attachment/12595629/HIVE-4794.5-vectorization.patch

      ERROR: -1 due to 1 failed/errored test(s), 3512 tests executed
      Failed tests:

      org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong
      

      Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/284/testReport
      Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/284/console

      Messages:

      Executing org.apache.hive.ptest.execution.PrepPhase
      Executing org.apache.hive.ptest.execution.ExecutionPhase
      Executing org.apache.hive.ptest.execution.ReportingPhase
      Tests failed with: TestsFailedException: 1 tests failed
      

      This message is automatically generated.

      Show
      Hive QA added a comment - Overall : -1 at least one tests failed Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12595629/HIVE-4794.5-vectorization.patch ERROR: -1 due to 1 failed/errored test(s), 3512 tests executed Failed tests: org.apache.hadoop.hive.ql.exec.vector.expressions.TestVectorTimestampExpressions.testVectorUDFUnixTimeStampLong Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/284/testReport Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/284/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase Tests failed with: TestsFailedException: 1 tests failed This message is automatically generated.
      Hide
      Tony Murphy added a comment -

      This patch should be good to go. HIVE-4971 covers the testVectorUDFUnixTimeStampLong failure.

      Show
      Tony Murphy added a comment - This patch should be good to go. HIVE-4971 covers the testVectorUDFUnixTimeStampLong failure.
      Hide
      Ashutosh Chauhan added a comment -

      Committed to branch. Thanks, Tony!

      Show
      Ashutosh Chauhan added a comment - Committed to branch. Thanks, Tony!
      Hide
      Teddy Choi added a comment -

      I was finding a way to test vectorized functionalities, and it solves my problem. I'm pretty impressed. Thanks!

      Show
      Teddy Choi added a comment - I was finding a way to test vectorized functionalities, and it solves my problem. I'm pretty impressed. Thanks!

        People

        • Assignee:
          Tony Murphy
          Reporter:
          Tony Murphy
        • Votes:
          0 Vote for this issue
          Watchers:
          5 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development