Hive
  1. Hive
  2. HIVE-4791

improve test coverage of package org.apache.hadoop.hive.ql.udf.xml

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.12.0
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      improve test coverage of package org.apache.hadoop.hive.ql.udf.xml to 80%.

        Activity

        Hide
        Edward Capriolo added a comment -

        How are you counting test coverage. The automated tools like cobertura do not 'understand' our *.q test format. Thus we have more coverage then these tools indicate. Maybe we can thing of a clever way to compile and run the q tests so we can see the true coverage.

        Show
        Edward Capriolo added a comment - How are you counting test coverage. The automated tools like cobertura do not 'understand' our *.q test format. Thus we have more coverage then these tools indicate. Maybe we can thing of a clever way to compile and run the q tests so we can see the true coverage.
        Hide
        Ivan A. Veselovsky added a comment -

        The patch adds 2 tests, what elevates the coverage of package o.a.h.hive.ql.udf.xml from 63.3% to 88%.

        Show
        Ivan A. Veselovsky added a comment - The patch adds 2 tests, what elevates the coverage of package o.a.h.hive.ql.udf.xml from 63.3% to 88%.
        Hide
        Ivan A. Veselovsky added a comment -

        Hi, Edward,
        we use Clover (http://www.atlassian.com/software/clover/overview/) to measure coverage.
        The patches that incorporate Clover in Hive builds are available there: https://issues.apache.org/jira/browse/HIVE-2991.
        (We use somewhat updated versions of those patches, will update the patches in that Jira soon.)
        Sure, Clover measures the Java code coverage only. But in Hive ordinary JUnit tests are generated by the given .q files (e.g. TestCliDriver.java), so the coverage of those queries can also be measured.

        Show
        Ivan A. Veselovsky added a comment - Hi, Edward, we use Clover ( http://www.atlassian.com/software/clover/overview/ ) to measure coverage. The patches that incorporate Clover in Hive builds are available there: https://issues.apache.org/jira/browse/HIVE-2991 . (We use somewhat updated versions of those patches, will update the patches in that Jira soon.) Sure, Clover measures the Java code coverage only. But in Hive ordinary JUnit tests are generated by the given .q files (e.g. TestCliDriver.java), so the coverage of those queries can also be measured.
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Ivan!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Ivan!
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #2170 (See https://builds.apache.org/job/Hive-trunk-h0.21/2170/)
        HIVE-4791 : improve test coverage of package org.apache.hadoop.hive.ql.udf.xml (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1498054)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498054
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/xml/UDFXPathUtil.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestReusableStringReader.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestUDFXPathUtil.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #2170 (See https://builds.apache.org/job/Hive-trunk-h0.21/2170/ ) HIVE-4791 : improve test coverage of package org.apache.hadoop.hive.ql.udf.xml (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1498054) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498054 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/xml/UDFXPathUtil.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestReusableStringReader.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestUDFXPathUtil.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #265 (See https://builds.apache.org/job/Hive-trunk-hadoop2/265/)
        HIVE-4791 : improve test coverage of package org.apache.hadoop.hive.ql.udf.xml (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1498054)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498054
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/xml/UDFXPathUtil.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestReusableStringReader.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestUDFXPathUtil.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #265 (See https://builds.apache.org/job/Hive-trunk-hadoop2/265/ ) HIVE-4791 : improve test coverage of package org.apache.hadoop.hive.ql.udf.xml (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1498054) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498054 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/xml/UDFXPathUtil.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestReusableStringReader.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/udf/xml/TestUDFXPathUtil.java
        Hide
        Ashutosh Chauhan added a comment -

        This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

        Show
        Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          People

          • Assignee:
            Ivan A. Veselovsky
            Reporter:
            Ivan A. Veselovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development