[HIVE-4757] LazyTimestamp goes into irretrievable NULL mode once inited with NULL once

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 0.12.0
• Fix Version/s: 0.12.0
• Component/s: Serializers/Deserializers
• Release Note: Fix bad isNull state for LazyTimestamp when encountering valid input after a NULL record.
• Assignee: Gopal Vijayaraghavan
• Reporter: Gopal Vijayaraghavan
• Created: 19/Jun/13 16:05
• Updated: 15/Oct/13 23:29
• Resolved: 01/Jul/13 17:25

Description

The LazyTimestamp.init() code turns into a NULL generator after parsing the very first NULL value (or format error).

The code is as follows

    Timestamp t = null;
    if (s.compareTo("NULL") == 0) {
      isNull = true;
      logExceptionMessage(bytes, start, length, "TIMESTAMP");
    } else {
      try {
        t = Timestamp.valueOf(s);
      } catch (IllegalArgumentException e) {
        isNull = true;
        logExceptionMessage(bytes, start, length, "TIMESTAMP");
      }
    }

As might be obvious from the code above, the class does not reset the isNull to false when a parse is successful.

So if by any reason, it is initialized with a NULL value, the LazyTimestamp.getObject() will always return NULL for all further rows.

Issue Links

• relates to: HIVE-5239 LazyDate goes into irretrievable NULL mode once inited with NULL once