Hive
  1. Hive
  2. HIVE-4743

Improve test coverage of package org.apache.hadoop.hive.ql.io

    Details

    • Type: Test Test
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.10.1, 0.11.1, 0.12.0
    • Fix Version/s: 0.12.0
    • Component/s: None
    • Labels:
      None

      Description

      The patch improves unit test coverage of package org.apache.hadoop.hive.ql.io up to 80%.

      1. HIVE-4743-trunk--N1.patch
        20 kB
        Ivan A. Veselovsky

        Activity

        Hide
        Ashutosh Chauhan added a comment -

        This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

        Show
        Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
        Hide
        Ashutosh Chauhan added a comment -

        We usually only backport critical bugfixes. IMO, this one doesn't fall into that category.

        Show
        Ashutosh Chauhan added a comment - We usually only backport critical bugfixes. IMO, this one doesn't fall into that category.
        Hide
        Ivan A. Veselovsky added a comment -

        Hi, Ashutosh, is that possible to commit this patch also into branches 0.10.1, 0.11.1?

        Show
        Ivan A. Veselovsky added a comment - Hi, Ashutosh, is that possible to commit this patch also into branches 0.10.1, 0.11.1?
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #252 (See https://builds.apache.org/job/Hive-trunk-hadoop2/252/)
        HIVE-4743 : Improve test coverage of package org.apache.hadoop.hive.ql.io (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1495462)

        Result = ABORTED
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1495462
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/NonSyncDataInputBuffer.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/PerformTestRCFileAndSeqFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveInputOutputBuffer.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestPerformTestRCFileAndSeqFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #252 (See https://builds.apache.org/job/Hive-trunk-hadoop2/252/ ) HIVE-4743 : Improve test coverage of package org.apache.hadoop.hive.ql.io (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1495462) Result = ABORTED hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1495462 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/NonSyncDataInputBuffer.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/PerformTestRCFileAndSeqFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveInputOutputBuffer.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestPerformTestRCFileAndSeqFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #2161 (See https://builds.apache.org/job/Hive-trunk-h0.21/2161/)
        HIVE-4743 : Improve test coverage of package org.apache.hadoop.hive.ql.io (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1495462)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1495462
        Files :

        • /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/NonSyncDataInputBuffer.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/PerformTestRCFileAndSeqFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveInputOutputBuffer.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestPerformTestRCFileAndSeqFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java
        • /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #2161 (See https://builds.apache.org/job/Hive-trunk-h0.21/2161/ ) HIVE-4743 : Improve test coverage of package org.apache.hadoop.hive.ql.io (Ivan Veselovsky via Ashutosh Chauhan) (Revision 1495462) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1495462 Files : /hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/io/NonSyncDataInputBuffer.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/PerformTestRCFileAndSeqFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestHiveInputOutputBuffer.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestPerformTestRCFileAndSeqFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestRCFile.java /hive/trunk/ql/src/test/org/apache/hadoop/hive/ql/io/TestSymlinkTextInputFormat.java
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Ivan!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Ivan!
        Hide
        Brock Noland added a comment -

        Nice, I love to see new unit test coverage!

        Show
        Brock Noland added a comment - Nice, I love to see new unit test coverage!
        Hide
        Ashutosh Chauhan added a comment -

        +1

        Show
        Ashutosh Chauhan added a comment - +1
        Hide
        Ivan A. Veselovsky added a comment -

        We measure coverage with Clover (http://www.atlassian.com/software/clover/overview).
        Clover integration with Hive described in https://issues.apache.org/jira/browse/HIVE-2991 .
        We use somewhat updated version of those changes, will update the patches in 2991 soon.

        Show
        Ivan A. Veselovsky added a comment - We measure coverage with Clover ( http://www.atlassian.com/software/clover/overview ). Clover integration with Hive described in https://issues.apache.org/jira/browse/HIVE-2991 . We use somewhat updated version of those changes, will update the patches in 2991 soon.
        Hide
        Ashutosh Chauhan added a comment -

        Ivan A. Veselovsky How are you measuring test coverage ?

        Show
        Ashutosh Chauhan added a comment - Ivan A. Veselovsky How are you measuring test coverage ?
        Hide
        Ivan A. Veselovsky added a comment -

        The patch intended to be applied to branches trunk, 0.11, 0.10.

        Show
        Ivan A. Veselovsky added a comment - The patch intended to be applied to branches trunk, 0.11, 0.10.

          People

          • Assignee:
            Ivan A. Veselovsky
            Reporter:
            Ivan A. Veselovsky
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development