Hive
  1. Hive
  2. HIVE-4559

hcatalog/webhcat scripts in tar.gz don't have execute permissions set

    Details

      Description

      After running 'package' target in hive, the sbin/bin files in the package directory created for hcatalog and webhcat don't have execute permissions.

      $ ls -l build/dist/hcatalog/bin/
      total 16
      -rw-r--r--  1 thejas  staff  5517 May 14 18:18 hcat
      
      
      $ ls -l build/dist/hcatalog/sbin/
      total 64
      -rw-r--r--  1 thejas  staff   4540 May 14 18:18 hcat_server.sh
      -rw-r--r--  1 thejas  staff  10013 May 14 18:18 update-hcatalog-env.sh
      -rw-r--r--  1 thejas  staff   2996 May 14 18:18 webhcat_config.sh
      -rw-r--r--  1 thejas  staff   7136 May 14 18:18 webhcat_server.sh
      
      
      1. HIVE-4559.patch
        1 kB
        Eugene Koifman

        Activity

        Thejas M Nair created issue -
        Eugene Koifman made changes -
        Field Original Value New Value
        Assignee Eugene Koifman [ ekoifman ]
        Hide
        Eugene Koifman added a comment -

        HIVE-4559.patch has 2 changes:
        1. when copying hcatalog/build tree to dist/hcatalog, set execute bit which ant copy task loses
        2. when calling hives 'ant binary' to create .tar.gz, make sure HCat shell scripts have execute bit set.

        Tested with ant clean package binary at hive/ level. All x bits are there.

        Show
        Eugene Koifman added a comment - HIVE-4559 .patch has 2 changes: 1. when copying hcatalog/build tree to dist/hcatalog, set execute bit which ant copy task loses 2. when calling hives 'ant binary' to create .tar.gz, make sure HCat shell scripts have execute bit set. Tested with ant clean package binary at hive/ level. All x bits are there.
        Eugene Koifman made changes -
        Attachment HIVE-4559.patch [ 12590117 ]
        Eugene Koifman made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Ashutosh Chauhan added a comment -

        I am not sure how ant directive chmod works on windows. But since there is already a chmod in build.xml which doesnt fail the build on windows, I assume adding another one should be fine. Anyways, perms for these files are non-relevant for windows. But, do we need to worry about similar perms issue for windows script files?
        Proceeding with commit for this patch, since above issues (if any) can be dealt with in a follow-up.

        Show
        Ashutosh Chauhan added a comment - I am not sure how ant directive chmod works on windows. But since there is already a chmod in build.xml which doesnt fail the build on windows, I assume adding another one should be fine. Anyways, perms for these files are non-relevant for windows. But, do we need to worry about similar perms issue for windows script files? Proceeding with commit for this patch, since above issues (if any) can be dealt with in a follow-up.
        Hide
        Ashutosh Chauhan added a comment -

        Committed to trunk. Thanks, Eugene!

        Show
        Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Eugene!
        Ashutosh Chauhan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 0.12.0 [ 12324312 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-h0.21 #2171 (See https://builds.apache.org/job/Hive-trunk-h0.21/2171/)
        HIVE-4559 : hcatalog/webhcat scripts in tar.gz don't have execute permissions set (Eugene Koifman via Ashutosh Chauhan) (Revision 1498156)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498156
        Files :

        • /hive/trunk/build.xml
        Show
        Hudson added a comment - Integrated in Hive-trunk-h0.21 #2171 (See https://builds.apache.org/job/Hive-trunk-h0.21/2171/ ) HIVE-4559 : hcatalog/webhcat scripts in tar.gz don't have execute permissions set (Eugene Koifman via Ashutosh Chauhan) (Revision 1498156) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498156 Files : /hive/trunk/build.xml
        Hide
        Hudson added a comment -

        Integrated in Hive-trunk-hadoop2 #266 (See https://builds.apache.org/job/Hive-trunk-hadoop2/266/)
        HIVE-4559 : hcatalog/webhcat scripts in tar.gz don't have execute permissions set (Eugene Koifman via Ashutosh Chauhan) (Revision 1498156)

        Result = FAILURE
        hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498156
        Files :

        • /hive/trunk/build.xml
        Show
        Hudson added a comment - Integrated in Hive-trunk-hadoop2 #266 (See https://builds.apache.org/job/Hive-trunk-hadoop2/266/ ) HIVE-4559 : hcatalog/webhcat scripts in tar.gz don't have execute permissions set (Eugene Koifman via Ashutosh Chauhan) (Revision 1498156) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1498156 Files : /hive/trunk/build.xml
        Hide
        Ashutosh Chauhan added a comment -

        This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

        Show
        Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
        Ashutosh Chauhan made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Eugene Koifman
            Reporter:
            Thejas M Nair
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development