Hive
  1. Hive
  2. HIVE-4508

Make minor changes to README and NOTICE files.

    Details

    • Type: Task Task
    • Status: Reopened
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None

      Description

      Various trivial changes to README files.

      1. h-4508.patch
        24 kB
        Owen O'Malley
      2. h-4508.patch
        24 kB
        Owen O'Malley
      3. overview.html
        4 kB
        Lefty Leverenz

        Issue Links

          Activity

          Hide
          Owen O'Malley added a comment -

          I'm splitting up this work into separate parts and will do the release notes separately.

          Show
          Owen O'Malley added a comment - I'm splitting up this work into separate parts and will do the release notes separately.
          Hide
          Lefty Leverenz added a comment -

          Attaching an overview.html file that can be included in the API docs.

          Show
          Lefty Leverenz added a comment - Attaching an overview.html file that can be included in the API docs.
          Hide
          Lefty Leverenz added a comment -

          Changes to docs/xdocs/index.xml won't have any effect, because the xdocs are dead (long live the wiki). The information is duplicated, more or less, on the wiki home page and in the tutorial.

          If you want to add the same information to the API docs, put an html file in an appropriate location such as ./docs/overview.html, and add a line to the javadoc target in build.xml, like so:

          <target name="javadoc" depends="package" description="Generate Javadoc">
          <echo message="Project: ${ant.project.name}"/>
          <mkdir dir="${build.javadoc}"/>
          <javadoc
          overview="${basedir}/docs/overview.html"

          ... but without the backslashes that you'll probably see in email. I created an overview.html file including Carl's suggestions and a few editorial fixes (attached) so you just have to put it in ./docs and add the overview line to build.xml.

          Show
          Lefty Leverenz added a comment - Changes to docs/xdocs/index.xml won't have any effect, because the xdocs are dead (long live the wiki). The information is duplicated, more or less, on the wiki home page and in the tutorial. If you want to add the same information to the API docs, put an html file in an appropriate location such as ./docs/overview.html, and add a line to the javadoc target in build.xml, like so: <target name="javadoc" depends="package" description="Generate Javadoc"> <echo message="Project: ${ant.project.name}"/> <mkdir dir="${build.javadoc}"/> <javadoc overview="${basedir}/docs/overview.html" ... but without the backslashes that you'll probably see in email. I created an overview.html file including Carl's suggestions and a few editorial fixes (attached) so you just have to put it in ./docs and add the overview line to build.xml.
          Hide
          Carl Steinbach added a comment -
          Show
          Carl Steinbach added a comment - Review request: https://reviews.apache.org/r/11030/
          Hide
          Owen O'Malley added a comment -

          Can you please post a review request for this patch?

          No, there is no need for me to push it into arc. Just review either the patch or browse it from git:
          https://github.com/apache/hive/commit/5364dd83cd6a0adb5b31e3275888e2cbd7608ed4

          Fixing the release notes is the only important part of the patch. You requested a bunch of changes and I did the work. I don't understand why you are being so argumentative about work that you requested.

          I noticed a couple other issues in the affected files that should be fixed before this patch is forward-ported to trunk

          Please file a new jira and include a patch. I'll review it promptly.

          Show
          Owen O'Malley added a comment - Can you please post a review request for this patch? No, there is no need for me to push it into arc. Just review either the patch or browse it from git: https://github.com/apache/hive/commit/5364dd83cd6a0adb5b31e3275888e2cbd7608ed4 Fixing the release notes is the only important part of the patch. You requested a bunch of changes and I did the work. I don't understand why you are being so argumentative about work that you requested. I noticed a couple other issues in the affected files that should be fixed before this patch is forward-ported to trunk Please file a new jira and include a patch. I'll review it promptly.
          Hide
          Carl Steinbach added a comment -

          Here's what the HowToRelease page says:

          1. You probably also want to commit a patch (on both trunk and branch) which updates README.txt to bring it up to date (at a minimum, search+replacing references to the version number). Also check NOTICE to see if anything needs to be updated for recent library dependency changes or additions.
            1. Select all of the JIRA's for the current release that aren't FIXED and do bulk update to clear the 'Fixed Version' field.
            2. Likewise, use JIRA's Release Notes link to generate content for the RELEASE_NOTES.txt file. Be sure to select 'Text' format. (It's OK to do this with a direct commit rather than a patch.)

          The narrow interpretation of this is that you are only allowed to commit changes to RELEASE_NOTES.txt without a +1, and I believe that is the actual intent since those changes are purely mechanical. I can understand how someone could read this and conclude that the policy also extends to README.txt, NOTICE, and build.properties, but it's easy to verify that this isn't the case by looking at the comments in the commit log. That still leaves two files that were modified in the patch which aren't mentioned anywhere on the HowToRelease page.

          Can you please post a review request for this patch? I noticed a couple other issues in the affected files that should be fixed before this patch is forward-ported to trunk. Thanks.

          Show
          Carl Steinbach added a comment - Here's what the HowToRelease page says: You probably also want to commit a patch (on both trunk and branch) which updates README.txt to bring it up to date (at a minimum, search+replacing references to the version number). Also check NOTICE to see if anything needs to be updated for recent library dependency changes or additions. Select all of the JIRA's for the current release that aren't FIXED and do bulk update to clear the 'Fixed Version' field. Likewise, use JIRA's Release Notes link to generate content for the RELEASE_NOTES.txt file. Be sure to select 'Text' format. (It's OK to do this with a direct commit rather than a patch.) The narrow interpretation of this is that you are only allowed to commit changes to RELEASE_NOTES.txt without a +1, and I believe that is the actual intent since those changes are purely mechanical. I can understand how someone could read this and conclude that the policy also extends to README.txt, NOTICE, and build.properties, but it's easy to verify that this isn't the case by looking at the comments in the commit log. That still leaves two files that were modified in the patch which aren't mentioned anywhere on the HowToRelease page. Can you please post a review request for this patch? I noticed a couple other issues in the affected files that should be fixed before this patch is forward-ported to trunk. Thanks.
          Hide
          Owen O'Malley added a comment -

          Owen, which files did you edit in this patch?

          The change is in the attached patch obviously. If you want to generate it from git:

          % git show --numstat 5364dd83cd6a0adb5b31e3275888e2cbd7608ed4
          

          The result shows that:

          commit 5364dd83cd6a0adb5b31e3275888e2cbd7608ed4
          Author: Owen O'Malley <omalley@apache.org>
          Date:   Tue May 7 15:09:18 2013 +0000
          
              HIVE-4508 Update release notes for Hive 0.11.0.
              
              
              git-svn-id: https://svn.apache.org/repos/asf/hive/branches/branch-0.11@1479935 13f79535-47bb-03
          
          1       1       NOTICE
          4       8       README.txt
          18      61      RELEASE_NOTES.txt
          1       1       build.properties
          1       1       docs/xdocs/index.xml
          1       1       eclipse-templates/.classpath
          

          which are precisely the set of changes that you asked for in the email thread.

          Show
          Owen O'Malley added a comment - Owen, which files did you edit in this patch? The change is in the attached patch obviously. If you want to generate it from git: % git show --numstat 5364dd83cd6a0adb5b31e3275888e2cbd7608ed4 The result shows that: commit 5364dd83cd6a0adb5b31e3275888e2cbd7608ed4 Author: Owen O'Malley <omalley@apache.org> Date: Tue May 7 15:09:18 2013 +0000 HIVE-4508 Update release notes for Hive 0.11.0. git-svn-id: https: //svn.apache.org/repos/asf/hive/branches/branch-0.11@1479935 13f79535-47bb-03 1 1 NOTICE 4 8 README.txt 18 61 RELEASE_NOTES.txt 1 1 build.properties 1 1 docs/xdocs/index.xml 1 1 eclipse-templates/.classpath which are precisely the set of changes that you asked for in the email thread.
          Hide
          Carl Steinbach added a comment -

          The HowToRelease wiki for Hive (https://cwiki.apache.org/Hive/howtorelease.html) about editing the release notes: "It's OK to do this with a direct commit rather than a patch."

          Owen, which files did you edit in this patch?

          Show
          Carl Steinbach added a comment - The HowToRelease wiki for Hive ( https://cwiki.apache.org/Hive/howtorelease.html ) about editing the release notes: "It's OK to do this with a direct commit rather than a patch." Owen, which files did you edit in this patch?
          Hide
          Owen O'Malley added a comment -

          Not true. You need an explicit +1 from another committer, and we do usually file JIRAs for stuff like this.

          The HowToRelease wiki for Hive (https://cwiki.apache.org/Hive/howtorelease.html) about editing the release notes: "It's OK to do this with a direct commit rather than a patch."

          Also, most of the changes in this patch need to get committed to trunk as well.

          You're right about that.

          Show
          Owen O'Malley added a comment - Not true. You need an explicit +1 from another committer, and we do usually file JIRAs for stuff like this. The HowToRelease wiki for Hive ( https://cwiki.apache.org/Hive/howtorelease.html ) about editing the release notes: "It's OK to do this with a direct commit rather than a patch." Also, most of the changes in this patch need to get committed to trunk as well. You're right about that.
          Hide
          Carl Steinbach added a comment -

          Owen O'Malley

          I assume that I don't need an explicit +1 from anyone since we don't normally file a jira for this stuff.

          Not true. You need an explicit +1 from another committer, and we do usually file JIRAs for stuff like this. Also, most of the changes in this patch need to get committed to trunk as well.

          I wanted to give the community to see the chance to see the changes before they were committed.

          That's what reviewboard and phabricator are for. Please reopen this ticket and follow the process described here:

          https://cwiki.apache.org/confluence/display/Hive/HowToCommit (Note that I updated this page a minute ago in order to reconcile it with the Hive Bylaws).

          Show
          Carl Steinbach added a comment - Owen O'Malley I assume that I don't need an explicit +1 from anyone since we don't normally file a jira for this stuff. Not true. You need an explicit +1 from another committer, and we do usually file JIRAs for stuff like this. Also, most of the changes in this patch need to get committed to trunk as well. I wanted to give the community to see the chance to see the changes before they were committed. That's what reviewboard and phabricator are for. Please reopen this ticket and follow the process described here: https://cwiki.apache.org/confluence/display/Hive/HowToCommit (Note that I updated this page a minute ago in order to reconcile it with the Hive Bylaws).
          Hide
          Owen O'Malley added a comment -

          I committed this to branch-11. (I assume that I don't need an explicit +1 from anyone since we don't normally file a jira for this stuff. I wanted to give the community to see the chance to see the changes before they were committed.) I'll regenerate the RELEASE_NOTES just before I make rc2 so that new jiras are reflected.

          Show
          Owen O'Malley added a comment - I committed this to branch-11. (I assume that I don't need an explicit +1 from anyone since we don't normally file a jira for this stuff. I wanted to give the community to see the chance to see the changes before they were committed.) I'll regenerate the RELEASE_NOTES just before I make rc2 so that new jiras are reflected.
          Hide
          Owen O'Malley added a comment -

          Removed paragraph about replacing hive-default.xml.

          Show
          Owen O'Malley added a comment - Removed paragraph about replacing hive-default.xml.
          Hide
          Owen O'Malley added a comment -

          This fixes the issues that Carl identified.

          Show
          Owen O'Malley added a comment - This fixes the issues that Carl identified.
          Hide
          Chris Drome added a comment -

          HIVE-4496 fixes the build issue with JDBC2 and JDK1.7.

          Show
          Chris Drome added a comment - HIVE-4496 fixes the build issue with JDBC2 and JDK1.7.

            People

            • Assignee:
              Carl Steinbach
              Reporter:
              Owen O'Malley
            • Votes:
              0 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:

                Development