Hive
  1. Hive
  2. HIVE-445

Upgrade JPOX to datanuclues plugins

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.4.0
    • Fix Version/s: 0.4.0
    • Component/s: Metastore
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      HIVE-445. Upgrade JPOX to datanuclues plugins. (Prasad Chakka via zshao)

      Description

      JPOX is renamed as datanucleus and there have been lot of changes to the class names and jars. If we want any improvements we need to migrate to the new version.

      1. hive-445.4.patch
        93 kB
        Prasad Chakka
      2. hive-445.3.patch
        93 kB
        Prasad Chakka
      3. hive-445.2.patch
        3 kB
        Prasad Chakka
      4. datanucleus-rdbms-1.1.2.jar
        1.10 MB
        Prasad Chakka
      5. jdo2-api-2.3-SNAPSHOT.jar
        175 kB
        Prasad Chakka
      6. datanucleus-enhancer-1.1.2.jar
        172 kB
        Prasad Chakka
      7. datanucleus-core-1.1.2.jar
        1.82 MB
        Prasad Chakka
      8. hive-445.patch
        92 kB
        Prasad Chakka

        Issue Links

          Activity

          Hide
          Prasad Chakka added a comment -

          There are some instructions here on the bottom of this link
          http://www.datanucleus.org/products/accessplatform_1_0/migration.html

          Show
          Prasad Chakka added a comment - There are some instructions here on the bottom of this link http://www.datanucleus.org/products/accessplatform_1_0/migration.html
          Show
          Prasad Chakka added a comment - http://www.datanucleus.org/products/accessplatform_1_1/migration.html
          Hide
          Prasad Chakka added a comment -

          patch to upgrade.. everything seems to work fine except that the model enhancer is run through special ant target which has to be supplied from commandline using ant -lib lib/datanucleus-enhancer-1.1.2.jar which can be a pain. need to find a way to do this better.

          Show
          Prasad Chakka added a comment - patch to upgrade.. everything seems to work fine except that the model enhancer is run through special ant target which has to be supplied from commandline using ant -lib lib/datanucleus-enhancer-1.1.2.jar which can be a pain. need to find a way to do this better.
          Hide
          Prasad Chakka added a comment -

          jpox-*.jar and jdo2-api-2.1.jar should be removed

          Show
          Prasad Chakka added a comment - jpox-*.jar and jdo2-api-2.1.jar should be removed
          Hide
          Prasad Chakka added a comment -

          this fixes the classpath issue

          Show
          Prasad Chakka added a comment - this fixes the classpath issue
          Hide
          Zheng Shao added a comment -

          Talked with Prasad offline. Prasad will do more tests before this will be committed.

          Show
          Zheng Shao added a comment - Talked with Prasad offline. Prasad will do more tests before this will be committed.
          Hide
          Prasad Chakka added a comment -

          all unit tests pass but i have not yet tested this for backward compatibility. otherwise it is good

          Show
          Prasad Chakka added a comment - all unit tests pass but i have not yet tested this for backward compatibility. otherwise it is good
          Hide
          Prasad Chakka added a comment -

          we need latest version of jpox to change locations easily. with current version i am hitting a bug in jpox that is fixed in the latest version.

          Show
          Prasad Chakka added a comment - we need latest version of jpox to change locations easily. with current version i am hitting a bug in jpox that is fixed in the latest version.
          Hide
          Prasad Chakka added a comment -

          can any one check this in?

          Show
          Prasad Chakka added a comment - can any one check this in?
          Hide
          Zheng Shao added a comment -

          HIVE-445.2.patch is generate from metastore directory not the root.

          Also HIVE-445.2 patch contains some of the changes of HIVE-445.patch. I am seeing:

          [zshao@ xxx] patch -p0 -i ../hive-445.2.patch
          patching file src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java
          Reversed (or previously applied) patch detected! Assume -R? [n]

          Show
          Zheng Shao added a comment - HIVE-445 .2.patch is generate from metastore directory not the root. Also HIVE-445 .2 patch contains some of the changes of HIVE-445 .patch. I am seeing: [zshao@ xxx] patch -p0 -i ../hive-445.2.patch patching file src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java Reversed (or previously applied) patch detected! Assume -R? [n]
          Hide
          Prasad Chakka added a comment -

          ok will upload patch soon

          Show
          Prasad Chakka added a comment - ok will upload patch soon
          Hide
          Prasad Chakka added a comment -

          need to specify '-lib ./lib' option to ant to compile

          Show
          Prasad Chakka added a comment - need to specify '-lib ./lib' option to ant to compile
          Hide
          Prasad Chakka added a comment -

          this patch doesn't require the -lib option.

          Show
          Prasad Chakka added a comment - this patch doesn't require the -lib option.
          Hide
          Zheng Shao added a comment -

          Just to double check: hive-445.4.patch and all jars are what we want. Correct?

          Show
          Zheng Shao added a comment - Just to double check: hive-445.4.patch and all jars are what we want. Correct?
          Hide
          Prasad Chakka added a comment -

          yes.

          Show
          Prasad Chakka added a comment - yes.
          Hide
          Zheng Shao added a comment -

          Committed. Thanks Prasad.

          Show
          Zheng Shao added a comment - Committed. Thanks Prasad.

            People

            • Assignee:
              Prasad Chakka
              Reporter:
              Prasad Chakka
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development