Hive
  1. Hive
  2. HIVE-4417

Make unit tests pass on Windows which use Linux script in query files

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.13.0
    • Component/s: Tests
    • Labels:
      None
    • Environment:

      Windows 8

      Description

      Make unit tests input20.q, input33.q in TestCliDriver working on both Linux and Windows by implementing "input20_script" in python. Also make newline.q working on Windows by using "cat" in consistent way in query file.

      1. HIVE-4417.2.patch
        16 kB
        Jason Dere
      2. HIVE-4417.1.patch
        20 kB
        Shuaishuai Nie

        Issue Links

          Activity

          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          14m 54s 1 Shuaishuai Nie 24/Apr/13 21:50
          Patch Available Patch Available Resolved Resolved
          240d 2h 15m 1 Ashutosh Chauhan 20/Dec/13 23:06
          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.13.0 [ 12324986 ]
          Resolution Fixed [ 1 ]
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Shauishuai & Jason!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Shauishuai & Jason!
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Shuaishuai Nie added a comment -

          Thank Jason Dere for re-basing the patch.

          Show
          Shuaishuai Nie added a comment - Thank Jason Dere for re-basing the patch.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12619641/HIVE-4417.2.patch

          SUCCESS: +1 4795 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12619641

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12619641/HIVE-4417.2.patch SUCCESS: +1 4795 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12619641
          Jason Dere made changes -
          Attachment HIVE-4417.2.patch [ 12619641 ]
          Hide
          Jason Dere added a comment -

          Converted diff file to unix format and rebased with trunk.

          Show
          Jason Dere added a comment - Converted diff file to unix format and rebased with trunk.
          Shuaishuai Nie made changes -
          Link This issue is part of HIVE-2998 [ HIVE-2998 ]
          Hide
          Shuaishuai Nie added a comment -

          Fixed unit tests in HIVE-4417.1.patch
          1. input20.q
          2. input33.q
          3. newline.q

          Show
          Shuaishuai Nie added a comment - Fixed unit tests in HIVE-4417 .1.patch 1. input20.q 2. input33.q 3. newline.q
          Shuaishuai Nie made changes -
          Summary Make unit tests input20.q, input33.q, newline.q in TestCliDriver working on both Linux and Windows Make unit tests pass on Windows which use Linux script in query files
          Shuaishuai Nie made changes -
          Description Make unit tests input20.q, input33.q in TestCliDriver working on Windows by implementing "input20_script" in python. Also make newline.q working on Windows by using "cat" in consistent way in query file. Make unit tests input20.q, input33.q in TestCliDriver working on both Linux and Windows by implementing "input20_script" in python. Also make newline.q working on Windows by using "cat" in consistent way in query file.
          Shuaishuai Nie made changes -
          Summary Make unit tests input20.q, input33.q, newline.q in TestCliDriver working on Windows Make unit tests input20.q, input33.q, newline.q in TestCliDriver working on both Linux and Windows
          Shuaishuai Nie made changes -
          Attachment HIVE-4417.1.patch [ 12580550 ]
          Hide
          Shuaishuai Nie added a comment -

          The review is available at https://reviews.apache.org/r/10783/

          Show
          Shuaishuai Nie added a comment - The review is available at https://reviews.apache.org/r/10783/
          Shuaishuai Nie made changes -
          Attachment HIVE-4417.patch [ 12580372 ]
          Shuaishuai Nie made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Shuaishuai Nie made changes -
          Attachment HIVE-4417.patch [ 12580372 ]
          Shuaishuai Nie made changes -
          Attachment HIVE-4417.patch [ 12580371 ]
          Shuaishuai Nie made changes -
          Field Original Value New Value
          Attachment HIVE-4417.patch [ 12580371 ]
          Shuaishuai Nie created issue -

            People

            • Assignee:
              Shuaishuai Nie
              Reporter:
              Shuaishuai Nie
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development