Hive
  1. Hive
  2. HIVE-4417

Make unit tests pass on Windows which use Linux script in query files

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.11.0
    • Fix Version/s: 0.13.0
    • Component/s: Tests
    • Labels:
      None
    • Environment:

      Windows 8

      Description

      Make unit tests input20.q, input33.q in TestCliDriver working on both Linux and Windows by implementing "input20_script" in python. Also make newline.q working on Windows by using "cat" in consistent way in query file.

      1. HIVE-4417.1.patch
        20 kB
        Shuaishuai Nie
      2. HIVE-4417.2.patch
        16 kB
        Jason Dere

        Issue Links

          Activity

          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Shauishuai & Jason!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Shauishuai & Jason!
          Hide
          Ashutosh Chauhan added a comment -

          +1

          Show
          Ashutosh Chauhan added a comment - +1
          Hide
          Shuaishuai Nie added a comment -

          Thank Jason Dere for re-basing the patch.

          Show
          Shuaishuai Nie added a comment - Thank Jason Dere for re-basing the patch.
          Hide
          Hive QA added a comment -

          Overall: +1 all checks pass

          Here are the results of testing the latest attachment:
          https://issues.apache.org/jira/secure/attachment/12619641/HIVE-4417.2.patch

          SUCCESS: +1 4795 tests passed

          Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/testReport
          Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/console

          Messages:

          Executing org.apache.hive.ptest.execution.PrepPhase
          Executing org.apache.hive.ptest.execution.ExecutionPhase
          Executing org.apache.hive.ptest.execution.ReportingPhase
          

          This message is automatically generated.

          ATTACHMENT ID: 12619641

          Show
          Hive QA added a comment - Overall : +1 all checks pass Here are the results of testing the latest attachment: https://issues.apache.org/jira/secure/attachment/12619641/HIVE-4417.2.patch SUCCESS: +1 4795 tests passed Test results: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/testReport Console output: http://bigtop01.cloudera.org:8080/job/PreCommit-HIVE-Build/707/console Messages: Executing org.apache.hive.ptest.execution.PrepPhase Executing org.apache.hive.ptest.execution.ExecutionPhase Executing org.apache.hive.ptest.execution.ReportingPhase This message is automatically generated. ATTACHMENT ID: 12619641
          Hide
          Jason Dere added a comment -

          Converted diff file to unix format and rebased with trunk.

          Show
          Jason Dere added a comment - Converted diff file to unix format and rebased with trunk.
          Hide
          Shuaishuai Nie added a comment -

          Fixed unit tests in HIVE-4417.1.patch
          1. input20.q
          2. input33.q
          3. newline.q

          Show
          Shuaishuai Nie added a comment - Fixed unit tests in HIVE-4417 .1.patch 1. input20.q 2. input33.q 3. newline.q
          Hide
          Shuaishuai Nie added a comment -

          The review is available at https://reviews.apache.org/r/10783/

          Show
          Shuaishuai Nie added a comment - The review is available at https://reviews.apache.org/r/10783/

            People

            • Assignee:
              Shuaishuai Nie
              Reporter:
              Shuaishuai Nie
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development