Details

    • Type: Sub-task Sub-task
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: vectorization-branch, 0.13.0
    • Component/s: None
    • Labels:
      None

      Description

      Create patch for implementing string columns compared with scalars as vectorized filters, and apply it to vectorization branch.

      1. HIVE-4383.1.patch
        44 kB
        Eric Hanson
      2. HIVE-4383.2.patch
        37 kB
        Eric Hanson
      3. HIVE-4383.3.patch
        46 kB
        Eric Hanson
      4. HIVE-4384.4.patch
        45 kB
        Eric Hanson

        Activity

        Hide
        Eric Hanson added a comment -

        This patch depends on HIVE-4384. 4384 should go in first. This patch (4383) fixes style guideline issues in the first patch in the Junit test (TestVectorStringExpressions.java).

        Once 4384 goes in I'll create a ReviewBoard entry for review.

        Show
        Eric Hanson added a comment - This patch depends on HIVE-4384 . 4384 should go in first. This patch (4383) fixes style guideline issues in the first patch in the Junit test (TestVectorStringExpressions.java). Once 4384 goes in I'll create a ReviewBoard entry for review.
        Hide
        Eric Hanson added a comment -

        Code review available at https://reviews.apache.org/r/10785/

        Show
        Eric Hanson added a comment - Code review available at https://reviews.apache.org/r/10785/
        Hide
        Eric Hanson added a comment -

        Apply to vectorization branch

        Show
        Eric Hanson added a comment - Apply to vectorization branch
        Hide
        Eric Hanson added a comment -

        slightly updated patch to handle changes to CodeGen.java from Jitendra's unary minus patch, to avoid conflicts.

        Also, updated build files to avoid windows build issue

        Show
        Eric Hanson added a comment - slightly updated patch to handle changes to CodeGen.java from Jitendra's unary minus patch, to avoid conflicts. Also, updated build files to avoid windows build issue
        Hide
        Ashutosh Chauhan added a comment -

        Patch is not applying cleanly on branch. Can you please rebase it?

        Show
        Ashutosh Chauhan added a comment - Patch is not applying cleanly on branch. Can you please rebase it?
        Hide
        Eric Hanson added a comment -

        Updated patch to apply to current version of public vectorization branch

        Show
        Eric Hanson added a comment - Updated patch to apply to current version of public vectorization branch
        Hide
        Eric Hanson added a comment -

        Code review available at https://reviews.apache.org/r/10840/

        Show
        Eric Hanson added a comment - Code review available at https://reviews.apache.org/r/10840/
        Hide
        Eric Hanson added a comment -

        removed changes related to 4348 (unit test compile failure)

        Show
        Eric Hanson added a comment - removed changes related to 4348 (unit test compile failure)
        Hide
        Ashutosh Chauhan added a comment -

        Committed to branch. Thanks, Eric!

        Show
        Ashutosh Chauhan added a comment - Committed to branch. Thanks, Eric!

          People

          • Assignee:
            Eric Hanson
            Reporter:
            Eric Hanson
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development