Hive
  1. Hive
  2. HIVE-4348

Unit test compile fail at hbase-handler project on Windows becuase of illegal escape character

    Details

      Description

      The problem is because the automatically generated test case hardcoded file path string of query file using "\" instead of "
      " as escape character. The change should be in the TestHBaseCliDriver.vm and TestHBaseNegativeCliDriver.vm

      1. HIVE-4348.patch
        1 kB
        Shuaishuai Nie

        Issue Links

          Activity

          Shuaishuai Nie created issue -
          Shuaishuai Nie made changes -
          Field Original Value New Value
          Attachment HIVE-4348.patch [ 12578468 ]
          Shuaishuai Nie made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Shuaishuai Nie made changes -
          Assignee Shuaishuai Nie [ shuainie ]
          Hide
          Eric Hanson added a comment -

          Can somebody please review this and commit it? Unit tests don't run without this patch so I have to manually apply this on Windows when developing. This gets tedious when using different branches for creating patches.

          Show
          Eric Hanson added a comment - Can somebody please review this and commit it? Unit tests don't run without this patch so I have to manually apply this on Windows when developing. This gets tedious when using different branches for creating patches.
          Shuaishuai Nie made changes -
          Link This issue is part of HIVE-2998 [ HIVE-2998 ]
          Hide
          Ashutosh Chauhan added a comment -

          Shuaishuai Nie I assume you have also tested this on linux. Is that correct ?

          Show
          Ashutosh Chauhan added a comment - Shuaishuai Nie I assume you have also tested this on linux. Is that correct ?
          Hide
          Ashutosh Chauhan added a comment -

          I tested it on linux. Works great. +1

          Show
          Ashutosh Chauhan added a comment - I tested it on linux. Works great. +1
          Hide
          Ashutosh Chauhan added a comment -

          Committed to trunk. Thanks, Shuaishuai!

          Show
          Ashutosh Chauhan added a comment - Committed to trunk. Thanks, Shuaishuai!
          Ashutosh Chauhan made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Fix Version/s 0.12.0 [ 12324312 ]
          Resolution Fixed [ 1 ]
          Hide
          Shuaishuai Nie added a comment -
          Show
          Shuaishuai Nie added a comment - Thanks Ashutosh Chauhan
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-hadoop2 #227 (See https://builds.apache.org/job/Hive-trunk-hadoop2/227/)
          HIVE-4348 : Unit test compile fail at hbase-handler project on Windows becuase of illegal escape character (Shuaishuai Nie via Ashutosh Chauhan) (Revision 1490103)

          Result = FAILURE
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490103
          Files :

          • /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm
          • /hive/trunk/hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm
          Show
          Hudson added a comment - Integrated in Hive-trunk-hadoop2 #227 (See https://builds.apache.org/job/Hive-trunk-hadoop2/227/ ) HIVE-4348 : Unit test compile fail at hbase-handler project on Windows becuase of illegal escape character (Shuaishuai Nie via Ashutosh Chauhan) (Revision 1490103) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490103 Files : /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm /hive/trunk/hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm
          Hide
          Hudson added a comment -

          Integrated in Hive-trunk-h0.21 #2131 (See https://builds.apache.org/job/Hive-trunk-h0.21/2131/)
          HIVE-4348 : Unit test compile fail at hbase-handler project on Windows becuase of illegal escape character (Shuaishuai Nie via Ashutosh Chauhan) (Revision 1490103)

          Result = FAILURE
          hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490103
          Files :

          • /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm
          • /hive/trunk/hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm
          Show
          Hudson added a comment - Integrated in Hive-trunk-h0.21 #2131 (See https://builds.apache.org/job/Hive-trunk-h0.21/2131/ ) HIVE-4348 : Unit test compile fail at hbase-handler project on Windows becuase of illegal escape character (Shuaishuai Nie via Ashutosh Chauhan) (Revision 1490103) Result = FAILURE hashutosh : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1490103 Files : /hive/trunk/hbase-handler/src/test/templates/TestHBaseCliDriver.vm /hive/trunk/hbase-handler/src/test/templates/TestHBaseNegativeCliDriver.vm
          Hide
          Ashutosh Chauhan added a comment -

          This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.

          Show
          Ashutosh Chauhan added a comment - This issue has been fixed and released as part of 0.12 release. If you find further issues, please create a new jira and link it to this one.
          Ashutosh Chauhan made changes -
          Status Resolved [ 5 ] Closed [ 6 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          8h 45m 1 Shuaishuai Nie 13/Apr/13 02:22
          Patch Available Patch Available Resolved Resolved
          53d 23h 58m 1 Ashutosh Chauhan 06/Jun/13 02:20
          Resolved Resolved Closed Closed
          131d 22h 9m 1 Ashutosh Chauhan 16/Oct/13 00:30

            People

            • Assignee:
              Shuaishuai Nie
              Reporter:
              Shuaishuai Nie
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Time Tracking

                Estimated:
                Original Estimate - 24h
                24h
                Remaining:
                Remaining Estimate - 24h
                24h
                Logged:
                Time Spent - Not Specified
                Not Specified

                  Development